mbox series

[v3,0/3] adt7316 regmap implementation

Message ID 20190120153633.18231-1-shreeya.patel23498@gmail.com (mailing list archive)
Headers show
Series adt7316 regmap implementation | expand

Message

Shreeya Patel Jan. 20, 2019, 3:36 p.m. UTC
This patchset consist of some initial patches for heading
towards the regmap implementation and also the final patch
which enables the driver to use regmap API thus removing
the redundant and common code.

Changes in v3
  -Fetch the changes from remote and rebase to have it in
the current working directory.

Changes in v2
  -Change the val_bits to 8 and add two more patches
having a different change before the final implemetation
of regmap.

Shreeya Patel (3):
  Staging: iio: adt7316: Remove irq from bus structure
  Staging: iio: adt7316: Remove multi read and write functions
  Staging: iio: adt7316: Add regmap support

 drivers/staging/iio/addac/adt7316-i2c.c |  97 ++--------------
 drivers/staging/iio/addac/adt7316-spi.c |  95 +++------------
 drivers/staging/iio/addac/adt7316.c     | 147 ++++++++++++------------
 drivers/staging/iio/addac/adt7316.h     |  15 +--
 4 files changed, 103 insertions(+), 251 deletions(-)

Comments

Jeremy Fertic Jan. 26, 2019, 1:22 a.m. UTC | #1
On Sun, Jan 20, 2019 at 09:06:30PM +0530, Shreeya Patel wrote:
> This patchset consist of some initial patches for heading
> towards the regmap implementation and also the final patch
> which enables the driver to use regmap API thus removing
> the redundant and common code.
> 
> Changes in v3
>   -Fetch the changes from remote and rebase to have it in
> the current working directory.
> 
> Changes in v2
>   -Change the val_bits to 8 and add two more patches
> having a different change before the final implemetation
> of regmap.
> 
> Shreeya Patel (3):
>   Staging: iio: adt7316: Remove irq from bus structure
>   Staging: iio: adt7316: Remove multi read and write functions
>   Staging: iio: adt7316: Add regmap support
> 
>  drivers/staging/iio/addac/adt7316-i2c.c |  97 ++--------------
>  drivers/staging/iio/addac/adt7316-spi.c |  95 +++------------
>  drivers/staging/iio/addac/adt7316.c     | 147 ++++++++++++------------
>  drivers/staging/iio/addac/adt7316.h     |  15 +--
>  4 files changed, 103 insertions(+), 251 deletions(-)
> 
> -- 
> 2.17.1
> 

The series doesn't apply to the current iio testing branch. If there's any
value in a quick sanity testing, I can do that after a rebase. I wasn't
planning to test everything the patch touches, but thought I could at
least test a few register reads and writes to make sure we haven't missed
anything obvious in the regmap implementation.

Jeremy
Shreeya Patel Jan. 26, 2019, 5:12 a.m. UTC | #2
On Fri, 2019-01-25 at 18:22 -0700, Jeremy Fertic wrote:
> On Sun, Jan 20, 2019 at 09:06:30PM +0530, Shreeya Patel wrote:
> > This patchset consist of some initial patches for heading
> > towards the regmap implementation and also the final patch
> > which enables the driver to use regmap API thus removing
> > the redundant and common code.
> > 
> > Changes in v3
> >   -Fetch the changes from remote and rebase to have it in
> > the current working directory.
> > 
> > Changes in v2
> >   -Change the val_bits to 8 and add two more patches
> > having a different change before the final implemetation
> > of regmap.
> > 
> > Shreeya Patel (3):
> >   Staging: iio: adt7316: Remove irq from bus structure
> >   Staging: iio: adt7316: Remove multi read and write functions
> >   Staging: iio: adt7316: Add regmap support
> > 
> >  drivers/staging/iio/addac/adt7316-i2c.c |  97 ++--------------
> >  drivers/staging/iio/addac/adt7316-spi.c |  95 +++------------
> >  drivers/staging/iio/addac/adt7316.c     | 147 ++++++++++++------
> > ------
> >  drivers/staging/iio/addac/adt7316.h     |  15 +--
> >  4 files changed, 103 insertions(+), 251 deletions(-)
> > 
> > -- 
> > 2.17.1
> > 
> 
> The series doesn't apply to the current iio testing branch. If
> there's any
> value in a quick sanity testing, I can do that after a rebase. I
> wasn't
> planning to test everything the patch touches, but thought I could at
> least test a few register reads and writes to make sure we haven't
> missed
> anything obvious in the regmap implementation.

Hi Jeremy,

Is it still not applying? Jonathan told me that v2 of this series
wasn't applying so I rebased for this series.

I hope I didn't mess things up while rebasing :(

Thanks

> 
> Jeremy
>
Shreeya Patel Jan. 26, 2019, 6:18 a.m. UTC | #3
On Sat, 2019-01-26 at 10:42 +0530, Shreeya Patel wrote:
> On Fri, 2019-01-25 at 18:22 -0700, Jeremy Fertic wrote:
> > On Sun, Jan 20, 2019 at 09:06:30PM +0530, Shreeya Patel wrote:
> > > This patchset consist of some initial patches for heading
> > > towards the regmap implementation and also the final patch
> > > which enables the driver to use regmap API thus removing
> > > the redundant and common code.
> > > 
> > > Changes in v3
> > >   -Fetch the changes from remote and rebase to have it in
> > > the current working directory.
> > > 
> > > Changes in v2
> > >   -Change the val_bits to 8 and add two more patches
> > > having a different change before the final implemetation
> > > of regmap.
> > > 
> > > Shreeya Patel (3):
> > >   Staging: iio: adt7316: Remove irq from bus structure
> > >   Staging: iio: adt7316: Remove multi read and write functions
> > >   Staging: iio: adt7316: Add regmap support
> > > 
> > >  drivers/staging/iio/addac/adt7316-i2c.c |  97 ++--------------
> > >  drivers/staging/iio/addac/adt7316-spi.c |  95 +++------------
> > >  drivers/staging/iio/addac/adt7316.c     | 147 ++++++++++++------
> > > ------
> > >  drivers/staging/iio/addac/adt7316.h     |  15 +--
> > >  4 files changed, 103 insertions(+), 251 deletions(-)
> > > 
> > > -- 
> > > 2.17.1
> > > 
> > 
> > The series doesn't apply to the current iio testing branch. If
> > there's any
> > value in a quick sanity testing, I can do that after a rebase. I
> > wasn't
> > planning to test everything the patch touches, but thought I could
> > at
> > least test a few register reads and writes to make sure we haven't
> > missed
> > anything obvious in the regmap implementation.
> 
> Hi Jeremy,
> 
> Is it still not applying? Jonathan told me that v2 of this series
> wasn't applying so I rebased for this series.
> 
> I hope I didn't mess things up while rebasing :(
> 
> Thanks

Yes it is my mistake. I've rebased against greg's staging tree.
I will soon send a v4 for the series.

Thanks

> 
> > 
> > Jeremy
> > 
> 
>