From patchwork Thu Mar 12 08:35:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru Ardelean X-Patchwork-Id: 11433577 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F099D92A for ; Thu, 12 Mar 2020 08:35:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C6FB020716 for ; Thu, 12 Mar 2020 08:35:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AjSigQ+e" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726446AbgCLIfX (ORCPT ); Thu, 12 Mar 2020 04:35:23 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:34309 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726028AbgCLIfX (ORCPT ); Thu, 12 Mar 2020 04:35:23 -0400 Received: by mail-wr1-f66.google.com with SMTP id z15so6261715wrl.1; Thu, 12 Mar 2020 01:35:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3IFqN6MB3GTmATgSt6r/JP4eRllSm3kKhP+kosvq7sI=; b=AjSigQ+e2oK7s0GDmXX4WxVkTrEAGX9xJg6+Cpsvd8G2ajvc3WEi/NdzLryIhTaeDv WNI5OCBJdnApR1xhlZGkgF0vUBXKr9WSGTekLPGtsgxYMVp/uL5sOyZjruPTZlaMNPak x4M4FJy5+SLGCJr56ezyfxpCakSUWvGFz0L3U640n1Jn6rNAYw2T5IQtJq9LySuioHwy elGZye3GiuD6v3xq9OB+qSpNtoBECHju6QUO3BwjpsdGEKUpFHSPwzRdd8jFidgX4wbD Voys5hEfOkn050nruIQtR2mkiWiWM8RSs7WnhzWxl4SI7RRlLRayC9+qJ+eQt4fTWKEp KnsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3IFqN6MB3GTmATgSt6r/JP4eRllSm3kKhP+kosvq7sI=; b=aHXH7H5DUFvEMzPF6NR4SKwB6icJLdlwTdqcgIv2xCgTjnq4UAc65MB14CvduiHcXj Eqa40yAcCudsNv8MbpDwee/fg2OBL4N4BD9IjdM1NWqAg5qGm4/qay1iyE5byTftbtqc oY3XYc0aCW/CuvBrdcgBBk6YVRUdAW9mBwPEVYliq9P1o4GeqD1c+L9nARDD5/2j17S0 p70RsGdckBJQ5Egee7wJNktnfSDIT61RwFEn2g5ZYJ7KjUs3IxUdq5w3wk/tHDnKjez7 yW1k75Wr0intp5UafSVY5IXVyZOVlL53UtGUXqfxcL0fYa4yycG8nCICUj9v0u7Cs8g9 SXhQ== X-Gm-Message-State: ANhLgQ3TZBh1ShYU6h9LcJ9A+g4awsdODS5cq8H1rvy+qFzvfvxOVqT8 F2bd2LSYpzjj/LarY7wLNauH7GmnR9s= X-Google-Smtp-Source: ADFU+vvwUmLCKai449B8kH/7Zy0dBNDmlnBa2dzWBqltlqmH+3NICuK6vaXJ5jCSwjPy230Q6j2e1w== X-Received: by 2002:adf:df82:: with SMTP id z2mr9219417wrl.46.1584002118594; Thu, 12 Mar 2020 01:35:18 -0700 (PDT) Received: from localhost.localdomain ([188.26.73.247]) by smtp.gmail.com with ESMTPSA id 9sm11543334wmo.38.2020.03.12.01.35.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2020 01:35:17 -0700 (PDT) From: Alexandru Ardelean X-Google-Original-From: Alexandru Ardelean To: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: jic23@kernel.org, robh+dt@kernel.org, Laszlo.Nagy@analog.com, Andrei.Grozav@analog.com, Michael.Hennerich@analog.com, Istvan.Csomortani@analog.com, Adrian.Costina@analog.com, Dragos.Bogdan@analog.com, Alexandru Ardelean Subject: [PATCH v9 0/8] iio: adi-axi-adc,ad9647: Add support for AD9467 ADC Date: Thu, 12 Mar 2020 10:35:03 +0200 Message-Id: <20200312083511.28832-1-alexandru.ardelean@analog.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org This changeset adds support for the AD9467 LVDS High-Speed ADC. In order to support it, support for an FPGA ADI AXI ADC is added in this set. This uses the current support for IIO buffer DMAEngine. Changelog v8 -> v9: * adding more Analog people to the list; predominantly HDL people; this should help me sync people about the details of regs/reg-names * added 'Acked-by: Moritz Fischer ' tag to fpga patches - we can always re-update these patches if something else is decided about the location of the 'adi-axi-common.h' header; I'm not insisting about where to put it; I'm open to other proposals * patch 'iio: adc: adi-axi-adc: add support for AXI ADC IP core' - prefixed regs ADI_AXI_ ; I tried ADI_AXI_ADC_, but that seemed to make them too long - dropped unused regs; will add them as stuff gets added in the upstream driver; in the meantime, reg-names can be reworked - dropped generic LOWERXY_SET/GET macros - update reg-names a bit; will update them in the docs and HDL - order in adi_axi_adc_conv_unregister() should now be symmetrically oppposite now to the register function - implemented 'is_visible()' callback to adi_axi_adc_attributes[] so that attrs can be made invisible to userspace if needed; - 'indio_dev->name = "adi-axi-adc";' - added kernel doc-string for @reg_access * patch 'iio: adc: ad9467: add support AD9467 ADC' - ad9467_spi_read() split in 2 buffers; tbuf & rbuf - removed 'if (chan->extend_name)' test ; left-over from initial driver - removed 'if (!st->clk)' check; driver will fail probe without a clock - removed 'if (!spi->dev.of_node)' in probe; shouldn't be needed - using 'of_device_get_match_data()' in probe to get data; moved chip info table entry as data on the of_device_id table Changelog v7 -> v8: * in 'iio: adc: adi-axi-adc: add support for AXI ADC IP core' - updated register definitions and bits to newer format/docs; the ref driver wasn't really up-to-date -- prefixed bit names with reg-name to avoid bit definition colisions; that makes some macros longer, but at least the format is consistent - using dev_name(&pdev->dev) for indio_dev->name - moved reset to own axi_adc_reset() function; may be re-used later - some re-formatting/alignment changes - address ENOSYS checkpatch complaint; changed with EOPNOTSUPP Changelog v6 -> v7: * Fixed dt-schema build for adi,axi-adc.yaml based on Rob's suggestion - added '$ref: /schemas/types.yaml#/definitions/phandle' to 'adi,adc-dev' - dropped 'maxItems' from 'adi,adc-dev' Changelog v5 -> v6 * fix URLs; got changed during rename https://wiki.analog.com/resources/fpga/docs/adi_axi_adc_ip -> https://wiki.analog.com/resources/fpga/docs/axi_adc_ip - noticed while working on the AXI DAC driver Changelog v4 -> v5: * update drivers/iio/adc/Kconfig note about module name; omitted during first rename - 'module will be called axi-adc.' -> 'module will be called adi-axi-adc.' Changelog v3 -> v4: * addressed Rob's dt-remarks - change 'adi-axi-adc-client' prop to 'adi,adc-dev' Changelog v2 -> v3: * addressed compiler warning Changelog v1 -> v2: * first series was added a bit hastily * addressed 'make dt_binding_check' complaints; seems I missed a few when running the check; * added missing patches to include/linux/fpga/adi-axi-common.h - 'include: fpga: adi-axi-common.h: fixup whitespace tab -> space' - 'include: fpga: adi-axi-common.h: add version helper macros' * patch 'iio: buffer-dmaengine: add dev-managed calls for buffer alloc/free' - remove copy+pasted comment for 'devm_iio_dmaengine_buffer_alloc()' - removed devm_iio_dmaengine_buffer_free() ; hopefully it might never be needed - fix-up alignment for devm_iio_dmaengine_buffer_alloc() in header * patch 'iio: adc: adi-axi-adc: add support for AXI ADC IP core' - renamed axi-adc.c -> adi-axi-adc.c & Kconfig symbol - prefix all axi_adc -> adi_axi_adc - removed switch statement in axi_adc_read_raw() & axi_adc_write_raw() - remove axi_adc_chan_spec ; replaced with iio_chan_spec directly ; will think of a simpler solution for extra chan params - removed left-over 'struct axi_adc_cleanup_data' - moved 'devm_add_action_or_reset()' call right after 'adi_axi_adc_attach_client()' - switched to using 'devm_platform_ioremap_resource()' * patch 'iio: adc: ad9467: add support AD9467 ADC' - renamed ADI_ADC reg prefixes to AN877_ADC - dropped 'info_mask_separate' field in AD9467_CHAN - will be re-added later when driver gets more features; was left-over from the initial ref driver - remove .shift = 0, in AD9467_CHAN - renamed 'sample-clock' -> 'adc-clock' - direct returns in ad9467_read_raw() & ad9467_write_raw() & ad9467_setup() switch statements - removed blank line after devm_axi_adc_conv_register() - removed ad9467_id & reworked to use ad9467_of_match Alexandru Ardelean (6): include: fpga: adi-axi-common.h: fixup whitespace tab -> space include: fpga: adi-axi-common.h: add version helper macros iio: buffer-dmaengine: use %zu specifier for sprintf(align) iio: buffer-dmaengine: add dev-managed calls for buffer alloc dt-bindings: iio: adc: add bindings doc for AXI ADC driver dt-bindings: iio: adc: add bindings doc for AD9467 ADC Michael Hennerich (2): iio: adc: adi-axi-adc: add support for AXI ADC IP core iio: adc: ad9467: add support AD9467 ADC .../bindings/iio/adc/adi,ad9467.yaml | 65 +++ .../bindings/iio/adc/adi,axi-adc.yaml | 63 +++ drivers/iio/adc/Kconfig | 35 ++ drivers/iio/adc/Makefile | 2 + drivers/iio/adc/ad9467.c | 420 ++++++++++++++ drivers/iio/adc/adi-axi-adc.c | 518 ++++++++++++++++++ .../buffer/industrialio-buffer-dmaengine.c | 41 +- include/linux/fpga/adi-axi-common.h | 6 +- include/linux/iio/adc/adi-axi-adc.h | 64 +++ include/linux/iio/buffer-dmaengine.h | 3 + 10 files changed, 1215 insertions(+), 2 deletions(-) create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml create mode 100644 drivers/iio/adc/ad9467.c create mode 100644 drivers/iio/adc/adi-axi-adc.c create mode 100644 include/linux/iio/adc/adi-axi-adc.h