mbox series

[RFC,0/4] iio: scan_mask rework to track enabled channels on per-channel basis

Message ID 20200424051818.6408-1-alexandru.ardelean@analog.com (mailing list archive)
Headers show
Series iio: scan_mask rework to track enabled channels on per-channel basis | expand

Message

Alexandru Ardelean April 24, 2020, 5:18 a.m. UTC 
From my side, I'll admit that the specific use-cases for these patches
are a bit outside of my scope of understanding.
I did my best to re-apply them on a newer tree, and dig-up the
information from the ADI tree [where they've been living for a while
now].

Also, I don't have any idea if there was a prior discussion about this.
I could not find anything on a quick search.

I'm hoping that the author would have some input on them/

Hence the RFC.

Lars-Peter Clausen (4):
  iio: Move scan mask management to the core
  iio: hw_consumer: use new scanmask functions
  iio: Allow channels to share storage elements
  iio: Track enabled channels on a per channel basis

 drivers/iio/buffer/industrialio-buffer-cb.c   | 17 ++--
 drivers/iio/buffer/industrialio-hw-consumer.c | 19 +++-
 drivers/iio/industrialio-buffer.c             | 98 +++++++++++++------
 drivers/iio/industrialio-core.c               | 27 +++--
 drivers/iio/inkern.c                          | 30 ++++++
 include/linux/iio/buffer_impl.h               |  3 +
 include/linux/iio/consumer.h                  | 12 +++
 7 files changed, 154 insertions(+), 52 deletions(-)

Comments

Nuno Sá April 24, 2020, 7:51 a.m. UTC | #1 
> From: linux-iio-owner@vger.kernel.org <linux-iio-owner@vger.kernel.org>
> On Behalf Of Alexandru Ardelean
> Sent: Freitag, 24. April 2020 07:18
> To: linux-iio@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: jic23@kernel.org; lars@metafoo.de; Ardelean, Alexandru
> <alexandru.Ardelean@analog.com>
> Subject: [RFC PATCH 0/4] iio: scan_mask rework to track enabled channels on
> per-channel basis
> 
> 
> From my side, I'll admit that the specific use-cases for these patches
> are a bit outside of my scope of understanding.
> I did my best to re-apply them on a newer tree, and dig-up the
> information from the ADI tree [where they've been living for a while
> now].
> 
> Also, I don't have any idea if there was a prior discussion about this.
> I could not find anything on a quick search.
> 
> I'm hoping that the author would have some input on them/
> 
> Hence the RFC.
> 

Yeah, I remember I stumbled against this when looking to some of our drivers where we have (IIRC) a 16
channel ADC where 1 channel occupies 1 bit. I just gave a quick look on this and it looks good to me
(naturally it needs a deeper look :D). I just have one remark/question inline in patch 4.

- Nuno Sá