| Message ID | 20200430155810.21383-1-sravanhome@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add battery charger driver support for MP2629 | expand |
Hi, I expect, that Lee will provide an immutable branch for me and Jonathan once the MFD bits have been reviewed. Please tell me, if I should prepare one instead. -- Sebastian On Thu, Apr 30, 2020 at 05:58:04PM +0200, Saravanan Sekar wrote: > changes in v11: > - module_remove part replaced by devm_add_action_or_reset in charger patch > - minor review comments solved in mfd and adc patch > > changes in v10: > - fixed typo, \n in dev_err > - dt bindings Warning (unit_address_vs_reg) reported by bot > > changes in v9: > - fixed review comments in mp2629 power supply such as resource based > iio channel, replace workqueue by threaded irq, irq get with "_optional" > > changes in v8: > - fixed order of call in probe/remove in iio adc > - add ABI documentation for mp2629 power supply > > changes in v7: > - fixed probe/remove order, managed and unmanaged call mix use in adc. > - Documentation dual license, i2c node with controller address > > Overall looks good to me, FWIW, > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > > One question though in reply to patch 4. > > changes in v6: > - removed includes types.h in mfd, of_device.h in adc. > - fixed review comments parentheses, err check, kstrtouint > > changes in v5: > - removed platfrom data stored in mfd and directly accessed mfd struct in child > - fixed spell check and capitalization in mfd and documentation > > changes in v4: > - fixed capitalization in mfg Kconfig and documentation > > changes in v3: > - regmap for children passed using platform data and remove mfd driver info > access directly from children > > changes in v2: > - removed EXPORT_SYMBOL of register set/get helper > - regmap bit filed used, fixed other review comments > > This patch series add support for Battery charger control driver for Monolithic > Power System's MP2629 chipset, includes MFD driver for ADC battery & input > power supply measurement and battery charger control driver. > > Thanks, > Saravanan > > Saravanan Sekar (6): > dt-bindings: mfd: add document bindings for mp2629 > mfd: mp2629: Add support for mps battery charger > iio: adc: mp2629: Add support for mp2629 ADC driver > power: supply: Add support for mps mp2629 battery charger > power: supply: mp2629: Add impedance compensation config > MAINTAINERS: Add entry for mp2629 Battery Charger driver > > .../ABI/testing/sysfs-class-power-mp2629 | 8 + > .../devicetree/bindings/mfd/mps,mp2629.yaml | 62 ++ > MAINTAINERS | 5 + > drivers/iio/adc/Kconfig | 10 + > drivers/iio/adc/Makefile | 1 + > drivers/iio/adc/mp2629_adc.c | 208 ++++++ > drivers/mfd/Kconfig | 9 + > drivers/mfd/Makefile | 2 + > drivers/mfd/mp2629.c | 79 +++ > drivers/power/supply/Kconfig | 10 + > drivers/power/supply/Makefile | 1 + > drivers/power/supply/mp2629_charger.c | 669 ++++++++++++++++++ > include/linux/mfd/mp2629.h | 26 + > 13 files changed, 1090 insertions(+) > create mode 100644 Documentation/ABI/testing/sysfs-class-power-mp2629 > create mode 100644 Documentation/devicetree/bindings/mfd/mps,mp2629.yaml > create mode 100644 drivers/iio/adc/mp2629_adc.c > create mode 100644 drivers/mfd/mp2629.c > create mode 100644 drivers/power/supply/mp2629_charger.c > create mode 100644 include/linux/mfd/mp2629.h > > -- > 2.17.1 >
changes in v11: - module_remove part replaced by devm_add_action_or_reset in charger patch - minor review comments solved in mfd and adc patch changes in v10: - fixed typo, \n in dev_err - dt bindings Warning (unit_address_vs_reg) reported by bot changes in v9: - fixed review comments in mp2629 power supply such as resource based iio channel, replace workqueue by threaded irq, irq get with "_optional" changes in v8: - fixed order of call in probe/remove in iio adc - add ABI documentation for mp2629 power supply changes in v7: - fixed probe/remove order, managed and unmanaged call mix use in adc. - Documentation dual license, i2c node with controller address Overall looks good to me, FWIW, Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> One question though in reply to patch 4. changes in v6: - removed includes types.h in mfd, of_device.h in adc. - fixed review comments parentheses, err check, kstrtouint changes in v5: - removed platfrom data stored in mfd and directly accessed mfd struct in child - fixed spell check and capitalization in mfd and documentation changes in v4: - fixed capitalization in mfg Kconfig and documentation changes in v3: - regmap for children passed using platform data and remove mfd driver info access directly from children changes in v2: - removed EXPORT_SYMBOL of register set/get helper - regmap bit filed used, fixed other review comments This patch series add support for Battery charger control driver for Monolithic Power System's MP2629 chipset, includes MFD driver for ADC battery & input power supply measurement and battery charger control driver. Thanks, Saravanan Saravanan Sekar (6): dt-bindings: mfd: add document bindings for mp2629 mfd: mp2629: Add support for mps battery charger iio: adc: mp2629: Add support for mp2629 ADC driver power: supply: Add support for mps mp2629 battery charger power: supply: mp2629: Add impedance compensation config MAINTAINERS: Add entry for mp2629 Battery Charger driver .../ABI/testing/sysfs-class-power-mp2629 | 8 + .../devicetree/bindings/mfd/mps,mp2629.yaml | 62 ++ MAINTAINERS | 5 + drivers/iio/adc/Kconfig | 10 + drivers/iio/adc/Makefile | 1 + drivers/iio/adc/mp2629_adc.c | 208 ++++++ drivers/mfd/Kconfig | 9 + drivers/mfd/Makefile | 2 + drivers/mfd/mp2629.c | 79 +++ drivers/power/supply/Kconfig | 10 + drivers/power/supply/Makefile | 1 + drivers/power/supply/mp2629_charger.c | 669 ++++++++++++++++++ include/linux/mfd/mp2629.h | 26 + 13 files changed, 1090 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-class-power-mp2629 create mode 100644 Documentation/devicetree/bindings/mfd/mps,mp2629.yaml create mode 100644 drivers/iio/adc/mp2629_adc.c create mode 100644 drivers/mfd/mp2629.c create mode 100644 drivers/power/supply/mp2629_charger.c create mode 100644 include/linux/mfd/mp2629.h