[v4,00/15] sx9310 iio driver updates

Message

Daniel Campello Aug. 3, 2020, 11:41 p.m. UTC

The first patch resends the DT binding for the driver that was merged in
v5.8-rc1 with a small change to update for proper regulators. The second
through the eleventh patch fixes several issues dropped from v8 to v9
when the initial patch was merged.  The twelveth patch drops
channel_users because it's unused. The thirteenth patch adds support to
enable the svdd and vdd supplies so that this driver can work on a board
where the svdd supply isn't enabled at boot and needs to be turned on
before this driver starts to communicate with the chip. The final patch
updates irq trigger flags.

Changes in v4:
 - Updated macro SX9310_REG_STAT1_COMPSTAT_MASK at call site.
 - Use FIELD_GET/FIELD_PREP instead of manual shift.
 - Reverted condition check logic on enable/disable_irq methods.
 - Use pointer to buffer struct on iio_push_to_buffers_with_timestamp().

Changes in v3:
 - Moved irq presence check down to lower methods
 - Changed buffer to struct type to align timestamp memory properly.
 - Added static assert for number of channels.
 - Added irq trigger flags commit to the series.

Changes in v2:
 - Added #io-channel-cells as a required property
 - Reordered error handling on sx9310_resume()
 - Added #include <linux/mod_devicetable.h>
 - Added '\n' to dev_err()
 - Fixed commit message from "iio: sx9310: Align memory"
 - Changed prox_stat to chan_prox_stat bitmap.
 - Fixed dev_err() message
 - Added '\n' to dev_err()

Daniel Campello (12):
  dt-bindings: iio: Add bindings for sx9310 sensor
  iio: sx9310: Update macros declarations
  iio: sx9310: Fix irq handling
  iio: sx9310: Remove acpi and of table macros
  iio: sx9310: Change from .probe to .probe_new
  iio: sx9310: Fixes various memory handling
  iio: sx9310: Use long instead of int for channel bitmaps
  iio: sx9310: Use regmap_read_poll_timeout() for compensation
  iio: sx9310: Update copyright
  iio: sx9310: Simplify error return handling
  iio: sx9310: Use variable to hold &client->dev
  iio: sx9310: Miscellaneous format fixes

Stephen Boyd (3):
  iio: sx9310: Drop channel_users[]
  iio: sx9310: Enable vdd and svdd regulators at probe
  iio: sx9310: Use irq trigger flags from firmware

 .../iio/proximity/semtech,sx9310.yaml         |  65 +++
 drivers/iio/proximity/sx9310.c                | 421 +++++++++---------
 2 files changed, 276 insertions(+), 210 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/iio/proximity/semtech,sx9310.yaml

--
2.28.0.163.g6104cc2f0b6-goog

Comments

Daniel Campello Aug. 3, 2020, 11:50 p.m. UTC | #1

Hi everyone,

So sorry, I sent an intermediate version as v4. Please disregard since
it has a couple bugs. I will send v5 with them fixed.

Regards,
Daniel

On Mon, Aug 3, 2020 at 5:41 PM Daniel Campello <[e-mail]> wrote:
>
> The first patch resends the DT binding for the driver that was merged in
> v5.8-rc1 with a small change to update for proper regulators. The second
> through the eleventh patch fixes several issues dropped from v8 to v9
> when the initial patch was merged.  The twelveth patch drops
> channel_users because it's unused. The thirteenth patch adds support to
> enable the svdd and vdd supplies so that this driver can work on a board
> where the svdd supply isn't enabled at boot and needs to be turned on
> before this driver starts to communicate with the chip. The final patch
> updates irq trigger flags.
>
> Changes in v4:
>  - Updated macro SX9310_REG_STAT1_COMPSTAT_MASK at call site.
>  - Use FIELD_GET/FIELD_PREP instead of manual shift.
>  - Reverted condition check logic on enable/disable_irq methods.
>  - Use pointer to buffer struct on iio_push_to_buffers_with_timestamp().
>
> Changes in v3:
>  - Moved irq presence check down to lower methods
>  - Changed buffer to struct type to align timestamp memory properly.
>  - Added static assert for number of channels.
>  - Added irq trigger flags commit to the series.
>
> Changes in v2:
>  - Added #io-channel-cells as a required property
>  - Reordered error handling on sx9310_resume()
>  - Added #include <linux/mod_devicetable.h>
>  - Added '\n' to dev_err()
>  - Fixed commit message from "iio: sx9310: Align memory"
>  - Changed prox_stat to chan_prox_stat bitmap.
>  - Fixed dev_err() message
>  - Added '\n' to dev_err()
>
> Daniel Campello (12):
>   dt-bindings: iio: Add bindings for sx9310 sensor
>   iio: sx9310: Update macros declarations
>   iio: sx9310: Fix irq handling
>   iio: sx9310: Remove acpi and of table macros
>   iio: sx9310: Change from .probe to .probe_new
>   iio: sx9310: Fixes various memory handling
>   iio: sx9310: Use long instead of int for channel bitmaps
>   iio: sx9310: Use regmap_read_poll_timeout() for compensation
>   iio: sx9310: Update copyright
>   iio: sx9310: Simplify error return handling
>   iio: sx9310: Use variable to hold &client->dev
>   iio: sx9310: Miscellaneous format fixes
>
> Stephen Boyd (3):
>   iio: sx9310: Drop channel_users[]
>   iio: sx9310: Enable vdd and svdd regulators at probe
>   iio: sx9310: Use irq trigger flags from firmware
>
>  .../iio/proximity/semtech,sx9310.yaml         |  65 +++
>  drivers/iio/proximity/sx9310.c                | 421 +++++++++---------
>  2 files changed, 276 insertions(+), 210 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/iio/proximity/semtech,sx9310.yaml
>
> --
> 2.28.0.163.g6104cc2f0b6-goog
>