mbox series

[v6,0/5] iio: temperature: mlx90632: Add extended calibration calculations

Message ID 20200818213737.140613-1-cmo@melexis.com
Headers show
Series iio: temperature: mlx90632: Add extended calibration calculations | expand

Message

Crt Mori Aug. 18, 2020, 9:37 p.m. UTC
Add extended calibration calculations for the new subversion of DSP5.

V6 review comments from Andy Shevchenko <andy.shevchenko@gmail.com:
	 - Covert all while loops to regmap_read_poll_timeout or
	   read_poll_timeout even though udelay of more than 20ms is used
	   in the second. Problem was, that timeout needs to be 800ms,
	   while polling frequency could be 20ms, but we konw that that
	   will generate more noise on line than needed. Did some tests and
	   current number combination seems best. This also caused that
	   commit messages were adjusted.
V5 review comments from Andy Shevchenko <andy.shevchenko@gmail.com:
	 -  Swap order of patches to avoid re-doing the calculations
	 - Add fixed name defines for Ambient and Object RAM temperature
	   channels as per suggestion of the Jonathan Cameron <jic23@kernel.org>
V5:
	 - Add style changes patch along with current series.

V4 review comments from Andy Shevchenko <andy.shevchenko@gmail.com>:
	 - Move the function creation for Ta4 to first patch
	 - Add kernel doc patch for documenting internal struct
	 - Add patch to convert while loops to do-while loops for
	   polling

V3 review comments from Andy Shevchenko <andy.shevchenko@gmail.com>:
	 - Change commit message text to more proper English as per suggestions
	 - Drop unneeded brackets and parentheses
	 - Use defines from limits.h
	 - Remove userspace typedefs as leftovers from porting
	 - Testing of timeout loops with iopoll.h was no successful,
	   because delay between measurements is 10ms, but we need to
	   fill at least 3 channels, so final timeout should be 40ms
	   which is out of scope of usleep function
	 - Fixing some typos in comments

V2 review comments from Andy Shevchenko <andy.shevchenko@gmail.com>:
	 - Convert divison back to shifts to make it more readable

Crt Mori (5):
  iio:temperature:mlx90632: Reduce number of equal calulcations
  iio:temperature:mlx90632: Add kerneldoc to the internal struct
  iio:temperature:mlx90632: Convert polling while loop to regmap
  iio:temperature:mlx90632: Adding extended calibration option
  iio:temperature:mlx90632: Some stylefixing leftovers

 drivers/iio/temperature/mlx90632.c | 274 ++++++++++++++++++++++++++---
 1 file changed, 247 insertions(+), 27 deletions(-)

Comments

Jonathan Cameron Aug. 29, 2020, 5:28 p.m. UTC | #1
On Tue, 18 Aug 2020 23:37:32 +0200
Crt Mori <cmo@melexis.com> wrote:

> Add extended calibration calculations for the new subversion of DSP5.
> 
> V6 review comments from Andy Shevchenko <andy.shevchenko@gmail.com:
> 	 - Covert all while loops to regmap_read_poll_timeout or
> 	   read_poll_timeout even though udelay of more than 20ms is used
> 	   in the second. Problem was, that timeout needs to be 800ms,
> 	   while polling frequency could be 20ms, but we konw that that
> 	   will generate more noise on line than needed. Did some tests and
> 	   current number combination seems best. This also caused that
> 	   commit messages were adjusted.
> V5 review comments from Andy Shevchenko <andy.shevchenko@gmail.com:
> 	 -  Swap order of patches to avoid re-doing the calculations
> 	 - Add fixed name defines for Ambient and Object RAM temperature
> 	   channels as per suggestion of the Jonathan Cameron <jic23@kernel.org>
> V5:
> 	 - Add style changes patch along with current series.
> 
> V4 review comments from Andy Shevchenko <andy.shevchenko@gmail.com>:
> 	 - Move the function creation for Ta4 to first patch
> 	 - Add kernel doc patch for documenting internal struct
> 	 - Add patch to convert while loops to do-while loops for
> 	   polling
> 
> V3 review comments from Andy Shevchenko <andy.shevchenko@gmail.com>:
> 	 - Change commit message text to more proper English as per suggestions
> 	 - Drop unneeded brackets and parentheses
> 	 - Use defines from limits.h
> 	 - Remove userspace typedefs as leftovers from porting
> 	 - Testing of timeout loops with iopoll.h was no successful,
> 	   because delay between measurements is 10ms, but we need to
> 	   fill at least 3 channels, so final timeout should be 40ms
> 	   which is out of scope of usleep function
> 	 - Fixing some typos in comments
> 
> V2 review comments from Andy Shevchenko <andy.shevchenko@gmail.com>:
> 	 - Convert divison back to shifts to make it more readable
> 
> Crt Mori (5):
>   iio:temperature:mlx90632: Reduce number of equal calulcations
>   iio:temperature:mlx90632: Add kerneldoc to the internal struct
>   iio:temperature:mlx90632: Convert polling while loop to regmap
>   iio:temperature:mlx90632: Adding extended calibration option
>   iio:temperature:mlx90632: Some stylefixing leftovers
> 
>  drivers/iio/temperature/mlx90632.c | 274 ++++++++++++++++++++++++++---
>  1 file changed, 247 insertions(+), 27 deletions(-)
> 

Thanks.  Also thanks to Andy for all his review work on these!

Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to try and break it.

Thanks,

Jonathan