| Message ID | 20210426170251.351957-1-jic23@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | iio: cleanup some new instances of manual parent setting. | expand |
On Mon, Apr 26, 2021 at 8:04 PM Jonathan Cameron <jic23@kernel.org> wrote: > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > It seems I still haven't trained my eyes to spot these. > > I think they have all been introduced since > iio_device_alloc() and friends started setting this > 8525df47b3d1e ("iio: core: fix/re-introduce back parent assignment") > 78289b4a58b58 ("iio: core: pass parent device as parameter during allocation") > > Anyhow, all seem fairly obvious to me, but maybe I missed something so please > take a look. I've added 2 comments that are unrelated [directly] to this series. Reviewed-by: Alexandru Ardelean <ardeleanalex@gmail.com> > > Jonathan Cameron (8): > iio: accel: bmi088: Drop manual assignment of iio_dev.dev.parent > iio: dac: ad5766: Drop duplicate setting of iio_dev.dev.parent > iio: adc: mp2629: Drop duplicate setting iio_dev.dev.parent > iio: adc: mt6360: Drop duplicate setting of iio_dev.dev.parent > iio: adc: ti-ads131e08: Drop duplicate setting of iio_dev.dev.parent > iio: humidity: hdc2010: Drop duplicate setting of iio_dev.dev.parent > iio: position: hid-sensor-custom-intel-hinge: Drop duplicate parent > setting. > iio: common: scmi_sensors: Drop duplicate setting of > iio_dev.dev.parent > > drivers/iio/accel/bmi088-accel-core.c | 1 - > drivers/iio/adc/mp2629_adc.c | 1 - > drivers/iio/adc/mt6360-adc.c | 1 - > drivers/iio/adc/ti-ads131e08.c | 1 - > drivers/iio/common/scmi_sensors/scmi_iio.c | 1 - > drivers/iio/dac/ad5766.c | 1 - > drivers/iio/humidity/hdc2010.c | 1 - > drivers/iio/position/hid-sensor-custom-intel-hinge.c | 1 - > 8 files changed, 8 deletions(-) > > -- > 2.31.1 >
On Tue, 27 Apr 2021 10:27:44 +0300 Alexandru Ardelean <ardeleanalex@gmail.com> wrote: > On Mon, Apr 26, 2021 at 8:04 PM Jonathan Cameron <jic23@kernel.org> wrote: > > > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > > > It seems I still haven't trained my eyes to spot these. > > > > I think they have all been introduced since > > iio_device_alloc() and friends started setting this > > 8525df47b3d1e ("iio: core: fix/re-introduce back parent assignment") > > 78289b4a58b58 ("iio: core: pass parent device as parameter during allocation") > > > > Anyhow, all seem fairly obvious to me, but maybe I missed something so please > > take a look. > > I've added 2 comments that are unrelated [directly] to this series. > > Reviewed-by: Alexandru Ardelean <ardeleanalex@gmail.com> Thanks for checking these. I've added the of_node dropping bit to the patch you pointed that out in. Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to poke at it and see if we missed anything! Thanks, Jonathan > > > > > Jonathan Cameron (8): > > iio: accel: bmi088: Drop manual assignment of iio_dev.dev.parent > > iio: dac: ad5766: Drop duplicate setting of iio_dev.dev.parent > > iio: adc: mp2629: Drop duplicate setting iio_dev.dev.parent > > iio: adc: mt6360: Drop duplicate setting of iio_dev.dev.parent > > iio: adc: ti-ads131e08: Drop duplicate setting of iio_dev.dev.parent > > iio: humidity: hdc2010: Drop duplicate setting of iio_dev.dev.parent > > iio: position: hid-sensor-custom-intel-hinge: Drop duplicate parent > > setting. > > iio: common: scmi_sensors: Drop duplicate setting of > > iio_dev.dev.parent > > > > drivers/iio/accel/bmi088-accel-core.c | 1 - > > drivers/iio/adc/mp2629_adc.c | 1 - > > drivers/iio/adc/mt6360-adc.c | 1 - > > drivers/iio/adc/ti-ads131e08.c | 1 - > > drivers/iio/common/scmi_sensors/scmi_iio.c | 1 - > > drivers/iio/dac/ad5766.c | 1 - > > drivers/iio/humidity/hdc2010.c | 1 - > > drivers/iio/position/hid-sensor-custom-intel-hinge.c | 1 - > > 8 files changed, 8 deletions(-) > > > > -- > > 2.31.1 > >
From: Jonathan Cameron <Jonathan.Cameron@huawei.com> It seems I still haven't trained my eyes to spot these. I think they have all been introduced since iio_device_alloc() and friends started setting this 8525df47b3d1e ("iio: core: fix/re-introduce back parent assignment") 78289b4a58b58 ("iio: core: pass parent device as parameter during allocation") Anyhow, all seem fairly obvious to me, but maybe I missed something so please take a look. Jonathan Cameron (8): iio: accel: bmi088: Drop manual assignment of iio_dev.dev.parent iio: dac: ad5766: Drop duplicate setting of iio_dev.dev.parent iio: adc: mp2629: Drop duplicate setting iio_dev.dev.parent iio: adc: mt6360: Drop duplicate setting of iio_dev.dev.parent iio: adc: ti-ads131e08: Drop duplicate setting of iio_dev.dev.parent iio: humidity: hdc2010: Drop duplicate setting of iio_dev.dev.parent iio: position: hid-sensor-custom-intel-hinge: Drop duplicate parent setting. iio: common: scmi_sensors: Drop duplicate setting of iio_dev.dev.parent drivers/iio/accel/bmi088-accel-core.c | 1 - drivers/iio/adc/mp2629_adc.c | 1 - drivers/iio/adc/mt6360-adc.c | 1 - drivers/iio/adc/ti-ads131e08.c | 1 - drivers/iio/common/scmi_sensors/scmi_iio.c | 1 - drivers/iio/dac/ad5766.c | 1 - drivers/iio/humidity/hdc2010.c | 1 - drivers/iio/position/hid-sensor-custom-intel-hinge.c | 1 - 8 files changed, 8 deletions(-)