mbox series

[v7,0/5] Expand Semtech SAR Sensors support

Message ID 20211210192328.2844060-1-gwendal@chromium.org (mailing list archive)
Headers show
Series Expand Semtech SAR Sensors support | expand

Message

Gwendal Grignou Dec. 10, 2021, 7:23 p.m. UTC
Add a new Semtech SAR sensor SX9324.
Instead of recopying 1/3 of the sx9310 driver, move common code in a new
file. It will be used again for the next sensor, SX9360.

Major changes in v7:
  Fix one remaining syntax error in device tree binding documentation.

Major changes in v6:
  Fix syntax errors in device tree binding documentation.
  Drop of_match_ptr and ACPI_PTR protections.
  Fix unused variable warning.

Major changes in v5:
  Use iwyu to cleanup include files.
  Use dev_err_probe() in probe routine
  Add attribute to shift irq status register, not common among all
    sensors.
  Fix long line.

Major changes in v4:
  Use chip_info instead of info in common data.
  Returns an error when setting negative sysfs entries
  Fix cut and paste errors, credit.

Major changes in v3:
  Fix some error in binding descriptions and setting
  Fix invalid register constant name.

Major changes in v2:
  Better interface between common code and drivers
  Document SX9324 phase configuration

Gwendal Grignou (5):
  iio: sx9310: Add frequency in read_avail
  iio: sx9310: Extract common Semtech sensor logic
  iio: proximity: Add SX9324 support
  dt-bindings: iio: Add sx9324 binding
  iio: sx9324: Add dt_binding support

 .../ABI/testing/sysfs-bus-iio-sx9324          |   28 +
 .../iio/proximity/semtech,sx9324.yaml         |  161 +++
 drivers/iio/proximity/Kconfig                 |   18 +
 drivers/iio/proximity/Makefile                |    2 +
 drivers/iio/proximity/sx9310.c                |  714 ++---------
 drivers/iio/proximity/sx9324.c                | 1076 +++++++++++++++++
 drivers/iio/proximity/sx_common.c             |  576 +++++++++
 drivers/iio/proximity/sx_common.h             |  163 +++
 8 files changed, 2127 insertions(+), 611 deletions(-)
 create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-sx9324
 create mode 100644 Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml
 create mode 100644 drivers/iio/proximity/sx9324.c
 create mode 100644 drivers/iio/proximity/sx_common.c
 create mode 100644 drivers/iio/proximity/sx_common.h

Comments

Jonathan Cameron Dec. 16, 2021, 3:50 p.m. UTC | #1
On Fri, 10 Dec 2021 11:23:23 -0800
Gwendal Grignou <gwendal@chromium.org> wrote:

> Add a new Semtech SAR sensor SX9324.
> Instead of recopying 1/3 of the sx9310 driver, move common code in a new
> file. It will be used again for the next sensor, SX9360.

Series applied to the togreg branch of iio.git and pushed out as testing
to let 0-day have a poke at it and see what it can find that we missed.

Thanks,

Jonathan

> 
> Major changes in v7:
>   Fix one remaining syntax error in device tree binding documentation.
> 
> Major changes in v6:
>   Fix syntax errors in device tree binding documentation.
>   Drop of_match_ptr and ACPI_PTR protections.
>   Fix unused variable warning.
> 
> Major changes in v5:
>   Use iwyu to cleanup include files.
>   Use dev_err_probe() in probe routine
>   Add attribute to shift irq status register, not common among all
>     sensors.
>   Fix long line.
> 
> Major changes in v4:
>   Use chip_info instead of info in common data.
>   Returns an error when setting negative sysfs entries
>   Fix cut and paste errors, credit.
> 
> Major changes in v3:
>   Fix some error in binding descriptions and setting
>   Fix invalid register constant name.
> 
> Major changes in v2:
>   Better interface between common code and drivers
>   Document SX9324 phase configuration
> 
> Gwendal Grignou (5):
>   iio: sx9310: Add frequency in read_avail
>   iio: sx9310: Extract common Semtech sensor logic
>   iio: proximity: Add SX9324 support
>   dt-bindings: iio: Add sx9324 binding
>   iio: sx9324: Add dt_binding support
> 
>  .../ABI/testing/sysfs-bus-iio-sx9324          |   28 +
>  .../iio/proximity/semtech,sx9324.yaml         |  161 +++
>  drivers/iio/proximity/Kconfig                 |   18 +
>  drivers/iio/proximity/Makefile                |    2 +
>  drivers/iio/proximity/sx9310.c                |  714 ++---------
>  drivers/iio/proximity/sx9324.c                | 1076 +++++++++++++++++
>  drivers/iio/proximity/sx_common.c             |  576 +++++++++
>  drivers/iio/proximity/sx_common.h             |  163 +++
>  8 files changed, 2127 insertions(+), 611 deletions(-)
>  create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-sx9324
>  create mode 100644 Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml
>  create mode 100644 drivers/iio/proximity/sx9324.c
>  create mode 100644 drivers/iio/proximity/sx_common.c
>  create mode 100644 drivers/iio/proximity/sx_common.h
>
Jonathan Cameron Dec. 16, 2021, 4:02 p.m. UTC | #2
On Thu, 16 Dec 2021 15:50:29 +0000
Jonathan Cameron <jic23@jic23.retrosnub.co.uk> wrote:

> On Fri, 10 Dec 2021 11:23:23 -0800
> Gwendal Grignou <gwendal@chromium.org> wrote:
> 
> > Add a new Semtech SAR sensor SX9324.
> > Instead of recopying 1/3 of the sx9310 driver, move common code in a new
> > file. It will be used again for the next sensor, SX9360.  
> 
> Series applied to the togreg branch of iio.git and pushed out as testing
> to let 0-day have a poke at it and see what it can find that we missed.
> 
And pulled out again.  Just noticed an issue with docs not matching
the actual ABI.

> Thanks,
> 
> Jonathan
> 
> > 
> > Major changes in v7:
> >   Fix one remaining syntax error in device tree binding documentation.
> > 
> > Major changes in v6:
> >   Fix syntax errors in device tree binding documentation.
> >   Drop of_match_ptr and ACPI_PTR protections.
> >   Fix unused variable warning.
> > 
> > Major changes in v5:
> >   Use iwyu to cleanup include files.
> >   Use dev_err_probe() in probe routine
> >   Add attribute to shift irq status register, not common among all
> >     sensors.
> >   Fix long line.
> > 
> > Major changes in v4:
> >   Use chip_info instead of info in common data.
> >   Returns an error when setting negative sysfs entries
> >   Fix cut and paste errors, credit.
> > 
> > Major changes in v3:
> >   Fix some error in binding descriptions and setting
> >   Fix invalid register constant name.
> > 
> > Major changes in v2:
> >   Better interface between common code and drivers
> >   Document SX9324 phase configuration
> > 
> > Gwendal Grignou (5):
> >   iio: sx9310: Add frequency in read_avail
> >   iio: sx9310: Extract common Semtech sensor logic
> >   iio: proximity: Add SX9324 support
> >   dt-bindings: iio: Add sx9324 binding
> >   iio: sx9324: Add dt_binding support
> > 
> >  .../ABI/testing/sysfs-bus-iio-sx9324          |   28 +
> >  .../iio/proximity/semtech,sx9324.yaml         |  161 +++
> >  drivers/iio/proximity/Kconfig                 |   18 +
> >  drivers/iio/proximity/Makefile                |    2 +
> >  drivers/iio/proximity/sx9310.c                |  714 ++---------
> >  drivers/iio/proximity/sx9324.c                | 1076 +++++++++++++++++
> >  drivers/iio/proximity/sx_common.c             |  576 +++++++++
> >  drivers/iio/proximity/sx_common.h             |  163 +++
> >  8 files changed, 2127 insertions(+), 611 deletions(-)
> >  create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-sx9324
> >  create mode 100644 Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml
> >  create mode 100644 drivers/iio/proximity/sx9324.c
> >  create mode 100644 drivers/iio/proximity/sx_common.c
> >  create mode 100644 drivers/iio/proximity/sx_common.h
> >   
>