mbox series

[v2,0/3] iio: Silan SC7A20 accelerometer support

Message ID 20220202235049.8051-1-samuel@sholland.org (mailing list archive)
Headers show
Series iio: Silan SC7A20 accelerometer support | expand

Message

Samuel Holland Feb. 2, 2022, 11:50 p.m. UTC
This chip is register-compatible with an ST part, so it works without
any issues when added to the existing driver.

Previously I called it a clone, but it's not really a clone, because
it's not a drop-in replacement for the other chips. The software
interface matches the ST parts, but the pinout does not. Instead, the
pinout matches the Kionix KX122 and KX132.

Changes in v2:
 - Move the new compatible to its own section
 - Add a comment about the WAI value
 - Update commit messages

Samuel Holland (3):
  dt-bindings: vendor-prefixes: Add silan vendor prefix
  dt-bindings: iio: st: Add Silan SC7A20 accelerometer
  iio: accel: st_accel: Add support for Silan SC7A20

 .../bindings/iio/st,st-sensors.yaml           |  3 +
 .../devicetree/bindings/vendor-prefixes.yaml  |  2 +
 drivers/iio/accel/st_accel.h                  |  2 +
 drivers/iio/accel/st_accel_core.c             | 83 +++++++++++++++++++
 drivers/iio/accel/st_accel_i2c.c              |  5 ++
 5 files changed, 95 insertions(+)

Comments

Jonathan Cameron Feb. 5, 2022, 5:25 p.m. UTC | #1
On Wed,  2 Feb 2022 17:50:45 -0600
Samuel Holland <samuel@sholland.org> wrote:

> This chip is register-compatible with an ST part, so it works without
> any issues when added to the existing driver.
> 
> Previously I called it a clone, but it's not really a clone, because
> it's not a drop-in replacement for the other chips. The software
> interface matches the ST parts, but the pinout does not. Instead, the
> pinout matches the Kionix KX122 and KX132.
Weird :)

I'm fine with the series, but as it contains a new vendor ID and the
dt-binding update I'll leave it on list for a bit longer to give
Rob time to sanity check that.

Thanks,

Jonathan

> 
> Changes in v2:
>  - Move the new compatible to its own section
>  - Add a comment about the WAI value
>  - Update commit messages
> 
> Samuel Holland (3):
>   dt-bindings: vendor-prefixes: Add silan vendor prefix
>   dt-bindings: iio: st: Add Silan SC7A20 accelerometer
>   iio: accel: st_accel: Add support for Silan SC7A20
> 
>  .../bindings/iio/st,st-sensors.yaml           |  3 +
>  .../devicetree/bindings/vendor-prefixes.yaml  |  2 +
>  drivers/iio/accel/st_accel.h                  |  2 +
>  drivers/iio/accel/st_accel_core.c             | 83 +++++++++++++++++++
>  drivers/iio/accel/st_accel_i2c.c              |  5 ++
>  5 files changed, 95 insertions(+)
>
Jonathan Cameron Feb. 13, 2022, 6:24 p.m. UTC | #2
On Wed,  2 Feb 2022 17:50:45 -0600
Samuel Holland <samuel@sholland.org> wrote:

> This chip is register-compatible with an ST part, so it works without
> any issues when added to the existing driver.
> 
> Previously I called it a clone, but it's not really a clone, because
> it's not a drop-in replacement for the other chips. The software
> interface matches the ST parts, but the pinout does not. Instead, the
> pinout matches the Kionix KX122 and KX132.
Series applied to the togreg branch of iio.git and pushed out as testing
to see if 0-day can find anything we missed.

Thanks,

Jonathan

> 
> Changes in v2:
>  - Move the new compatible to its own section
>  - Add a comment about the WAI value
>  - Update commit messages
> 
> Samuel Holland (3):
>   dt-bindings: vendor-prefixes: Add silan vendor prefix
>   dt-bindings: iio: st: Add Silan SC7A20 accelerometer
>   iio: accel: st_accel: Add support for Silan SC7A20
> 
>  .../bindings/iio/st,st-sensors.yaml           |  3 +
>  .../devicetree/bindings/vendor-prefixes.yaml  |  2 +
>  drivers/iio/accel/st_accel.h                  |  2 +
>  drivers/iio/accel/st_accel_core.c             | 83 +++++++++++++++++++
>  drivers/iio/accel/st_accel_i2c.c              |  5 ++
>  5 files changed, 95 insertions(+)
>