| Message ID | 20220807184534.1037363-1-jic23@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Trivial cleanup and refactor dev_pm_ops handling. | expand |
On Sun, 7 Aug 2022 19:45:32 +0100 Jonathan Cameron <jic23@kernel.org> wrote: > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > This driver was taking an unusual approach to handling the optionality of > structures / callbacks depending on CONFIG_PM. Bring it inline with > other similar drivers. > > Part of continuing to move IIO over to the new PM macros that don't require > such complex handling. Obviously setting a bad example here. Should have include iio: magn: hmc5843 as prefix for this cover letter. Sorry about that! > > Jonathan Cameron (2): > iio: magn: hmc5843: Drop excessive indentation of assignments of > hmc5843_driver > iio: magn: hmc5843: Move struct dev_pm_ops out of header > > drivers/iio/magnetometer/hmc5843.h | 13 +------------ > drivers/iio/magnetometer/hmc5843_core.c | 8 ++++---- > drivers/iio/magnetometer/hmc5843_i2c.c | 2 +- > drivers/iio/magnetometer/hmc5843_spi.c | 14 +++++++------- > 4 files changed, 13 insertions(+), 24 deletions(-) >
On Sun, Aug 7, 2022 at 8:38 PM Jonathan Cameron <jic23@kernel.org> wrote: > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > This driver was taking an unusual approach to handling the optionality of > structures / callbacks depending on CONFIG_PM. Bring it inline with > other similar drivers. > > Part of continuing to move IIO over to the new PM macros that don't require > such complex handling. Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Jonathan Cameron (2): > iio: magn: hmc5843: Drop excessive indentation of assignments of > hmc5843_driver > iio: magn: hmc5843: Move struct dev_pm_ops out of header > > drivers/iio/magnetometer/hmc5843.h | 13 +------------ > drivers/iio/magnetometer/hmc5843_core.c | 8 ++++---- > drivers/iio/magnetometer/hmc5843_i2c.c | 2 +- > drivers/iio/magnetometer/hmc5843_spi.c | 14 +++++++------- > 4 files changed, 13 insertions(+), 24 deletions(-) > > -- > 2.37.1 >
On Mon, 8 Aug 2022 11:22:00 +0200 Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Sun, Aug 7, 2022 at 8:38 PM Jonathan Cameron <jic23@kernel.org> wrote: > > > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > > > This driver was taking an unusual approach to handling the optionality of > > structures / callbacks depending on CONFIG_PM. Bring it inline with > > other similar drivers. > > > > Part of continuing to move IIO over to the new PM macros that don't require > > such complex handling. > > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> Thanks, Applied > > > Jonathan Cameron (2): > > iio: magn: hmc5843: Drop excessive indentation of assignments of > > hmc5843_driver > > iio: magn: hmc5843: Move struct dev_pm_ops out of header > > > > drivers/iio/magnetometer/hmc5843.h | 13 +------------ > > drivers/iio/magnetometer/hmc5843_core.c | 8 ++++---- > > drivers/iio/magnetometer/hmc5843_i2c.c | 2 +- > > drivers/iio/magnetometer/hmc5843_spi.c | 14 +++++++------- > > 4 files changed, 13 insertions(+), 24 deletions(-) > > > > -- > > 2.37.1 > > > >
From: Jonathan Cameron <Jonathan.Cameron@huawei.com> This driver was taking an unusual approach to handling the optionality of structures / callbacks depending on CONFIG_PM. Bring it inline with other similar drivers. Part of continuing to move IIO over to the new PM macros that don't require such complex handling. Jonathan Cameron (2): iio: magn: hmc5843: Drop excessive indentation of assignments of hmc5843_driver iio: magn: hmc5843: Move struct dev_pm_ops out of header drivers/iio/magnetometer/hmc5843.h | 13 +------------ drivers/iio/magnetometer/hmc5843_core.c | 8 ++++---- drivers/iio/magnetometer/hmc5843_i2c.c | 2 +- drivers/iio/magnetometer/hmc5843_spi.c | 14 +++++++------- 4 files changed, 13 insertions(+), 24 deletions(-)