| Message ID | 20230117190017.3789181-1-marten.lindahl@axis.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | iio: light: vcnl4000: Add vcnl4040 interrupt support | expand |
On Tue, Jan 17, 2023 at 08:00:14PM +0100, Mårten Lindahl wrote: > Hi! > > I have made three patches to add support for proximity sensor > interrupts with the vcnl4040 sensor. > > The first two patches are minor restructuring of the current setup for > interrupts since the probe function hardcodes it for vcnl4010 only. > > The third patch adds support to configure proximity sensor interrupts > and threshold limits for vcnl4040. The series looks good enough to me. Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Kind regards > Mårten Lindahl > > Changes in v5: > - Restore one more unnecessary line change > - Fix indentation > - Build reg value in a clearer way > > Changes in v4: > - Restore unnecessary line changes > - Remove unnecessary typecast > > Changes in v3: > - Only register iio_trigger when there is an irq_thread function > > Changes in v2: > - Make restructure of functions for interrupts and triggered buffer > in separate patch > - Add check for buffer_setup_ops > - Remove irq dependency for devm_iio_triggered_buffer_setup > - Change size of register variable and document it > - Use field definitions for read/write event_config > > Mårten Lindahl (3): > iio: light: vcnl4000: Prepare for more generic setup > iio: light: vcnl4000: Make irq handling more generic > iio: light: vcnl4000: Add interrupt support for vcnl4040 > > drivers/iio/light/vcnl4000.c | 449 ++++++++++++++++++++++++----------- > 1 file changed, 311 insertions(+), 138 deletions(-) > > -- > 2.30.2 >
On Wed, 18 Jan 2023 10:33:04 +0200 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > On Tue, Jan 17, 2023 at 08:00:14PM +0100, Mårten Lindahl wrote: > > Hi! > > > > I have made three patches to add support for proximity sensor > > interrupts with the vcnl4040 sensor. > > > > The first two patches are minor restructuring of the current setup for > > interrupts since the probe function hardcodes it for vcnl4010 only. > > > > The third patch adds support to configure proximity sensor interrupts > > and threshold limits for vcnl4040. > > The series looks good enough to me. > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Applied. Thanks, Jonathan > > > Kind regards > > Mårten Lindahl > > > > Changes in v5: > > - Restore one more unnecessary line change > > - Fix indentation > > - Build reg value in a clearer way > > > > Changes in v4: > > - Restore unnecessary line changes > > - Remove unnecessary typecast > > > > Changes in v3: > > - Only register iio_trigger when there is an irq_thread function > > > > Changes in v2: > > - Make restructure of functions for interrupts and triggered buffer > > in separate patch > > - Add check for buffer_setup_ops > > - Remove irq dependency for devm_iio_triggered_buffer_setup > > - Change size of register variable and document it > > - Use field definitions for read/write event_config > > > > Mårten Lindahl (3): > > iio: light: vcnl4000: Prepare for more generic setup > > iio: light: vcnl4000: Make irq handling more generic > > iio: light: vcnl4000: Add interrupt support for vcnl4040 > > > > drivers/iio/light/vcnl4000.c | 449 ++++++++++++++++++++++++----------- > > 1 file changed, 311 insertions(+), 138 deletions(-) > > > > -- > > 2.30.2 > > >