| Message ID | 20240606-spi-match-data-v1-0-320b291ee1fe@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | iio: simplify with spi_get_device_match_data() | expand |
On Thu, 2024-06-06 at 16:26 +0200, Krzysztof Kozlowski wrote: > Not tested on hardware, but code looks equivalent and should not have > functional effect. > > Best regards, > Krzysztof > > --- > Krzysztof Kozlowski (8): > iio: accel: adxl313: simplify with spi_get_device_match_data() > iio: accel: adxl355: simplify with spi_get_device_match_data() > iio: adc: max11205: simplify with spi_get_device_match_data() > iio: adc: ti-ads131e08: simplify with spi_get_device_match_data() > iio: adc: ti-tsc2046: simplify with spi_get_device_match_data() > iio: addac: ad74413r: simplify with spi_get_device_match_data() > iio: dac: max5522: simplify with spi_get_device_match_data() > iio: adc: mcp3564: drop redundant open-coded spi_get_device_match_data() > > drivers/iio/accel/adxl313_spi.c | 8 +------- > drivers/iio/accel/adxl355_spi.c | 10 +++------- > drivers/iio/adc/max11205.c | 5 +---- > drivers/iio/adc/mcp3564.c | 6 ------ > drivers/iio/adc/ti-ads131e08.c | 4 +--- > drivers/iio/adc/ti-tsc2046.c | 7 +------ > drivers/iio/addac/ad74413r.c | 13 +++---------- > drivers/iio/dac/max5522.c | 11 +++-------- > 8 files changed, 13 insertions(+), 51 deletions(-) > --- LGTM, just some minor comments/asks that don't really stop me from: Reviewed-by: Nuno Sa <nuno.sa@analog.com>
On Fri, 07 Jun 2024 10:55:44 +0200 Nuno Sá <noname.nuno@gmail.com> wrote: > On Thu, 2024-06-06 at 16:26 +0200, Krzysztof Kozlowski wrote: > > Not tested on hardware, but code looks equivalent and should not have > > functional effect. > > > > Best regards, > > Krzysztof > > > > --- > > Krzysztof Kozlowski (8): > > iio: accel: adxl313: simplify with spi_get_device_match_data() > > iio: accel: adxl355: simplify with spi_get_device_match_data() > > iio: adc: max11205: simplify with spi_get_device_match_data() > > iio: adc: ti-ads131e08: simplify with spi_get_device_match_data() > > iio: adc: ti-tsc2046: simplify with spi_get_device_match_data() > > iio: addac: ad74413r: simplify with spi_get_device_match_data() > > iio: dac: max5522: simplify with spi_get_device_match_data() > > iio: adc: mcp3564: drop redundant open-coded spi_get_device_match_data() > > > > drivers/iio/accel/adxl313_spi.c | 8 +------- > > drivers/iio/accel/adxl355_spi.c | 10 +++------- > > drivers/iio/adc/max11205.c | 5 +---- > > drivers/iio/adc/mcp3564.c | 6 ------ > > drivers/iio/adc/ti-ads131e08.c | 4 +--- > > drivers/iio/adc/ti-tsc2046.c | 7 +------ > > drivers/iio/addac/ad74413r.c | 13 +++---------- > > drivers/iio/dac/max5522.c | 11 +++-------- > > 8 files changed, 13 insertions(+), 51 deletions(-) > > --- > > LGTM, just some minor comments/asks that don't really stop me from: > > Reviewed-by: Nuno Sa <nuno.sa@analog.com> > > Applied. Thanks for tidying these up. Jonathan
Not tested on hardware, but code looks equivalent and should not have functional effect. Best regards, Krzysztof --- Krzysztof Kozlowski (8): iio: accel: adxl313: simplify with spi_get_device_match_data() iio: accel: adxl355: simplify with spi_get_device_match_data() iio: adc: max11205: simplify with spi_get_device_match_data() iio: adc: ti-ads131e08: simplify with spi_get_device_match_data() iio: adc: ti-tsc2046: simplify with spi_get_device_match_data() iio: addac: ad74413r: simplify with spi_get_device_match_data() iio: dac: max5522: simplify with spi_get_device_match_data() iio: adc: mcp3564: drop redundant open-coded spi_get_device_match_data() drivers/iio/accel/adxl313_spi.c | 8 +------- drivers/iio/accel/adxl355_spi.c | 10 +++------- drivers/iio/adc/max11205.c | 5 +---- drivers/iio/adc/mcp3564.c | 6 ------ drivers/iio/adc/ti-ads131e08.c | 4 +--- drivers/iio/adc/ti-tsc2046.c | 7 +------ drivers/iio/addac/ad74413r.c | 13 +++---------- drivers/iio/dac/max5522.c | 11 +++-------- 8 files changed, 13 insertions(+), 51 deletions(-) --- base-commit: ed3dab9323648a17a85908c574787be12d4cc871 change-id: 20240606-spi-match-data-6bf7c51ba913 Best regards,