| Message ID | 20240628171726.124852-1-vassilisamir@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | iio: pressure: bmp280: Minor cleanup and triggered | expand |
On Fri, 28 Jun 2024 19:17:23 +0200 Vasileios Amoiridis <vassilisamir@gmail.com> wrote: > Changes in v9: > > Patch 1/3: > - In bmp580_temp_coeffs, instead of *1000/2^16, now we have *125/2^13 > to avoid overflows, as it was proposed. > - Type casting to (s64) to temperature read in the read_raw_impl > function was removed as well as it is no longer needed. > > Patch 3/3: > - Renamed "buffer_handler" to "trigger_handler" to keep consistency > with the rest of the drivers. > - Added new iio_channel_spec for bmp580 in order to use IIO_LE and > real_bits = 24. > > v8: https://lore.kernel.org/linux-iio/20240617230540.32325-1-vassilisamir@gmail.com/ This seems fine to me now, but I'd like a final 'we didn't break anything' from Adam before i pick it up. Once bitten, twice shy and all that ;) J > > Vasileios Amoiridis (3): > iio: pressure: bmp280: Generalize read_*() functions > iio: pressure: bmp280: Add SCALE, RAW values in channels and > refactorize them > iio: pressure: bmp280: Add triggered buffer support > > drivers/iio/pressure/Kconfig | 2 + > drivers/iio/pressure/bmp280-core.c | 643 +++++++++++++++++++++++++---- > drivers/iio/pressure/bmp280-spi.c | 8 +- > drivers/iio/pressure/bmp280.h | 34 +- > 4 files changed, 589 insertions(+), 98 deletions(-) > > > base-commit: 3341d69268accb5294b569ec37e55212a8a28ac5
On Sun, Jun 30, 2024 at 11:23:42AM +0100, Jonathan Cameron wrote: > On Fri, 28 Jun 2024 19:17:23 +0200 > Vasileios Amoiridis <vassilisamir@gmail.com> wrote: > > > Changes in v9: > > > > Patch 1/3: > > - In bmp580_temp_coeffs, instead of *1000/2^16, now we have *125/2^13 > > to avoid overflows, as it was proposed. > > - Type casting to (s64) to temperature read in the read_raw_impl > > function was removed as well as it is no longer needed. > > > > Patch 3/3: > > - Renamed "buffer_handler" to "trigger_handler" to keep consistency > > with the rest of the drivers. > > - Added new iio_channel_spec for bmp580 in order to use IIO_LE and > > real_bits = 24. > > > > v8: https://lore.kernel.org/linux-iio/20240617230540.32325-1-vassilisamir@gmail.com/ > > This seems fine to me now, but I'd like a final 'we didn't break anything' from > Adam before i pick it up. Once bitten, twice shy and all that ;) > > J > Hi Jonathan, Perfect! Let's see what Adam has to say as well. Thanks for the very helpful reviews :) Cheers, Vasilis > > > > > Vasileios Amoiridis (3): > > iio: pressure: bmp280: Generalize read_*() functions > > iio: pressure: bmp280: Add SCALE, RAW values in channels and > > refactorize them > > iio: pressure: bmp280: Add triggered buffer support > > > > drivers/iio/pressure/Kconfig | 2 + > > drivers/iio/pressure/bmp280-core.c | 643 +++++++++++++++++++++++++---- > > drivers/iio/pressure/bmp280-spi.c | 8 +- > > drivers/iio/pressure/bmp280.h | 34 +- > > 4 files changed, 589 insertions(+), 98 deletions(-) > > > > > > base-commit: 3341d69268accb5294b569ec37e55212a8a28ac5 >
Changes in v9: Patch 1/3: - In bmp580_temp_coeffs, instead of *1000/2^16, now we have *125/2^13 to avoid overflows, as it was proposed. - Type casting to (s64) to temperature read in the read_raw_impl function was removed as well as it is no longer needed. Patch 3/3: - Renamed "buffer_handler" to "trigger_handler" to keep consistency with the rest of the drivers. - Added new iio_channel_spec for bmp580 in order to use IIO_LE and real_bits = 24. v8: https://lore.kernel.org/linux-iio/20240617230540.32325-1-vassilisamir@gmail.com/ Vasileios Amoiridis (3): iio: pressure: bmp280: Generalize read_*() functions iio: pressure: bmp280: Add SCALE, RAW values in channels and refactorize them iio: pressure: bmp280: Add triggered buffer support drivers/iio/pressure/Kconfig | 2 + drivers/iio/pressure/bmp280-core.c | 643 +++++++++++++++++++++++++---- drivers/iio/pressure/bmp280-spi.c | 8 +- drivers/iio/pressure/bmp280.h | 34 +- 4 files changed, 589 insertions(+), 98 deletions(-) base-commit: 3341d69268accb5294b569ec37e55212a8a28ac5