From patchwork Thu Jul 11 11:42:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kim Seer Paller X-Patchwork-Id: 13730599 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70E6D155A5D; Thu, 11 Jul 2024 11:43:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720698195; cv=none; b=gRl/u6vFuDCosbB3LBMKlJJapEA2lxzIKC7o5/3YlVIMTobkC1vP/VT6lXHtgG//GjAo9eqkaoQhYOuTY0zTjF23XczDxRjrA4ODhUtPtqIr9x8dM5wWk5q+HcYsfanPSGhzbp9g31wN56tfnbEFyI4PXlvfhu9OC8JLkqNsejc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720698195; c=relaxed/simple; bh=dLhmt98GOBebEwaTJw3sfY5WZZ8/HHQU5dyPw4s1QPQ=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=Q/dEQAMym7lXdhm5xrCdWFh4RgpjeN0p3h0bVGC42HUNGYoiIkmZCZSDlv9Vu71fv1aLLGYqSVGXvTCSLHSZfMX/SOPfXLOxwo2JdujYLjFJ0tPBS4+b1xFHaZ2jE2Fnz1dKJeIyjpOX/HNDdEWCxCxED59RIcNaxGPPSUv40vc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=1qH88vIF; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="1qH88vIF" Received: from pps.filterd (m0167089.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 46B8d78j011012; Thu, 11 Jul 2024 07:42:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h=cc :content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=DKIM; bh=+Z4kn8G9VHUBIv2CowSJGLGHGz5 AUBn7iiK1TB1WtYM=; b=1qH88vIFyWhRlKWNVam4lLmwYMpp8mGxiROUpDCUwkj Xy7mR2n2+1M8lE8P7j7cE+ZbCdDXy1cZW+RPwlUZPhN8fHuuQP6RIprfJEJ+tuxm dpXIpSmdqYgTxoPvRCjwS6/2NIX/zpTrx7WNRitDcqyHLcNKkNT4KOYT4bmEW11Z G8gq2BnwsnrAatDuKtc0qHFQepVF2o9NP78S/eL+WwUMFFnHaL764oe0mlyt0bDo aRQPiZNpgDa9zgJfXVD2uLXi6L1CywwUqasO4A0xSnkn+PAZkMQF0b3it47woHim XM1zuPDHHQ9ra1SUXw2IwknZKrgl2jiEIa+KiOTtgDQ== Received: from nwd2mta3.analog.com ([137.71.173.56]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 408fy4vpvh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 11 Jul 2024 07:42:46 -0400 (EDT) Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta3.analog.com (8.14.7/8.14.7) with ESMTP id 46BBgji8022822 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 11 Jul 2024 07:42:45 -0400 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.14; Thu, 11 Jul 2024 07:42:44 -0400 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.986.14 via Frontend Transport; Thu, 11 Jul 2024 07:42:44 -0400 Received: from kim-VirtualBox.ad.analog.com (KPALLER2-L03.ad.analog.com [10.117.220.23]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 46BBgTQZ013318; Thu, 11 Jul 2024 07:42:32 -0400 From: Kim Seer Paller To: , , CC: Jonathan Cameron , David Lechner , Lars-Peter Clausen , Liam Girdwood , Mark Brown , Dimitri Fedrau , Krzysztof Kozlowski , Rob Herring , Conor Dooley , Michael Hennerich , =?utf-8?q?Nuno_S=C3=A1?= , Kim Seer Paller Subject: [PATCH v6 0/6] Add driver for LTC2664 and LTC2672 Date: Thu, 11 Jul 2024 19:42:15 +0800 Message-ID: <20240711114221.62386-1-kimseer.paller@analog.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-GUID: ZCg1BX8gaR5MtzUP4dhYYH-FwvURlVBa X-Proofpoint-ORIG-GUID: ZCg1BX8gaR5MtzUP4dhYYH-FwvURlVBa X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-11_06,2024-07-11_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 mlxlogscore=999 lowpriorityscore=0 spamscore=0 impostorscore=0 bulkscore=0 mlxscore=0 adultscore=0 priorityscore=1501 clxscore=1015 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2406140001 definitions=main-2407110083 Generalize the ABI documentation for DAC. The ABI defined for toggle mode channels: LTC2664: * out_voltageY_toggle_en * out_voltageY_raw0 * out_voltageY_raw1 * out_voltageY_symbol LTC2672: * out_currentY_toggle_en * out_currentY_raw0 * out_currentY_raw1 * out_currentY_symbol Default channels won't have any of the above ABIs. A channel is toggle capable if the devicetree 'adi,toggle-mode' flag is set. changes in v6: Bindings: * Added clarification description for output-range-microvolt property and modified conditional logic for output-range-microvolt for ltc2664 binding. * Simplified schema validation logic for DAC binding. * Added Reviewed-by tag for ltc2672 binding. changes in v5: ltc2664: * Removed return statement for error code in ltc2664_dac_code_read making it a void function. * Refactored voltage regulator error handling and logic setting for vref_mv. * Added Reviewed-by tag. Bindings: * Added dac.yaml and generalized DAC common properties. * Modified ltc2664 binding adding constraints for the adi,manual-span-operation-config and output-range-microvolt properties. changes in v4: ltc2664: * Added comments for each field in the ltc2664_chan struct. * Changed global_toggle data type to bool and updated vref and rfsadj variables to include units. * Added 0,0 entry in ltc2672_span_helper to removed the id field from the ltc2664_chip_info struct. * Used mul_u64_u32_div helper function from linux/math64.h to avoid integer overflow during scale calculation. * Refactored code to use a single template for channel instead of separate channel arrays. * Used the devm_regulator_get_enable_read_voltage API for simplifying voltage retrieval. ABI: sysfs-bus-iio: * Added commit message for the ABI changes. sysfs-bus-iio-dac: * Updated the description of toggle_en to clarify autonomous toggling. * Fixed inconsistent use of spacing and tabs. Bindings: * Dropped Reviewed-by tag. * Updated the description for both bindings to include both 12-bit and 16-bit versions. changes in v3: ltc2664: * Added span sanity check for no match. * Initialized the variable 'span' to fix build warning. * Added Reported-by and Closes by tag. ABI: * Modified descriptions to make it more generalize. * Removed MAINTAINERS file entry. Bindings: * Changed clr-gpios to reset-gpios. * Added output range and reset code description for 'adi,manual-span-operation-config' property in ltc2664 binding. * Removed the $ref for 'adi,output-range-microamp' due to dt-schema warning in ltc2672 binding. Added Reported-by and Closes by tag. * Modified io-channels description and added maxItems constraint. changes in v2: ltc2664: * Updated struct ltc2664_chip_info to include device-specific data for scale, offset, measurement type, internal vref, manual span support, and rfsadj support. * Added a read-only extended info attribute powerdown_mode to indicate the state that the DAC output enters when the device is powered down. * Refactored code for setting the span into separate function and directly returning the span. * Adjusted memory allocation for st->iio_channels to include null terminator. * Spaces have been added after { and before }. Each pair of values is now placed on a separate line. ABI: * Generalized the ABI documentation for DAC. * Added DAC 42kohm_to_gnd powerdown mode. Bindings: * Created separate bindings for ltc2664 and ltc2672. * Added v-pos-supply and v-neg-supply regulator properties. * Renamed vref-supply to ref-supply based on the datasheet. * Added io-channels property and specifying the pin for multiplexer output. * Added vdd0-vdd4 supply properties for ltc2672, although they are not currently supported in the driver. * Changed clr-gpios description based on the datasheet. * Used 4 spaces for example indentation. Kim Seer Paller (6): iio: ABI: Generalize ABI documentation for DAC iio: ABI: add DAC 42kohm_to_gnd powerdown mode dt-bindings: iio: dac: Generalize DAC common properties dt-bindings: iio: dac: Add adi,ltc2664.yaml dt-bindings: iio: dac: Add adi,ltc2672.yaml iio: dac: ltc2664: Add driver for LTC2664 and LTC2672 Documentation/ABI/testing/sysfs-bus-iio | 1 + Documentation/ABI/testing/sysfs-bus-iio-dac | 61 ++ .../ABI/testing/sysfs-bus-iio-dac-ltc2688 | 31 - .../bindings/iio/dac/adi,ltc2664.yaml | 181 +++++ .../bindings/iio/dac/adi,ltc2672.yaml | 160 ++++ .../devicetree/bindings/iio/dac/dac.yaml | 50 ++ MAINTAINERS | 10 + drivers/iio/dac/Kconfig | 11 + drivers/iio/dac/Makefile | 1 + drivers/iio/dac/ltc2664.c | 735 ++++++++++++++++++ 10 files changed, 1210 insertions(+), 31 deletions(-) create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-dac create mode 100644 Documentation/devicetree/bindings/iio/dac/adi,ltc2664.yaml create mode 100644 Documentation/devicetree/bindings/iio/dac/adi,ltc2672.yaml create mode 100644 Documentation/devicetree/bindings/iio/dac/dac.yaml create mode 100644 drivers/iio/dac/ltc2664.c base-commit: 1ebab783647a9e3bf357002d5c4ff060c8474a0a