[v3,0/2] *** Add ADF4378 Support ***

Message

Antoniu Miclaus July 29, 2024, 9:50 a.m. UTC

Add support for ADF4378 high performance, ultra-low jitter, integer-N
phased locked loop (PLL) with an integrated voltage controlled
oscillator (VCO) and system reference (SYSREF) retimer ideally
suited for data converter and mixed signal front end (MxFE) clock
applications.

The main difference between ADF4377 and ADF4378 is that the second one
provides only one output frequency channel which is enable/disabled via
one GPIO. 

Both the driver and the bindings are updated to reflect that difference.

Antoniu Miclaus (2):
  dt-bindings: iio: adf4377: add adf4378 support
  iio: frequency: adf4377: add adf4378 support

 .../bindings/iio/frequency/adi,adf4377.yaml   | 10 ++++++
 drivers/iio/frequency/adf4377.c               | 35 +++++++++++++++----
 2 files changed, 38 insertions(+), 7 deletions(-)

Comments

Krzysztof Kozlowski July 29, 2024, 2:58 p.m. UTC | #1

On 29/07/2024 11:50, Antoniu Miclaus wrote:
> Add support for ADF4378 high performance, ultra-low jitter, integer-N
> phased locked loop (PLL) with an integrated voltage controlled
> oscillator (VCO) and system reference (SYSREF) retimer ideally
> suited for data converter and mixed signal front end (MxFE) clock
> applications.
> 
> The main difference between ADF4377 and ADF4378 is that the second one
> provides only one output frequency channel which is enable/disabled via
> one GPIO. 
> 
> Both the driver and the bindings are updated to reflect that difference.

That's a v3, but where is the changelog?

Best regards,
Krzysztof

Antoniu Miclaus July 30, 2024, 8:23 a.m. UTC | #2

> -----Original Message-----
> From: Krzysztof Kozlowski <[e-mail]>
> Sent: Monday, July 29, 2024 5:58 PM
> To: Miclaus, Antoniu <[e-mail]>; Lars-Peter Clausen
> <[e-mail]>; Hennerich, Michael <[e-mail]>;
> Jonathan Cameron <[e-mail]>; Rob Herring <[e-mail]>;
> Krzysztof Kozlowski <[e-mail]>; Conor Dooley
> <[e-mail]>; Bogdan, Dragos <[e-mail]>;
> [e-mail]; [e-mail]; linux-
> [e-mail]
> Subject: Re: [PATCH v3 0/2] *** Add ADF4378 Support ***
> 
> [External]
> 
> On 29/07/2024 11:50, Antoniu Miclaus wrote:
> > Add support for ADF4378 high performance, ultra-low jitter, integer-N
> > phased locked loop (PLL) with an integrated voltage controlled
> > oscillator (VCO) and system reference (SYSREF) retimer ideally
> > suited for data converter and mixed signal front end (MxFE) clock
> > applications.
> >
> > The main difference between ADF4377 and ADF4378 is that the second one
> > provides only one output frequency channel which is enable/disabled via
> > one GPIO.
> >
> > Both the driver and the bindings are updated to reflect that difference.
> 
> That's a v3, but where is the changelog?

Each of the two patches has their own changelog.
For the cover letter there's no changelog since it was added with v3. 

Regards,
Antoniu
> 
> Best regards,
> Krzysztof

Krzysztof Kozlowski July 30, 2024, 8:42 a.m. UTC | #3

On 30/07/2024 10:23, Miclaus, Antoniu wrote:
>> -----Original Message-----
>> From: Krzysztof Kozlowski <[e-mail]>
>> Sent: Monday, July 29, 2024 5:58 PM
>> To: Miclaus, Antoniu <[e-mail]>; Lars-Peter Clausen
>> <[e-mail]>; Hennerich, Michael <[e-mail]>;
>> Jonathan Cameron <[e-mail]>; Rob Herring <[e-mail]>;
>> Krzysztof Kozlowski <[e-mail]>; Conor Dooley
>> <[e-mail]>; Bogdan, Dragos <[e-mail]>;
>> [e-mail]; [e-mail]; linux-
>> [e-mail]
>> Subject: Re: [PATCH v3 0/2] *** Add ADF4378 Support ***
>>
>> [External]
>>
>> On 29/07/2024 11:50, Antoniu Miclaus wrote:
>>> Add support for ADF4378 high performance, ultra-low jitter, integer-N
>>> phased locked loop (PLL) with an integrated voltage controlled
>>> oscillator (VCO) and system reference (SYSREF) retimer ideally
>>> suited for data converter and mixed signal front end (MxFE) clock
>>> applications.
>>>
>>> The main difference between ADF4377 and ADF4378 is that the second one
>>> provides only one output frequency channel which is enable/disabled via
>>> one GPIO.
>>>
>>> Both the driver and the bindings are updated to reflect that difference.
>>
>> That's a v3, but where is the changelog?
> 
> Each of the two patches has their own changelog.
> For the cover letter there's no changelog since it was added with v3. 

Ah, ok, it was not that easy to find, without any spacing from the diffstat.

Best regards,
Krzysztof

Jonathan Cameron July 30, 2024, 6:19 p.m. UTC | #4

On Tue, 30 Jul 2024 10:42:51 +0200
Krzysztof Kozlowski <[e-mail]> wrote:

> On 30/07/2024 10:23, Miclaus, Antoniu wrote:
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <[e-mail]>
> >> Sent: Monday, July 29, 2024 5:58 PM
> >> To: Miclaus, Antoniu <[e-mail]>; Lars-Peter Clausen
> >> <[e-mail]>; Hennerich, Michael <[e-mail]>;
> >> Jonathan Cameron <[e-mail]>; Rob Herring <[e-mail]>;
> >> Krzysztof Kozlowski <[e-mail]>; Conor Dooley
> >> <[e-mail]>; Bogdan, Dragos <[e-mail]>;
> >> [e-mail]; [e-mail]; linux-
> >> [e-mail]
> >> Subject: Re: [PATCH v3 0/2] *** Add ADF4378 Support ***
> >>
> >> [External]
> >>
> >> On 29/07/2024 11:50, Antoniu Miclaus wrote:  
> >>> Add support for ADF4378 high performance, ultra-low jitter, integer-N
> >>> phased locked loop (PLL) with an integrated voltage controlled
> >>> oscillator (VCO) and system reference (SYSREF) retimer ideally
> >>> suited for data converter and mixed signal front end (MxFE) clock
> >>> applications.
> >>>
> >>> The main difference between ADF4377 and ADF4378 is that the second one
> >>> provides only one output frequency channel which is enable/disabled via
> >>> one GPIO.
> >>>
> >>> Both the driver and the bindings are updated to reflect that difference.  
> >>
> >> That's a v3, but where is the changelog?  
> > 
> > Each of the two patches has their own changelog.
> > For the cover letter there's no changelog since it was added with v3.   
> 
> Ah, ok, it was not that easy to find, without any spacing from the diffstat.
> 
> Best regards,
> Krzysztof
> 
Applied to the togreg branch of iio.git and pushed out as testing initially
for 0-day to take a first look at it.

Thanks,

Jonathan