[v3,0/3] Add support for AD4113

Message

Dumitru Ceclan via B4 Relay Aug. 12, 2024, 8:13 a.m. UTC

This patch series adds support for the AD4113 ADC within the existing
AD7173 driver.

The AD4113 is a low power, low noise, 16-bit, Σ-Δ analog-to-digital
converter (ADC) that integrates an analog front end (AFE) for four
fully differential or eight single-ended inputs.

The part is not released yet and the documentation is not public.
Register map is identical to AD4114 besides the lower width data
register and the GPIO register.

Particularities of this model:
- 16 bit data register
- no temperature sensor
- no current inputs
- input buffers
- internal reference
- external reference REF-/REF+
- no second external reference REF2-/REF2+
- no AVDD2 supply
- 2 GPIO pins with config bits starting at a higher position in register
- 8 VINx inputs with voltage divider
- 16 channel registers and 8 setup registers

Signed-off-by: Dumitru Ceclan <[e-mail]>
---
Changes in v3:
- lowercase chip ID
- add patch to correctly order chip IDs defines
- picked up RB and ACK tags
- Link to v2: https://lore.kernel.org/r/[e-mail]

Changes in v2:
- correctly set realbits and storagebits to 16 in iio_chan_spec
- describe bindings restrictions in commit message due to lack of
  sufficient diff context
- describe model differences better in cover letter
- Link to v1: https://lore.kernel.org/r/[e-mail]

---
Dumitru Ceclan (3):
      dt-bindings: adc: ad7173: add support for ad4113
      iio: adc: ad7173: order chipID by value
      iio: adc: ad7173: add support for ad4113

 .../devicetree/bindings/iio/adc/adi,ad7173.yaml    |  3 ++
 drivers/iio/adc/ad7173.c                           | 38 ++++++++++++++++++++--
 2 files changed, 39 insertions(+), 2 deletions(-)
---
base-commit: 1c61e13d7dc9003662bd7fd6064dfea67e64b014
change-id: 20240725-ad4113-baa63ff99245

Best regards,

Comments

Jonathan Cameron Aug. 17, 2024, 10:19 a.m. UTC | #1

On Mon, 12 Aug 2024 11:13:13 +0300
Dumitru Ceclan via B4 Relay <[e-mail]> wrote:

> This patch series adds support for the AD4113 ADC within the existing
> AD7173 driver.
> 
> The AD4113 is a low power, low noise, 16-bit, Σ-Δ analog-to-digital
> converter (ADC) that integrates an analog front end (AFE) for four
> fully differential or eight single-ended inputs.
> 
> The part is not released yet and the documentation is not public.
> Register map is identical to AD4114 besides the lower width data
> register and the GPIO register.
> 
> Particularities of this model:
> - 16 bit data register
> - no temperature sensor
> - no current inputs
> - input buffers
> - internal reference
> - external reference REF-/REF+
> - no second external reference REF2-/REF2+
> - no AVDD2 supply
> - 2 GPIO pins with config bits starting at a higher position in register
> - 8 VINx inputs with voltage divider
> - 16 channel registers and 8 setup registers
> 
> Signed-off-by: Dumitru Ceclan <[e-mail]>
Hi.

Series is fine, but I don't yet have the fix 
[PATCH] iio: adc: ad7173: Fix incorrect compatible string
in the upstream of my togreg branch.

Hence this will have to wait a little while for that to be present.
Otherwise this will create a fiddly merge for linux-next etc.

Jonathan

> ---
> Changes in v3:
> - lowercase chip ID
> - add patch to correctly order chip IDs defines
> - picked up RB and ACK tags
> - Link to v2: https://lore.kernel.org/r/[e-mail]
> 
> Changes in v2:
> - correctly set realbits and storagebits to 16 in iio_chan_spec
> - describe bindings restrictions in commit message due to lack of
>   sufficient diff context
> - describe model differences better in cover letter
> - Link to v1: https://lore.kernel.org/r/[e-mail]
> 
> ---
> Dumitru Ceclan (3):
>       dt-bindings: adc: ad7173: add support for ad4113
>       iio: adc: ad7173: order chipID by value
>       iio: adc: ad7173: add support for ad4113
> 
>  .../devicetree/bindings/iio/adc/adi,ad7173.yaml    |  3 ++
>  drivers/iio/adc/ad7173.c                           | 38 ++++++++++++++++++++--
>  2 files changed, 39 insertions(+), 2 deletions(-)
> ---
> base-commit: 1c61e13d7dc9003662bd7fd6064dfea67e64b014
> change-id: 20240725-ad4113-baa63ff99245
> 
> Best regards,

Jonathan Cameron Sept. 8, 2024, 10:41 a.m. UTC | #2

On Sat, 17 Aug 2024 11:19:02 +0100
Jonathan Cameron <[e-mail]> wrote:

> On Mon, 12 Aug 2024 11:13:13 +0300
> Dumitru Ceclan via B4 Relay <[e-mail]> wrote:
> 
> > This patch series adds support for the AD4113 ADC within the existing
> > AD7173 driver.
> > 
> > The AD4113 is a low power, low noise, 16-bit, Σ-Δ analog-to-digital
> > converter (ADC) that integrates an analog front end (AFE) for four
> > fully differential or eight single-ended inputs.
> > 
> > The part is not released yet and the documentation is not public.
> > Register map is identical to AD4114 besides the lower width data
> > register and the GPIO register.
> > 
> > Particularities of this model:
> > - 16 bit data register
> > - no temperature sensor
> > - no current inputs
> > - input buffers
> > - internal reference
> > - external reference REF-/REF+
> > - no second external reference REF2-/REF2+
> > - no AVDD2 supply
> > - 2 GPIO pins with config bits starting at a higher position in register
> > - 8 VINx inputs with voltage divider
> > - 16 channel registers and 8 setup registers
> > 
> > Signed-off-by: Dumitru Ceclan <[e-mail]>  
> Hi.
> 
> Series is fine, but I don't yet have the fix 
> [PATCH] iio: adc: ad7173: Fix incorrect compatible string
> in the upstream of my togreg branch.
> 
> Hence this will have to wait a little while for that to be present.
> Otherwise this will create a fiddly merge for linux-next etc.

Tree juggling didn't go entirely according to plan so unfortunately
this has slipped back to next cycle unless there is a delay in the
6.12 merge window opening.

Sorry about that, and I'll make sure to queued it up nice and early
after rc1.

> 
> Jonathan
> 
> > ---
> > Changes in v3:
> > - lowercase chip ID
> > - add patch to correctly order chip IDs defines
> > - picked up RB and ACK tags
> > - Link to v2: https://lore.kernel.org/r/[e-mail]
> > 
> > Changes in v2:
> > - correctly set realbits and storagebits to 16 in iio_chan_spec
> > - describe bindings restrictions in commit message due to lack of
> >   sufficient diff context
> > - describe model differences better in cover letter
> > - Link to v1: https://lore.kernel.org/r/[e-mail]
> > 
> > ---
> > Dumitru Ceclan (3):
> >       dt-bindings: adc: ad7173: add support for ad4113
> >       iio: adc: ad7173: order chipID by value
> >       iio: adc: ad7173: add support for ad4113
> > 
> >  .../devicetree/bindings/iio/adc/adi,ad7173.yaml    |  3 ++
> >  drivers/iio/adc/ad7173.c                           | 38 ++++++++++++++++++++--
> >  2 files changed, 39 insertions(+), 2 deletions(-)
> > ---
> > base-commit: 1c61e13d7dc9003662bd7fd6064dfea67e64b014
> > change-id: 20240725-ad4113-baa63ff99245
> > 
> > Best regards,  
> 
>

Jonathan Cameron Sept. 9, 2024, 7:44 a.m. UTC | #3

On Sun, 8 Sep 2024 11:41:43 +0100
Jonathan Cameron <[e-mail]> wrote:

> On Sat, 17 Aug 2024 11:19:02 +0100
> Jonathan Cameron <[e-mail]> wrote:
> 
> > On Mon, 12 Aug 2024 11:13:13 +0300
> > Dumitru Ceclan via B4 Relay <[e-mail]> wrote:
> >   
> > > This patch series adds support for the AD4113 ADC within the existing
> > > AD7173 driver.
> > > 
> > > The AD4113 is a low power, low noise, 16-bit, Σ-Δ analog-to-digital
> > > converter (ADC) that integrates an analog front end (AFE) for four
> > > fully differential or eight single-ended inputs.
> > > 
> > > The part is not released yet and the documentation is not public.
> > > Register map is identical to AD4114 besides the lower width data
> > > register and the GPIO register.
> > > 
> > > Particularities of this model:
> > > - 16 bit data register
> > > - no temperature sensor
> > > - no current inputs
> > > - input buffers
> > > - internal reference
> > > - external reference REF-/REF+
> > > - no second external reference REF2-/REF2+
> > > - no AVDD2 supply
> > > - 2 GPIO pins with config bits starting at a higher position in register
> > > - 8 VINx inputs with voltage divider
> > > - 16 channel registers and 8 setup registers
> > > 
> > > Signed-off-by: Dumitru Ceclan <[e-mail]>    
> > Hi.
> > 
> > Series is fine, but I don't yet have the fix 
> > [PATCH] iio: adc: ad7173: Fix incorrect compatible string
> > in the upstream of my togreg branch.
> > 
> > Hence this will have to wait a little while for that to be present.
> > Otherwise this will create a fiddly merge for linux-next etc.  
> 
> Tree juggling didn't go entirely according to plan so unfortunately
> this has slipped back to next cycle unless there is a delay in the
> 6.12 merge window opening.
> 
> Sorry about that, and I'll make sure to queued it up nice and early
> after rc1.
Applied now.  Given Linus wasn't super clear on whether he plans to
do an rc8 I might still send a speculative pull request in case
there is a delay.  If so I'll do that in a few days after this
as first sat in my testing branch for 0-day to look then togreg
branch hence Linux-next for a day or two after that.

Jonathan

> 
> > 
> > Jonathan
> >   
> > > ---
> > > Changes in v3:
> > > - lowercase chip ID
> > > - add patch to correctly order chip IDs defines
> > > - picked up RB and ACK tags
> > > - Link to v2: https://lore.kernel.org/r/[e-mail]
> > > 
> > > Changes in v2:
> > > - correctly set realbits and storagebits to 16 in iio_chan_spec
> > > - describe bindings restrictions in commit message due to lack of
> > >   sufficient diff context
> > > - describe model differences better in cover letter
> > > - Link to v1: https://lore.kernel.org/r/[e-mail]
> > > 
> > > ---
> > > Dumitru Ceclan (3):
> > >       dt-bindings: adc: ad7173: add support for ad4113
> > >       iio: adc: ad7173: order chipID by value
> > >       iio: adc: ad7173: add support for ad4113
> > > 
> > >  .../devicetree/bindings/iio/adc/adi,ad7173.yaml    |  3 ++
> > >  drivers/iio/adc/ad7173.c                           | 38 ++++++++++++++++++++--
> > >  2 files changed, 39 insertions(+), 2 deletions(-)
> > > ---
> > > base-commit: 1c61e13d7dc9003662bd7fd6064dfea67e64b014
> > > change-id: 20240725-ad4113-baa63ff99245
> > > 
> > > Best regards,    
> > 
> >   
> 
>