From patchwork Mon Sep 2 10:36:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alexandru Ardelean X-Patchwork-Id: 13787013 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9100613D529 for ; Mon, 2 Sep 2024 10:36:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725273417; cv=none; b=QzKidLOSaWudkxYo3vidFEf0VpYU1Wgh2Evht9+ITgWydMiuM0akHoloFprdPiVUyuoOLaAlECkQg8kLCU2bjbd70LVimCri04cRkSQqemeaQCGwKE1jw3sJjXsvMuFYbInCKr+gJiNPxY7pG12ixm2SBpm1Rt9BwnYMTYTnNdU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725273417; c=relaxed/simple; bh=w4hUKFZRVwTkgdYnXbKcFni55fd49hUz3PeIDGWYnIY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=Q5xl/BWuk/JQijYhW1O5VaonWaIUlHUREY9lemq3g/jYCy2owJY1FvMQPIMWqLtDToAxQkCt3X/XiIhpxUlzPQJcACranMNIUo0Ln4/jtCM1sZug8C2LjYPCeaNtv+b3kHffCcAm1quuw7VgfZ2PW9ZTerS3DfbWx0LSf+Ac/Y8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=zkQc7j1f; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="zkQc7j1f" Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-5343e75c642so5288299e87.2 for ; Mon, 02 Sep 2024 03:36:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1725273412; x=1725878212; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pdQfS/StVpF9F5Bh2sPOMyAZPOYpAT6UkHQK3E3HfLE=; b=zkQc7j1f9EFZ3MDUuMzs7vH5MNX5dwpVTG/9u6pkdeqAChIAGfzG6CDV1f2HFnZYB/ luXKy4/otsc5rOxTZtBb0nuvXT7FCzAm40fSAP4uZTQONkclQgY9dgIyOjKi0kXWbiPb QF5aUZMLmQZnTF8RtWOPBiXMtLL4YApADAU9eWKbM9yzU5SCCsZv9VbJ4ABk/3RxBO69 SWVWhYn9vjx6sNPMdHn6gMi61p3tBrfdo0N3MgNHZhehjCVdpGZ/67Nv9cKH1zuCKak/ taLpEmiQ7EUrck5QbW/LzkPMM9ToUDNAbt4e791CciFJ4RzRIbmhqhKMgWn7BtP7YOY5 HV9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725273412; x=1725878212; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pdQfS/StVpF9F5Bh2sPOMyAZPOYpAT6UkHQK3E3HfLE=; b=I1ps8JqhGdDaPHqAbdx+XuqBJu28bEtivtN+RC1yxS9KFNCnBxKfz4S216ogmoScGA 8QKfccKMvGgOJKZ5BaGfQ2umVru+cYg11gh8AHf/Pfvzt9lad2Ux0M8LbX8lEMsNxsce esr4oHnpafcD3ASgI1wE58nutgggXQdYNspexgDe6NjlEI4xe65sGVGHy/rb+IQngXs8 MdDXpDlPXW8n7N7sdHjjK7TipAyGlFuh+LfvQovvePo91EtBvZssxAaD8XMzAeW6pou/ PxkHS+lulc8tW/XifZ6ntX0c8HjxZ1MnowKSVgEs4qtyZ3V6Rzu3jrnDJxpblXZEpZjG QqcQ== X-Gm-Message-State: AOJu0Yzlw9MrzVmh3K4SxluapbYfPcBM89/m/zC1UNh9u7ekhgrfbjyu hkXZMTBDXZdxar9sQME3q9hodaOah7Cqwi+0AMXBK6mXB8e0e7os5nXlwAskJ/r16QhsYOSjtvl u9eI= X-Google-Smtp-Source: AGHT+IGtAjoMGEyaiXNrUjDCZSs3tMw20444MMwWP9faqnEiQBTFdwEyYqTFnRde6GurzjLKiuoGig== X-Received: by 2002:a05:6512:1281:b0:52e:76e8:e18e with SMTP id 2adb3069b0e04-53546afaf96mr5333721e87.7.1725273411820; Mon, 02 Sep 2024 03:36:51 -0700 (PDT) Received: from neptune.local ([2a02:2f0e:3004:6100:e124:ce40:67a4:fcf0]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a89891da22bsm540876766b.182.2024.09.02.03.36.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Sep 2024 03:36:51 -0700 (PDT) From: Alexandru Ardelean To: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: jic23@kernel.org, krzk+dt@kernel.org, robh@kernel.org, lars@metafoo.de, michael.hennerich@analog.com, gstols@baylibre.com, Alexandru Ardelean Subject: [PATCH v2 0/8] iio: adc: ad7606: add support for AD7606C-{16,18} parts Date: Mon, 2 Sep 2024 13:36:23 +0300 Message-ID: <20240902103638.686039-1-aardelean@baylibre.com> X-Mailer: git-send-email 2.46.0 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The AD7606C-16 and AD7606C-18 are pretty similar with the AD7606B. The main difference between AD7606C-16 & AD7606C-18 is the precision in bits (16 vs 18). Because of that, some scales need to be defined for the 18-bit variants, as they need to be computed against 2**18 (vs 2**16 for the 16 bit-variants). Because the AD7606C-16,18 also supports bipolar & differential channels, for SW-mode, the default range of 10 V or ±10V should be set at probe. On reset, the default range (in the registers) is set to value 0x3 which corresponds to '±10 V single-ended range', regardless of bipolar or differential configuration. Aside from the scale/ranges, the AD7606C-16 is similar to the AD7606B. This changeset, does a bit of rework to the existing ad7606 driver and then adds support for the AD7606C-16 & AD7606C-18 parts. Datasheet links: https://www.analog.com/media/en/technical-documentation/data-sheets/ad7606c-16.pdf https://www.analog.com/media/en/technical-documentation/data-sheets/ad7606c-18.pdf Changelog v1 -> v2: - v1: https://lore.kernel.org/linux-iio/20240819064721.91494-1-aardelean@baylibre.com/ - Fixed description in 'iio: adc: ad7606: add 'bits' parameter to channels macros' - Added patch 'dt-bindings: iio: adc: document diff-channels corner case for some ADCs' - diff-channels = can be used to define differential channels with dedicated positive + negative pins - Re-worked patch 'dt-bindings: iio: adc: add adi,ad7606c-{16,18} compatible strings' - Using standard 'diff-channels' & 'bipolar' properties from adc.yaml - Re-worked patch 'iio: adc: ad7606: add support for AD7606C-{16,18} parts' - Reading 18-bit samples now relies on SPI controllers being able to pad 18-bits to 32-bits. - Implemented 'diff-channels = ' setting - Removed some bad/left-over channel configuration code which I forgot during development and rebasing. Alexandru Ardelean (8): iio: adc: ad7606: add 'bits' parameter to channels macros iio: adc: ad7606: move 'val' pointer to ad7606_scan_direct() iio: adc: ad7606: split a 'ad7606_sw_mode_setup()' from probe iio: adc: ad7606: wrap channel ranges & scales into struct iio: adc: ad7606: rework available attributes for SW channels dt-bindings: iio: adc: document diff-channels corner case for some ADCs dt-bindings: iio: adc: add adi,ad7606c-{16,18} compatible strings iio: adc: ad7606: add support for AD7606C-{16,18} parts .../devicetree/bindings/iio/adc/adc.yaml | 4 + .../bindings/iio/adc/adi,ad7606.yaml | 63 +++ drivers/iio/adc/ad7606.c | 430 +++++++++++++++--- drivers/iio/adc/ad7606.h | 78 +++- drivers/iio/adc/ad7606_spi.c | 71 ++- 5 files changed, 550 insertions(+), 96 deletions(-)