mbox series

[v2,0/3] iio: Introduce and use aligned_s64 type

Message ID 20240903180218.3640501-1-andriy.shevchenko@linux.intel.com (mailing list archive)
Headers show
Series iio: Introduce and use aligned_s64 type | expand

Message

Andy Shevchenko Sept. 3, 2024, 5:59 p.m. UTC
Instead of having open coded idea of aligned member, use
a newly defined type like it's done in, e.g., u64 case.
Update a few IIO drivers to show how to use it.

v2 (took only one year from v1, not bad!):
- avoided touching unrelated comments, code lines, etc. (Jonathan)
- used kernel internal type for the in-kernel code (Jonathan)

Andy Shevchenko (3):
  types: Complement the aligned types with signed 64-bit one
  iio: imu: st_lsm6dsx: Use aligned data type for timestamp
  iio: hid-sensor: Use aligned data type for timestamp

 drivers/iio/accel/hid-sensor-accel-3d.c              | 2 +-
 drivers/iio/gyro/hid-sensor-gyro-3d.c                | 2 +-
 drivers/iio/humidity/hid-sensor-humidity.c           | 2 +-
 drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h              | 3 +--
 drivers/iio/light/hid-sensor-als.c                   | 2 +-
 drivers/iio/orientation/hid-sensor-incl-3d.c         | 2 +-
 drivers/iio/orientation/hid-sensor-rotation.c        | 2 +-
 drivers/iio/position/hid-sensor-custom-intel-hinge.c | 2 +-
 drivers/iio/pressure/hid-sensor-press.c              | 2 +-
 drivers/iio/temperature/hid-sensor-temperature.c     | 2 +-
 include/linux/types.h                                | 3 ++-
 include/uapi/linux/types.h                           | 1 +
 12 files changed, 13 insertions(+), 12 deletions(-)

Comments

Jonathan Cameron Sept. 7, 2024, 3:37 p.m. UTC | #1
On Tue,  3 Sep 2024 20:59:03 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> Instead of having open coded idea of aligned member, use
> a newly defined type like it's done in, e.g., u64 case.
> Update a few IIO drivers to show how to use it.
> 
> v2 (took only one year from v1, not bad!):
:)

Applied with that tweak for patch 2 that you called out.

Will probably be next cycle though before these go upstream
(so think of this as queuing them up very early for 6.13 :)

> - avoided touching unrelated comments, code lines, etc. (Jonathan)
> - used kernel internal type for the in-kernel code (Jonathan)
> 
> Andy Shevchenko (3):
>   types: Complement the aligned types with signed 64-bit one
>   iio: imu: st_lsm6dsx: Use aligned data type for timestamp
>   iio: hid-sensor: Use aligned data type for timestamp
> 
>  drivers/iio/accel/hid-sensor-accel-3d.c              | 2 +-
>  drivers/iio/gyro/hid-sensor-gyro-3d.c                | 2 +-
>  drivers/iio/humidity/hid-sensor-humidity.c           | 2 +-
>  drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h              | 3 +--
>  drivers/iio/light/hid-sensor-als.c                   | 2 +-
>  drivers/iio/orientation/hid-sensor-incl-3d.c         | 2 +-
>  drivers/iio/orientation/hid-sensor-rotation.c        | 2 +-
>  drivers/iio/position/hid-sensor-custom-intel-hinge.c | 2 +-
>  drivers/iio/pressure/hid-sensor-press.c              | 2 +-
>  drivers/iio/temperature/hid-sensor-temperature.c     | 2 +-
>  include/linux/types.h                                | 3 ++-
>  include/uapi/linux/types.h                           | 1 +
>  12 files changed, 13 insertions(+), 12 deletions(-)
>
Andy Shevchenko Sept. 9, 2024, 9:20 a.m. UTC | #2
On Sat, Sep 07, 2024 at 04:37:52PM +0100, Jonathan Cameron wrote:
> On Tue,  3 Sep 2024 20:59:03 +0300
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> 
> > Instead of having open coded idea of aligned member, use
> > a newly defined type like it's done in, e.g., u64 case.
> > Update a few IIO drivers to show how to use it.
> > 
> > v2 (took only one year from v1, not bad!):
> :)
> 
> Applied with that tweak for patch 2 that you called out.

Please, also do
s/__aligned_s64/aligned_s64/
in the commit message there.

> Will probably be next cycle though before these go upstream
> (so think of this as queuing them up very early for 6.13 :)

Sure, thanks!
Jonathan Cameron Sept. 9, 2024, 7:01 p.m. UTC | #3
On Mon, 9 Sep 2024 12:20:38 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> On Sat, Sep 07, 2024 at 04:37:52PM +0100, Jonathan Cameron wrote:
> > On Tue,  3 Sep 2024 20:59:03 +0300
> > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> >   
> > > Instead of having open coded idea of aligned member, use
> > > a newly defined type like it's done in, e.g., u64 case.
> > > Update a few IIO drivers to show how to use it.
> > > 
> > > v2 (took only one year from v1, not bad!):  
> > :)
> > 
> > Applied with that tweak for patch 2 that you called out.  
> 
> Please, also do
> s/__aligned_s64/aligned_s64/
> in the commit message there.
done I think

> 
> > Will probably be next cycle though before these go upstream
> > (so think of this as queuing them up very early for 6.13 :)  
> 
> Sure, thanks!
>