mbox series

[0/3] iio: light: opt3001: add support for TI's opt3002 light sensor

Message ID 20240905-add_opt3002-v1-0-a5ae21b924fb@axis.com (mailing list archive)
Headers show
Series iio: light: opt3001: add support for TI's opt3002 light sensor | expand

Message

Emil Gedenryd Sept. 5, 2024, 10:20 a.m. UTC
TI's opt3002 light-to-digital sensor provides the functionality
of an optical power meter within a single device. It shares a lot of
similarities with their opt3001 model but has a wide spectral bandwidth,
ranging from 300 nm to 1000 nm.

This patch set adds support for the TI opt3002 by extending the opt3001
driver. In addition, a missing full-scale range value for the opt3001 is
added, resulting in higher precision when setting event trigger values.

See http://www.ti.com/product/OPT3002 for more information.

Signed-off-by: Emil Gedenryd <emil.gedenryd@axis.com>
---
Emil Gedenryd (3):
      iio: light: opt3001: add missing full-scale range value
      iio: light: opt3001: add support for TI's opt3002 light sensor
      dt-bindings: iio: light: opt3001: add compatible for opt3002

 .../devicetree/bindings/iio/light/ti,opt3001.yaml  |   1 +
 drivers/iio/light/Kconfig                          |   2 +-
 drivers/iio/light/opt3001.c                        | 203 +++++++++++++++++----
 3 files changed, 172 insertions(+), 34 deletions(-)
---
base-commit: 5be63fc19fcaa4c236b307420483578a56986a37
change-id: 20240828-add_opt3002-40552c1a2f77

Best regards,

Comments

Krzysztof Kozlowski Sept. 5, 2024, 10:38 a.m. UTC | #1
On 05/09/2024 12:20, Emil Gedenryd wrote:
> TI's opt3002 light-to-digital sensor provides the functionality
> of an optical power meter within a single device. It shares a lot of
> similarities with their opt3001 model but has a wide spectral bandwidth,
> ranging from 300 nm to 1000 nm.
> 
> This patch set adds support for the TI opt3002 by extending the opt3001
> driver. In addition, a missing full-scale range value for the opt3001 is
> added, resulting in higher precision when setting event trigger values.
> 
> See http://www.ti.com/product/OPT3002 for more information.
> 
> Signed-off-by: Emil Gedenryd <emil.gedenryd@axis.com>
> ---
> Emil Gedenryd (3):
>       iio: light: opt3001: add missing full-scale range value
>       iio: light: opt3001: add support for TI's opt3002 light sensor
>       dt-bindings: iio: light: opt3001: add compatible for opt3002

Bindings are before their users.

Best regards,
Krzysztof
Emil Gedenryd Sept. 5, 2024, 10:55 a.m. UTC | #2
On Thu, 2024-09-05 at 12:38 +0200, Krzysztof Kozlowski wrote:
> On 05/09/2024 12:20, Emil Gedenryd wrote:
> > TI's opt3002 light-to-digital sensor provides the functionality
> > of an optical power meter within a single device. It shares a lot of
> > similarities with their opt3001 model but has a wide spectral bandwidth,
> > ranging from 300 nm to 1000 nm.
> > 
> > This patch set adds support for the TI opt3002 by extending the opt3001
> > driver. In addition, a missing full-scale range value for the opt3001 is
> > added, resulting in higher precision when setting event trigger values.
> > 
> > See http://www.ti.com/product/OPT3002 for more information.
> > 
> > Signed-off-by: Emil Gedenryd <emil.gedenryd@axis.com>
> > ---
> > Emil Gedenryd (3):
> >       iio: light: opt3001: add missing full-scale range value
> >       iio: light: opt3001: add support for TI's opt3002 light sensor
> >       dt-bindings: iio: light: opt3001: add compatible for opt3002
> 
> Bindings are before their users.
> 
> Best regards,
> Krzysztof
> 
Thank you for taking a look at the patch set.
I'll submit a new version that fixes the issues you highlighted once moreĀ 
people have had time to review the changes.

Best regards,
Emil