mbox series

[v6,0/4] pressure: bmp280: Minor cleanup and interrupt support

Message ID 20240912233234.45519-1-vassilisamir@gmail.com (mailing list archive)
Headers show
Series pressure: bmp280: Minor cleanup and interrupt support | expand

Message

Vasileios Amoiridis Sept. 12, 2024, 11:32 p.m. UTC
Depends on this: https://lore.kernel.org/linux-iio/20240823172017.9028-1-vassilisamir@gmail.com

Changes in v6:
	- First 3 patches were applied already, last 4 remain.

[PATCH v6 1/4]:
	- Remove outer parentheses and change indentation in mathematical
	  expressions.
	- Use De-Morgan's Law to make !A OR !B = !(A AND B)

[PATCH v6 2/4]:
	- Remove extra line
	- Use contains keyword where it's needed

[PATCH v6 3/4]:
	- Change string from small to capital letters
	- Use better naming for interrupt pin config

---
v5: https://lore.kernel.org/linux-iio/20240902184222.24874-1-vassilisamir@gmail.com
v4: https://lore.kernel.org/linux-iio/20240828205128.92145-1-vassilisamir@gmail.com
v3: https://lore.kernel.org/linux-iio/20240823181714.64545-1-vassilisamir@gmail.com
v2: https://lore.kernel.org/linux-iio/20240725231039.614536-1-vassilisamir@gmail.com
v1: https://lore.kernel.org/linux-iio/20240711211558.106327-1-vassilisamir@gmail.com

Vasileios Amoiridis (4):
  iio: pressure: bmp280: Use sleep and forced mode for oneshot captures
  dt-bindings: iio: pressure: bmp085: Add interrupts for BMP3xx and
    BMP5xx devices
  iio: pressure: bmp280: Add data ready trigger support
  iio: pressure: bmp280: Move bmp085 interrupt to new configuration

 .../bindings/iio/pressure/bmp085.yaml         |  22 +-
 drivers/iio/pressure/bmp280-core.c            | 580 ++++++++++++++++--
 drivers/iio/pressure/bmp280-i2c.c             |   4 +-
 drivers/iio/pressure/bmp280-spi.c             |   4 +-
 drivers/iio/pressure/bmp280.h                 |  43 ++
 5 files changed, 613 insertions(+), 40 deletions(-)


base-commit: fec496684388685647652ab4213454fbabdab099
prerequisite-patch-id: e4f81f31f4fbb2aa872c0c74ed4511893eee0c9a

Comments

Andy Shevchenko Sept. 13, 2024, 9:54 a.m. UTC | #1
On Fri, Sep 13, 2024 at 01:32:30AM +0200, Vasileios Amoiridis wrote:
> Depends on this: https://lore.kernel.org/linux-iio/20240823172017.9028-1-vassilisamir@gmail.com

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
for patches 1 & 3.
Dunno if a couple of nit-picks warrants the v7, so I leave it to Jonathan to
decide.
Vasileios Amoiridis Sept. 14, 2024, 12:30 a.m. UTC | #2
On Fri, Sep 13, 2024 at 12:54:59PM +0300, Andy Shevchenko wrote:
> On Fri, Sep 13, 2024 at 01:32:30AM +0200, Vasileios Amoiridis wrote:
> > Depends on this: https://lore.kernel.org/linux-iio/20240823172017.9028-1-vassilisamir@gmail.com
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> for patches 1 & 3.
> Dunno if a couple of nit-picks warrants the v7, so I leave it to Jonathan to
> decide.
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
> 

Hi Andy!

Thanks for the reviews! 

Jonathan, I just sent a v7 with these small changes so you can go and
pick up the v7!

Cheers,
Vasilis