| Message ID | 20241022-ad7380-fix-supplies-v3-0-f0cefe1b7fa6@baylibre.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | iio: adc: ad7380: fix several supplies issues | expand |
On Tue, 22 Oct 2024 15:22:35 +0200 Julien Stephan <jstephan@baylibre.com> wrote: > Hello, > > This series tries to fix several issues found on the ad7380 driver about > supplies: > > - vcc and vlogic are required, but are not retrieved and enabled in the > probe function > - ad7380-4 is the only device from the family that does not have internal > reference and uses REFIN instead of REFIO for external reference. > > driver, bindings, and doc are fixed accordingly I considered a few responses to this series. 1) Asking you to pull the fixes to the front even though it would be painful. 2) Asking if the missing supplies patch should really be tagged as a fix. In the end I opted for the variant that may just confuse the stable folk the most and just took it as is + added stable to the 3 fixes. Hopefully it will be obvious they should just pick up all 5 (or maybe not the docs). You are correct that the refactors make it easier to review the fixes and this is a fairly new driver so I'm not that worried by pushing back the fix as it's only to 6.11. Applied to the fixes-togreg branch of iio.git. Note the side effect of this is timing is tight for having this available in the char-misc-next branch, so it may push back additional device support until next cycle. Thanks, Jonathan > > Signed-off-by: Julien Stephan <jstephan@baylibre.com> > --- > Changes in v3: > - Use fsleep instead of msleep > - Add all trailers from review > - Link to v2: https://lore.kernel.org/r/20241021-ad7380-fix-supplies-v2-0-2ca551b3352a@baylibre.com > > Changes in v2: > - Fix kernel test robot warning about variable uninitialized when used [1] > - drop commit removing supply description in bindings > - after discussion on [2] we decided to add refin supply here, as it > will be needed in the futur > > - Link to v1: https://lore.kernel.org/r/20241007-ad7380-fix-supplies-v1-0-badcf813c9b9@baylibre.com > > [1] https://lore.kernel.org/oe-kbuild-all/202410081608.ZxEPPZ0u-lkp@intel.com/ > [2] https://lore.kernel.org/all/20241015-ad7380-add-adaq4380-4-support-v1-0-d2e1a95fb248@baylibre.com/:warning > > --- > Julien Stephan (5): > dt-bindings: iio: adc: ad7380: fix ad7380-4 reference supply > iio: adc: ad7380: use devm_regulator_get_enable_read_voltage() > iio: adc: ad7380: add missing supplies > iio: adc: ad7380: fix supplies for ad7380-4 > docs: iio: ad7380: fix supply for ad7380-4 > > .../devicetree/bindings/iio/adc/adi,ad7380.yaml | 21 ++++ > Documentation/iio/ad7380.rst | 13 +- > drivers/iio/adc/ad7380.c | 136 ++++++++++++--------- > 3 files changed, 110 insertions(+), 60 deletions(-) > --- > base-commit: 1a8b58362f6a6fef975032f7fceb7c4b80d20d60 > change-id: 20241004-ad7380-fix-supplies-3677365cf8aa > > Best regards,
Le mar. 22 oct. 2024 à 22:02, Jonathan Cameron <jic23@kernel.org> a écrit : > > On Tue, 22 Oct 2024 15:22:35 +0200 > Julien Stephan <jstephan@baylibre.com> wrote: > > > Hello, > > > > This series tries to fix several issues found on the ad7380 driver about > > supplies: > > > > - vcc and vlogic are required, but are not retrieved and enabled in the > > probe function > > - ad7380-4 is the only device from the family that does not have internal > > reference and uses REFIN instead of REFIO for external reference. > > > > driver, bindings, and doc are fixed accordingly > > I considered a few responses to this series. > > 1) Asking you to pull the fixes to the front even though it would be painful. > 2) Asking if the missing supplies patch should really be tagged as a fix. > > In the end I opted for the variant that may just confuse the stable folk > the most and just took it as is + added stable to the 3 fixes. Hopefully > it will be obvious they should just pick up all 5 (or maybe not the docs). > > You are correct that the refactors make it easier to review the fixes > and this is a fairly new driver so I'm not that worried by pushing back the fix > as it's only to 6.11. > > Applied to the fixes-togreg branch of iio.git. > > Note the side effect of this is timing is tight for having this available > in the char-misc-next branch, so it may push back additional device > support until next cycle. > > Thanks, > Thank you! Cheers Julien > Jonathan > > > > > Signed-off-by: Julien Stephan <jstephan@baylibre.com> > > --- > > Changes in v3: > > - Use fsleep instead of msleep > > - Add all trailers from review > > - Link to v2: https://lore.kernel.org/r/20241021-ad7380-fix-supplies-v2-0-2ca551b3352a@baylibre.com > > > > Changes in v2: > > - Fix kernel test robot warning about variable uninitialized when used [1] > > - drop commit removing supply description in bindings > > - after discussion on [2] we decided to add refin supply here, as it > > will be needed in the futur > > > > - Link to v1: https://lore.kernel.org/r/20241007-ad7380-fix-supplies-v1-0-badcf813c9b9@baylibre.com > > > > [1] https://lore.kernel.org/oe-kbuild-all/202410081608.ZxEPPZ0u-lkp@intel.com/ > > [2] https://lore.kernel.org/all/20241015-ad7380-add-adaq4380-4-support-v1-0-d2e1a95fb248@baylibre.com/:warning > > > > --- > > Julien Stephan (5): > > dt-bindings: iio: adc: ad7380: fix ad7380-4 reference supply > > iio: adc: ad7380: use devm_regulator_get_enable_read_voltage() > > iio: adc: ad7380: add missing supplies > > iio: adc: ad7380: fix supplies for ad7380-4 > > docs: iio: ad7380: fix supply for ad7380-4 > > > > .../devicetree/bindings/iio/adc/adi,ad7380.yaml | 21 ++++ > > Documentation/iio/ad7380.rst | 13 +- > > drivers/iio/adc/ad7380.c | 136 ++++++++++++--------- > > 3 files changed, 110 insertions(+), 60 deletions(-) > > --- > > base-commit: 1a8b58362f6a6fef975032f7fceb7c4b80d20d60 > > change-id: 20241004-ad7380-fix-supplies-3677365cf8aa > > > > Best regards, >
Hello, This series tries to fix several issues found on the ad7380 driver about supplies: - vcc and vlogic are required, but are not retrieved and enabled in the probe function - ad7380-4 is the only device from the family that does not have internal reference and uses REFIN instead of REFIO for external reference. driver, bindings, and doc are fixed accordingly Signed-off-by: Julien Stephan <jstephan@baylibre.com> --- Changes in v3: - Use fsleep instead of msleep - Add all trailers from review - Link to v2: https://lore.kernel.org/r/20241021-ad7380-fix-supplies-v2-0-2ca551b3352a@baylibre.com Changes in v2: - Fix kernel test robot warning about variable uninitialized when used [1] - drop commit removing supply description in bindings - after discussion on [2] we decided to add refin supply here, as it will be needed in the futur - Link to v1: https://lore.kernel.org/r/20241007-ad7380-fix-supplies-v1-0-badcf813c9b9@baylibre.com [1] https://lore.kernel.org/oe-kbuild-all/202410081608.ZxEPPZ0u-lkp@intel.com/ [2] https://lore.kernel.org/all/20241015-ad7380-add-adaq4380-4-support-v1-0-d2e1a95fb248@baylibre.com/:warning --- Julien Stephan (5): dt-bindings: iio: adc: ad7380: fix ad7380-4 reference supply iio: adc: ad7380: use devm_regulator_get_enable_read_voltage() iio: adc: ad7380: add missing supplies iio: adc: ad7380: fix supplies for ad7380-4 docs: iio: ad7380: fix supply for ad7380-4 .../devicetree/bindings/iio/adc/adi,ad7380.yaml | 21 ++++ Documentation/iio/ad7380.rst | 13 +- drivers/iio/adc/ad7380.c | 136 ++++++++++++--------- 3 files changed, 110 insertions(+), 60 deletions(-) --- base-commit: 1a8b58362f6a6fef975032f7fceb7c4b80d20d60 change-id: 20241004-ad7380-fix-supplies-3677365cf8aa Best regards,