[v7,0/2] Support for Texas Instruments OPT4060 RGBW Color sensor.

Message

Per-Daniel Olsson Nov. 26, 2024, 2 p.m. UTC

This patch series adds support for Texas Instruments OPT4060 RGBW Color sensor
using the i2c interface.

The driver exposes raw adc values for red, green, blue and clear. The
illuminance is exposed as a calculated value in lux, the calculation uses the
wide spectrum green channel as base. The driver supports scaled values for red,
green and blue. The raw values are scaled so that for a particular test light
source, typically white, the measurement intensity is the same across the
different color channels. Integration time can be configured through sysfs as
well. The OPT4060 sensor supports both rising and falling threshold interrupts.
These interrupts are exposed as IIO events. The driver also implements an IIO
triggered buffer with a trigger for conversion ready interrupts.

Changes in v7:
- Calculation for scaled values changed to remove normalization.
- Fixed alignment in opt4060_write_ev_period(...).
- Fixed alignment in opt4060_read_ev_period(...).
- Updates state to bool in opt4060_write_event_config(...).
- dt-bindings: Define vdd-supply as required.
- dt-bindings: Removed description of vdd-supply.
- dt-bindings: Removed "Reviewed-by: Krzysztof Kozlowski <[e-mail]>"
  due to changes.
- Documentation: Added missing _scale parameters in Documentation/ABI/testing/sysfs-bus-iio
- Documentation: Updated opt4060.rst with description of scaled values without normalization.
- Cover letter: Description adapted to the new implementation of scaled values.
- Link to V6: https://lore.kernel.org/lkml/[e-mail]/

Changes in v6:
- Modified the driver to work with any trigger. Verified using iio-trig-sysfs.
- Fixed return in opt4060_trigger_set_state(...).
- Break added in opt4060_read_ev_period(...).
- Struct and variable declaration chnages in opt4060_trigger_handler(...).
- Events changed to modified and not unmodified.
- Moved variable declaration from case statement in opt4060_read_event(...), and
  opt4060_write_event(...), found by test robot.
- Init_completion() moved to a place related to IRQ.
- Documentation: Added opt4060.rst with description of calculations.
- Ducumentation: Added missing _raw parameters in Documentation/ABI/testing/sysfs-bus-iio
- Link to V5: https://lore.kernel.org/lkml/[e-mail]/

Changes in v5:
- Cover letter: Description adapted to new channel and trigger setup.
- Trigger for threshold removed.
- Channel setup modified according to email discussion.
- Switched to aligned_s64 from linux-next.
- Endianness in buffer changed to IIO_CPU.
- opt4060_read_raw_value(...) changed to avoid endian issue plus early return.
- opt4060_read_chan_value(...) split of in several for new channel setup.
- Improved return values in multiple places.
- The preenable callback removed, functionality moved to set_state.
- Irq setup removed from opt4060_irq_thread(...).
- Flipped logic with early return in opt4060_trigger_one_shot(...).
- devm_add_action_or_reset(...) moved to after opt4060_load_defaults(...).
- Documentation: Added sysfs-bus-iio-light-opt4060 with channel descriptions.
- Added hard coded name indio_dev->name.
- Modified opt4060_volatile_reg(...) to make test robot happy.
- Link to V4: https://lore.kernel.org/lkml/[e-mail]/

Changes in v4:
- Fix for a warning found by test robot in opt4060_write_event(...).
- Correction of early return in opt4060_write_event(...) and opt4060_read_event(...),
  missed from review of version 2.
- Correction of timeout for sample conversion.
- Correction of bug when changing integration time with buffer enabled.
- Link to V3: https://lore.kernel.org/lkml/[e-mail]/

Changes in v3:
- Cover letter: Removed lux from description.
- OPT_4060_DRV_NAME define removed.
- Corrected alignment for struct opt4060_buffer.
- Added description of the CRC calculation.
- Cleaned variable declaration in several places.
- Added a path for the non-irq case in opt4060_read_chan_value(...).
- Added a description of processed values.
- Use of regmap_clear_bits in opt4060_power_down(...).
- Switched to IIO_INTENSITY instead of IIO_LIGHT.
- Correction of channel index in IIO_UNMOD_EVENT_CODE, found by test robot.
- Added iio_chan_spec for the non-irq case without events.
- Fixed braces in a few if-else statements.
- Refactoring with early returns in a few places to reduce indentation.
- Replaced for_each_set_bit with iio_for_each_active_channel.
- Removed various too obvious comments.
- Fixed various other code style problems.
- Link to V2: https://lore.kernel.org/lkml/[e-mail]/

Changes in v2:
- dt-bindings: Removed incorrect allOf.
- dt-bindings: Changed to generic node name.
- Correction in opt4060_trigger_one_shot(...) for continuous mode.
- Correction in opt4060_power_down(...), wrong register was read.
- Corrected usage of active_scan_mask in opt4060_trigger_handler(...).
- Clean-up of various comments.
- Link to V1: https://lore.kernel.org/lkml/[e-mail]/

Per-Daniel Olsson (2):
  dt-bindings: iio: light: Document TI OPT4060 RGBW sensor
  iio: light: Add support for TI OPT4060 color sensor

 Documentation/ABI/testing/sysfs-bus-iio       |    7 +
 .../bindings/iio/light/ti,opt4060.yaml        |   51 +
 Documentation/iio/index.rst                   |    1 +
 Documentation/iio/opt4060.rst                 |   58 +
 drivers/iio/light/Kconfig                     |   13 +
 drivers/iio/light/Makefile                    |    1 +
 drivers/iio/light/opt4060.c                   | 1289 +++++++++++++++++
 7 files changed, 1420 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/light/ti,opt4060.yaml
 create mode 100644 Documentation/iio/opt4060.rst
 create mode 100644 drivers/iio/light/opt4060.c

--
2.39.5

Comments

Krzysztof Kozlowski Nov. 26, 2024, 2:15 p.m. UTC | #1

On 26/11/2024 15:00, Per-Daniel Olsson wrote:
> This patch series adds support for Texas Instruments OPT4060 RGBW Color sensor
> using the i2c interface.
> 
> The driver exposes raw adc values for red, green, blue and clear. The
> illuminance is exposed as a calculated value in lux, the calculation uses the
> wide spectrum green channel as base. The driver supports scaled values for red,
> green and blue. The raw values are scaled so that for a particular test light
> source, typically white, the measurement intensity is the same across the
> different color channels. Integration time can be configured through sysfs as
> well. The OPT4060 sensor supports both rising and falling threshold interrupts.
> These interrupts are exposed as IIO events. The driver also implements an IIO
> triggered buffer with a trigger for conversion ready interrupts.
> 
> Changes in v7:
> - Calculation for scaled values changed to remove normalization.
> - Fixed alignment in opt4060_write_ev_period(...).
> - Fixed alignment in opt4060_read_ev_period(...).
> - Updates state to bool in opt4060_write_event_config(...).
> - dt-bindings: Define vdd-supply as required.
> - dt-bindings: Removed description of vdd-supply.
> - dt-bindings: Removed "Reviewed-by: Krzysztof Kozlowski <[e-mail]>"
>   due to changes.
This is a bug surprise. Because you dropped description of vdd-supply?
No, that's not a reason to request a re-review.

Please read submitting patches document.

Keep the tag. I really do not expect more changes to the binding at
point of v6 or v7, especially ones so serious that result in dropping tags.

Reviewed-by: Krzysztof Kozlowski <[e-mail]>

Best regards,
Krzysztof

Per-Daniel Olsson Nov. 26, 2024, 3:50 p.m. UTC | #2

On 11/26/24 15:15, Krzysztof Kozlowski wrote:
> On 26/11/2024 15:00, Per-Daniel Olsson wrote:
>> This patch series adds support for Texas Instruments OPT4060 RGBW Color sensor
>> using the i2c interface.
>>
>> The driver exposes raw adc values for red, green, blue and clear. The
>> illuminance is exposed as a calculated value in lux, the calculation uses the
>> wide spectrum green channel as base. The driver supports scaled values for red,
>> green and blue. The raw values are scaled so that for a particular test light
>> source, typically white, the measurement intensity is the same across the
>> different color channels. Integration time can be configured through sysfs as
>> well. The OPT4060 sensor supports both rising and falling threshold interrupts.
>> These interrupts are exposed as IIO events. The driver also implements an IIO
>> triggered buffer with a trigger for conversion ready interrupts.
>>
>> Changes in v7:
>> - Calculation for scaled values changed to remove normalization.
>> - Fixed alignment in opt4060_write_ev_period(...).
>> - Fixed alignment in opt4060_read_ev_period(...).
>> - Updates state to bool in opt4060_write_event_config(...).
>> - dt-bindings: Define vdd-supply as required.
>> - dt-bindings: Removed description of vdd-supply.
>> - dt-bindings: Removed "Reviewed-by: Krzysztof Kozlowski <[e-mail]>"
>>   due to changes.
> This is a bug surprise. Because you dropped description of vdd-supply?
> No, that's not a reason to request a re-review.

I'm sorry for my misstep and for adding to your workload. I wasn't sure what to do
in this case with late review comments and clearly picked the wrong path. Won't happen
again.

Best regards / Per-Daniel

> 
> Please read submitting patches document.
> 
> Keep the tag. I really do not expect more changes to the binding at
> point of v6 or v7, especially ones so serious that result in dropping tags.
> 
> Reviewed-by: Krzysztof Kozlowski <[e-mail]>
> 
> Best regards,
> Krzysztof