mbox series

[v4,00/10] iio: adc: ad7124: Various fixes

Message ID 20241127145929.679408-12-u.kleine-koenig@baylibre.com (mailing list archive)
Headers show
Series iio: adc: ad7124: Various fixes | expand

Message

Uwe Kleine-König Nov. 27, 2024, 2:59 p.m. UTC
Hello,

this v4 is the follow up to
https://lore.kernel.org/linux-iio/20241122113322.242875-12-u.kleine-koenig@baylibre.com
addressing the comments by Trevor Gamblin, David Lechner and Andy
Shevchenko. Thanks for your feedback.

This series still bases on top of v6.12 + 64612ec9b909 ("iio: adc:
ad7124: Disable all channels at probe time").

Changes include:
 - Expand patch #3 to also extend the dt bindings for the other chips
   making use of the ad_sigma_delta helpers
 - Various code comment and commit log improvements (partly Andy)
 - Check for errors (and other cheap conditions) earlier to reduce
   indentions (Andy)
 - Add error check for gpiod_to_irq() in ad_sd_init()
 - Forward declaration of struct gpio_desc (Andy)
 - Fix a kernel doc descripts (kbuild bot)
 - drop en passant restructuring
 - Use local variable for &st->sd.spi->dev in several functions (Andy)
 - Add a comment about the suspicious bi-polar but still unsigned value
   (David)

In another thread Jonathan asked to maybe reshuffle the series to have
the changes first that should be backported. IMHO all but the last patch
are suitable for such a backport, so no need to reshuffle. Agreed?

Best regards
Uwe

Uwe Kleine-König (10):
  iio: adc: ad7124: Don't create more channels than the driver can
    handle
  iio: adc: ad7124: Refuse invalid input specifiers
  dt-bindings: iio: adc: adi,ad7{124,173,192,780}: Allow specifications
    of a gpio for irq line
  iio: adc: ad_sigma_delta: Add support for reading irq status using a
    GPIO
  iio: adc: ad_sigma_delta: Handle CS assertion as intended in
    ad_sd_read_reg_raw()
  iio: adc: ad_sigma_delta: Fix a race condition
  iio: adc: ad_sigma_delta: Store information about reset sequence
    length
  iio: adc: ad_sigma_delta: Check for previous ready signals
  iio: adc: ad7124: Add error reporting during probe
  iio: adc: ad7124: Implement temperature measurement

 .../bindings/iio/adc/adi,ad7124.yaml          |  13 ++
 .../bindings/iio/adc/adi,ad7173.yaml          |  12 +
 .../bindings/iio/adc/adi,ad7192.yaml          |  15 ++
 .../bindings/iio/adc/adi,ad7780.yaml          |  11 +
 drivers/iio/adc/ad7124.c                      | 220 +++++++++++++-----
 drivers/iio/adc/ad7173.c                      |   1 +
 drivers/iio/adc/ad7192.c                      |   4 +-
 drivers/iio/adc/ad7791.c                      |   1 +
 drivers/iio/adc/ad7793.c                      |   3 +-
 drivers/iio/adc/ad_sigma_delta.c              | 184 ++++++++++++---
 include/linux/iio/adc/ad_sigma_delta.h        |   8 +-
 11 files changed, 384 insertions(+), 88 deletions(-)


base-commit: adc218676eef25575469234709c2d87185ca223a
prerequisite-patch-id: 617af17fc377a984762c61893b9f2a92ae62213a