From patchwork Fri Jan 31 20:24:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955749 Received: from mail-oa1-f49.google.com (mail-oa1-f49.google.com [209.85.160.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F593158862 for ; Fri, 31 Jan 2025 20:24:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355089; cv=none; b=HONEXcdnlUkrlIQHyGuLyWt9TY3duKOgcr4iXyXkfsl1tac6vfw+UtUxFL5gz7eltOnZABnnh9SPBbWEtVmQq73KCHQKUJfn171Aiw1RbkAQ4OaCc+BLishZO3fZoLguxe/+twGpF5lbzezU+VjVzasKi7fPY/CkRVl071RDwbY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355089; c=relaxed/simple; bh=a4ev7NI00M+pqHz/c63lKpZN/tT3RLqqfUA5HRJSMsg=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=YXgXymVYdpz8ZKEz/EmABXnqQ+PMDvS+1KZ/v5fTxWzWV++hykHUyi/SUs3w/NLRWQxgokT0iwb75UXuZKw3+sMqgzlAI0nt+y9UwKO9IdLS/xDiS9wm567Z5g4ahM75IbUE3ZUd6oHQtjqWNKGAN30ujBpuDcFZv9dHVcS/r04= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=ShBjLv2U; arc=none smtp.client-ip=209.85.160.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="ShBjLv2U" Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-29fe83208a4so1201704fac.0 for ; Fri, 31 Jan 2025 12:24:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355085; x=1738959885; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=Jn/Ny7UFv/UH6iRtjr6jsBabEKLnDl2l7pEqvfjMtFM=; b=ShBjLv2U1w+5zymjIFhU7poftN9OhcetisFQnk0H3B/pvg/7UdFSNU0zrwqwuqtNdA nsFDff8ZM5KVXkXnc8UpScWb89BwAuyXMKVtsCOJstyRg2PC849jMkHfoCMS0leb8Gyz fvxO4R7AG6gGp5b9COON2kYqJu2ZeP5sBPzS7zaFz/1jpuluYh/4xx9yPbLjX/Qn+z89 AmQeZdxZxlt/15AIidokGNHek0k2zF7zFflb0NdXF5uOLh06aZ5OBhf3oD3JiK0wtQFG /yVyddYaQtIQKN5Cs1SZaxEAcf69u4iUJH9QTyWqP3aTZ/qc2kJA+J6kqXsdTyLmDf+f DDnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355085; x=1738959885; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Jn/Ny7UFv/UH6iRtjr6jsBabEKLnDl2l7pEqvfjMtFM=; b=rYjpKuiijVz7jpsuRDO9q8XrIC2wp5fxHUuJvclDvIqh9QjMEJCkUrqBtp1U6hO85c nFhwlmzBgTcxMZweqIGvhDMmmQ1xm77Vo1k6/6HshlcbfOyOo+vzbgW5c02gQ42ijqVY jwCr4oKjAq8e6fYVAYuG88TDvpgECn7m/2CAc73RdZxV3bDPsO/K486+Q4COunHC1TN0 +gsUzX+Xy+S7TXd2VxgLFZ2lD9CTYywyJjPng8MieBIWN8RPUBvkZ0eTuIDUvrVw+Ps4 Wsl9lBUImzHrMgMazAI5HU/0GMlzmzo2JwXkKvEusNXvQlKGj5jdl13E3rWpBn70Kjxb qmHA== X-Forwarded-Encrypted: i=1; AJvYcCXFWMIMYIOK6Ba376jgoHImlgFdmN9ZJaoSzY6127smrQuRkzIa5zJLsKmYFgxKqmcsU+uAtUAWtsg=@vger.kernel.org X-Gm-Message-State: AOJu0YxJJSKa30PnDJb1L8ilJclZ0Mdclhsqmz5QR3P0RcOYnpbth1Nk aO8oOjCqRQCUCHPMrHnbuxLRkcOauxEKQRZ6EcL8Eercjd+6FlxuabDkuIbh8F4= X-Gm-Gg: ASbGncuDP495wzrBpG5sHfT238wofeiSrx37kbK63pkQ9FfBPPUtRr14n9TG0cVtMau fTM0hs6oB7wkE/hUqQTcNjIO9G6YyoAaiZ6sXvx8f6fjfr9SN5hpLnNm8g+4ktZJhfTVJSKnwpo dCwNWEs+LIL7mM/klTKkn4a+IRsmeggAy3JE9GlE3MXMogA1KN5szp3CF0V6iPPCGnUK1M2EpiM EI1ryY29ElC62oFXDdDIhhecv75wQ+2NicsQo+LVhpRQtuRJlDsAPYG5/WPNUrmLQUu3+CSMY8q mQc77AQcNWrX7jl5RHhlUflE8M8hfe0wtXL4f9FO2e0DePI= X-Google-Smtp-Source: AGHT+IEA6MI3/eVAdqj25y/O52sPRoTGczW1O2gqmD31jZVU/w0qKc/rISzimaZq3KsB0lB7wfNBfQ== X-Received: by 2002:a05:6871:a581:b0:2b3:8c07:6461 with SMTP id 586e51a60fabf-2b38c07814dmr1466360fac.19.1738355085268; Fri, 31 Jan 2025 12:24:45 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.24.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:24:44 -0800 (PST) From: David Lechner Subject: [PATCH 00/13] gpiolib: add gpiods_set_array_value_cansleep Date: Fri, 31 Jan 2025 14:24:40 -0600 Message-Id: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAIgxnWcC/x3M3QpAQBBA4VfRXJvaHyKvIhfLjjUltlmJ5N1tL r+Lcx5IJEwJuuIBoZMT71uGLguYFrcFQvbZYJSplbYaQ+QdEx3oRNyNC62RBEdfOWta2yhvIbd RaObr//bD+35rVoI+ZwAAAA== X-Change-ID: 20250131-gpio-set-array-helper-bd4a328370d3 To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 This series was inspired by some minor annoyance I have experienced a few times in recent reviews. Calling gpiod_set_array_value_cansleep() can be quite verbose due to having so many parameters. In most cases, we already have a struct gpio_descs that contains the first 3 parameters so we end up with 3 (or often even 6) pointer indirections at each call site. Also, people have a tendency to want to hard-code the first argument instead of using struct gpio_descs.ndescs, often without checking that ndescs >= the hard-coded value. So I'm proposing that we add a gpiods_set_array_value_cansleep() function that is a wrapper around gpiod_set_array_value_cansleep() that has struct gpio_descs as the first parameter to make it a bit easier to read the code and avoid the hard-coding temptation. I've just done gpiods_set_array_value_cansleep() for now since there were over 10 callers of this one. There aren't as many callers of the get and atomic variants, but we can add those too if this seems like a useful thing to do. Reviewed-by: Linus Walleij --- David Lechner (13): gpiolib: add gpiods_set_array_value_cansleep() auxdisplay: seg-led-gpio: use gpiods_set_array_value_cansleep bus: ts-nbus: validate ts,data-gpios array size bus: ts-nbus: use gpiods_set_array_value_cansleep gpio: max3191x: use gpiods_set_array_value_cansleep iio: adc: ad7606: use gpiods_set_array_value_cansleep iio: amplifiers: hmc425a: use gpiods_set_array_value_cansleep iio: resolver: ad2s1210: use gpiods_set_array_value_cansleep mmc: pwrseq_simple: use gpiods_set_array_value_cansleep mux: gpio: use gpiods_set_array_value_cansleep net: mdio: mux-gpio: use gpiods_set_array_value_cansleep phy: mapphone-mdm6600: use gpiods_set_array_value_cansleep ASoC: adau1701: use gpiods_set_array_value_cansleep drivers/auxdisplay/seg-led-gpio.c | 3 +-- drivers/bus/ts-nbus.c | 10 ++++++---- drivers/gpio/gpio-max3191x.c | 18 +++++++----------- drivers/iio/adc/ad7606.c | 3 +-- drivers/iio/adc/ad7606_spi.c | 3 +-- drivers/iio/amplifiers/hmc425a.c | 3 +-- drivers/iio/resolver/ad2s1210.c | 8 ++------ drivers/mmc/core/pwrseq_simple.c | 3 +-- drivers/mux/gpio.c | 4 +--- drivers/net/mdio/mdio-mux-gpio.c | 3 +-- drivers/phy/motorola/phy-mapphone-mdm6600.c | 4 +--- include/linux/gpio/consumer.h | 7 +++++++ sound/soc/codecs/adau1701.c | 4 +--- 13 files changed, 31 insertions(+), 42 deletions(-) --- base-commit: df4b2bbff898227db0c14264ac7edd634e79f755 change-id: 20250131-gpio-set-array-helper-bd4a328370d3 Best regards,