| Message ID | 20250213-adc_ml-v4-0-66b68f8fdb8c@softing.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Support for TI ADS7128 and ADS7138 ADCs | expand |
On Thu, 13 Feb 2025 16:58:56 +0100 Tobias Sperling via B4 Relay <devnull+tobias.sperling.softing.com@kernel.org> wrote: > This patch series adds support for Texas Instruments ADS7128 and > ADS7138, which are 12-bit, 8 channel analog-to-digital converters (ADCs) > with build-in digital window comparator (DWC), using the I2C interface. > > The driver exposes the interfaces to read the raw values, as well as the > minimum and maximum value for each channel. In addition several settings > can be configured, like the DWC, sampling frequency or an averaging > filter/oversampling. Interrupts triggered by the DWC, if configured, are > then exposed as IIO events. > > ADS7128 differs in the addition of further hardware features, like a > root-mean-square (RMS) and a zero-crossing-detect (ZCD) module, which > are not yet supported by the driver. > > Regarding the I2C interface the chips using opcodes to define the way > how the registeres are accessed, like single or multiple register(s) > read/write or setting/clearing only bits. LGTM. Applied to the togreg branch of iio.git and pushed out initially as testing for 0-day to take a look at it. I did notice whilst applying that the Kconfig ordering for these TI parts has gotten scrambled. So at some point we should clean that up and bring them back into alphanumeric order! Jonathan
> Von: Jonathan Cameron <jic23@kernel.org> > Gesendet: Sonntag, 16. Februar 2025 16:55 > > On Thu, 13 Feb 2025 16:58:56 +0100 > Tobias Sperling via B4 Relay <mailto:devnull+tobias.sperling.softing.com@kernel.org> > wrote: > > > This patch series adds support for Texas Instruments ADS7128 and > > ADS7138, which are 12-bit, 8 channel analog-to-digital converters (ADCs) > > with build-in digital window comparator (DWC), using the I2C interface. > > > > The driver exposes the interfaces to read the raw values, as well as the > > minimum and maximum value for each channel. In addition several settings > > can be configured, like the DWC, sampling frequency or an averaging > > filter/oversampling. Interrupts triggered by the DWC, if configured, are > > then exposed as IIO events. > > > > ADS7128 differs in the addition of further hardware features, like a > > root-mean-square (RMS) and a zero-crossing-detect (ZCD) module, which > > are not yet supported by the driver. > > > > Regarding the I2C interface the chips using opcodes to define the way > > how the registeres are accessed, like single or multiple register(s) > > read/write or setting/clearing only bits. > LGTM. Applied to the togreg branch of iio.git and pushed out initially > as testing for 0-day to take a look at it. > > I did notice whilst applying that the Kconfig ordering for these TI parts > has gotten scrambled. So at some point we should clean that up and > bring them back into alphanumeric order! > > Jonathan Ok, thanks for the info. Then everything is going its way I guess. :) I can prepare a patch for the ordering. Shall this be based on top of this patch set or just the master branch? Tobias
This patch series adds support for Texas Instruments ADS7128 and ADS7138, which are 12-bit, 8 channel analog-to-digital converters (ADCs) with build-in digital window comparator (DWC), using the I2C interface. The driver exposes the interfaces to read the raw values, as well as the minimum and maximum value for each channel. In addition several settings can be configured, like the DWC, sampling frequency or an averaging filter/oversampling. Interrupts triggered by the DWC, if configured, are then exposed as IIO events. ADS7128 differs in the addition of further hardware features, like a root-mean-square (RMS) and a zero-crossing-detect (ZCD) module, which are not yet supported by the driver. Regarding the I2C interface the chips using opcodes to define the way how the registeres are accessed, like single or multiple register(s) read/write or setting/clearing only bits. --- Changes in v4: - dt-bindings: make avdd-supply mandatory. - Replace wildcard names with ads7138 or ADS7138 respectively. - Improve code style (add comments, indentation, placing of brackets, helper struct for dev) - Rename _setclear_bit() and use it for single writes. - Use DEFINE_RUNTIME_DEV_PM_OPS. - Make avdd mandatory and verify it's not a stub. - Link to v3: https://lore.kernel.org/r/20250206-adc_ml-v3-0-1d0bd3483aa2@softing.com Changes in v3: - Make interrupt optional. - Replace SET_RUNTIME_PM_OPS() with RUNTIME_PM_OPS() to prevent warning. - Rework read_avail for sampling frequency to show each frequency only once. - Use IIO_CHAN_INFO_PEAK and IIO_CHAN_INFO_TROUGH instead of ext_info. - Link to v2: https://lore.kernel.org/r/20250203-adc_ml-v2-0-8a597660c395@softing.com Changes in v2: - Improved commit messages. - dt-bindings: drop info about what driver supports, make 'avdd-supply' optional. - General rework of driver regarding indentation and code style. - General code improvements to make code shorter and improve readability, like remove 'goto's, order of declarations, ... - Use kernel macros and functions, like FIELD_*, guard(), ... - Rework i2c functions to return 0 in case of success and use i2c_master_send() if possible. - Use struct for chip data instead of enum. - Add comment to what the lock is used for and make sure it's used in these cases. - Use read_avail of iio_info and extend to return also the available values for OSR. - Rework to only accept values of the availability list. - Use devm_* if possible and therefore drop 'remove' callback. - Rebase to kernel 6.13 and adjust to API changes. - Link to v1: https://lore.kernel.org/r/20241122-adc_ml-v1-0-0769f2e1bbc1@softing.com Changes in v1 (to patch series without b4): - dt-bindings: Extended description Signed-off-by: Tobias Sperling <tobias.sperling@softing.com> --- Tobias Sperling (2): dt-bindings: iio: adc: Introduce ADS7138 iio: adc: Add driver for ADS7128 / ADS7138 .../devicetree/bindings/iio/adc/ti,ads7138.yaml | 63 ++ drivers/iio/adc/Kconfig | 10 + drivers/iio/adc/Makefile | 1 + drivers/iio/adc/ti-ads7138.c | 749 +++++++++++++++++++++ 4 files changed, 823 insertions(+) --- base-commit: 05dbaf8dd8bf537d4b4eb3115ab42a5fb40ff1f5 change-id: 20241122-adc_ml-d1ce86e85b2c Best regards,