mbox series

[v8,0/6] Update auto corner freq calculation

Message ID 20250328174831.227202-1-sam.winchenbach@framepointer.org (mailing list archive)
Headers show
Series Update auto corner freq calculation | expand

Message

Sam Winchenbach March 28, 2025, 5:48 p.m. UTC
From: Sam Winchenbach <swinchenbach@arka.org>

v1: Initial submission
v2: Cleaned up wording of commit message
v3: Add DTS properties to control corner frequency margins
v4: Fixed wrapping
    Added maintainers to CC
v5: Remove magic numbers
    Break out patches into features
    Small coding style fixes
v6: Converted dts property from hz to mhz
    Removed blank lines in dts binding documentation
v7: Updated author/sign-off address
    fixed patch path description
v8: Added missing Reviewed-By tag in v7

Brian Pellegrino (1):
  iio: filter: admv8818: Support frequencies >= 2^32

Sam Winchenbach (5):
  dt-bindings: iio: filter: Add lpf/hpf freq margins
  iio: filter: admv8818: fix band 4, state 15
  iio: filter: admv8818: fix integer overflow
  iio: filter: admv8818: fix range calculation
  iio: core: Add support for writing 64 bit attrs

 .../bindings/iio/filter/adi,admv8818.yaml     |  20 ++
 drivers/iio/filter/admv8818.c                 | 224 +++++++++++++-----
 drivers/iio/industrialio-core.c               |  12 +
 3 files changed, 202 insertions(+), 54 deletions(-)

Comments

Jonathan Cameron March 30, 2025, 3:23 p.m. UTC | #1
On Fri, 28 Mar 2025 13:48:25 -0400
Sam Winchenbach <sam.winchenbach@framepointer.org> wrote:

> From: Sam Winchenbach <swinchenbach@arka.org>
> 
> v1: Initial submission
> v2: Cleaned up wording of commit message
> v3: Add DTS properties to control corner frequency margins
> v4: Fixed wrapping
>     Added maintainers to CC
> v5: Remove magic numbers
>     Break out patches into features
>     Small coding style fixes
> v6: Converted dts property from hz to mhz
>     Removed blank lines in dts binding documentation
> v7: Updated author/sign-off address
>     fixed patch path description
> v8: Added missing Reviewed-By tag in v7
> 
> Brian Pellegrino (1):
>   iio: filter: admv8818: Support frequencies >= 2^32
Applied to the togreg branch of iio.git and initially pushed out as testing.

I thought about splitting off the fixes and sending them a faster path, but that
last fix is rather large for that so I haven't.

Shout if you think I should try to get the fixes upstream quickly and
I can move them to my fixes branch.

Jonathan

> 
> Sam Winchenbach (5):
>   dt-bindings: iio: filter: Add lpf/hpf freq margins
>   iio: filter: admv8818: fix band 4, state 15
>   iio: filter: admv8818: fix integer overflow
>   iio: filter: admv8818: fix range calculation
>   iio: core: Add support for writing 64 bit attrs
> 
>  .../bindings/iio/filter/adi,admv8818.yaml     |  20 ++
>  drivers/iio/filter/admv8818.c                 | 224 +++++++++++++-----
>  drivers/iio/industrialio-core.c               |  12 +
>  3 files changed, 202 insertions(+), 54 deletions(-)
>
Sam Winchenbach March 31, 2025, 7:30 p.m. UTC | #2
On Sun, Mar 30, 2025 at 04:23:00PM +0100, Jonathan Cameron wrote:
> On Fri, 28 Mar 2025 13:48:25 -0400
> Sam Winchenbach <sam.winchenbach@framepointer.org> wrote:
> 
> > From: Sam Winchenbach <swinchenbach@arka.org>
> > 
> > v1: Initial submission
> > v2: Cleaned up wording of commit message
> > v3: Add DTS properties to control corner frequency margins
> > v4: Fixed wrapping
> >     Added maintainers to CC
> > v5: Remove magic numbers
> >     Break out patches into features
> >     Small coding style fixes
> > v6: Converted dts property from hz to mhz
> >     Removed blank lines in dts binding documentation
> > v7: Updated author/sign-off address
> >     fixed patch path description
> > v8: Added missing Reviewed-By tag in v7
> > 
> > Brian Pellegrino (1):
> >   iio: filter: admv8818: Support frequencies >= 2^32
> Applied to the togreg branch of iio.git and initially pushed out as testing.
> 
> I thought about splitting off the fixes and sending them a faster path, but that
> last fix is rather large for that so I haven't.
> 
> Shout if you think I should try to get the fixes upstream quickly and
> I can move them to my fixes branch.
> 
> Jonathan

This sounds fine to me. I don't understand the differences between the branches
so I am more than happy to defer to your expertise.

I don't believe these fixes are critical, although the behavior is incorrect.

Thank you, happy to see patchset making some progress.
-Sam

> 
> > 
> > Sam Winchenbach (5):
> >   dt-bindings: iio: filter: Add lpf/hpf freq margins
> >   iio: filter: admv8818: fix band 4, state 15
> >   iio: filter: admv8818: fix integer overflow
> >   iio: filter: admv8818: fix range calculation
> >   iio: core: Add support for writing 64 bit attrs
> > 
> >  .../bindings/iio/filter/adi,admv8818.yaml     |  20 ++
> >  drivers/iio/filter/admv8818.c                 | 224 +++++++++++++-----
> >  drivers/iio/industrialio-core.c               |  12 +
> >  3 files changed, 202 insertions(+), 54 deletions(-)
> > 
>