[v3,0/3] Add driver for AD3530R and AD3531R DACs

Message

Paller, Kim Seer April 3, 2025, 5:33 a.m. UTC

The AD3530/AD3530R (8-channel) and AD3531/AD3531R (4-channel) are
low-power, 16-bit, buffered voltage output DACs with software-
programmable gain controls, providing full-scale output spans of 2.5V or
5V for reference voltages of 2.5V. These devices operate from a single
2.7V to 5.5V supply and are guaranteed monotonic by design. The "R"
variants include a 2.5V, 5ppm/°C internal reference, which is disabled
by default.

The AD3531R/AD3531 is not yet released, so the only available datasheet
for now is the AD3530R/AD3530. The only differences between the two is
the number of channels, and register addresses of some registers.

Signed-off-by: Kim Seer Paller <[e-mail]>
---
Changes in v3:
- Drop ABI docs.

Bindings:
- Drop reviewer's tag.
- Update commit message.
- Add non-r variants to compatible list.
- Add io-channels property to enable ADC channel support for MUXOUT
  readings.
- Switch to unevaluatedProperties: false.

ad3530r:
- Update commit message.
- Drop spi field from ad3530r_state and use regmap to retrieve the device
  pointer.
- Update mutex lock comment and use devm_mutex_init().
- Fix LDAC gpio pulse logic.
- Replace usleep_range() with fsleep().
- Use sizeof(reg_val) instead of hardcoded value in regmap_bulk_read.
- Drop reporting of zero offset.
- Add internal_ref_support chip_info parameter and modify reference
  handling.

- Link to v2: https://lore.kernel.org/r/[e-mail]

Changes in v2:
Bindings:
- Updated commit message.
- Changed adi,double-output-range to adi,range-double property.

ad3530r:
- Changed data type to __be16 to resolve sparse warnings related to
  type mismatches.

- Link to v1: https://lore.kernel.org/r/[e-mail]

---
Kim Seer Paller (3):
      iio: ABI: add new DAC powerdown mode
      dt-bindings: iio: dac: Add adi,ad3530r.yaml
      iio: dac: ad3530r: Add driver for AD3530R and AD3531R

 Documentation/ABI/testing/sysfs-bus-iio            |   2 +
 .../devicetree/bindings/iio/dac/adi,ad3530r.yaml   |  99 ++++
 MAINTAINERS                                        |   8 +
 drivers/iio/dac/Kconfig                            |  11 +
 drivers/iio/dac/Makefile                           |   1 +
 drivers/iio/dac/ad3530r.c                          | 514 +++++++++++++++++++++
 6 files changed, 635 insertions(+)
---
base-commit: 8dbeb413806f9f810d97d25284f585b201aa3bdc
change-id: 20250319-togreg-fc6a0af961ed

Best regards,

Comments

Krzysztof Kozlowski April 3, 2025, 6:43 a.m. UTC | #1

On Thu, Apr 03, 2025 at 01:33:54PM +0800, Kim Seer Paller wrote:
> The AD3530/AD3530R (8-channel) and AD3531/AD3531R (4-channel) are
> low-power, 16-bit, buffered voltage output DACs with software-
> programmable gain controls, providing full-scale output spans of 2.5V or
> 5V for reference voltages of 2.5V. These devices operate from a single
> 2.7V to 5.5V supply and are guaranteed monotonic by design. The "R"
> variants include a 2.5V, 5ppm/°C internal reference, which is disabled
> by default.
> 
> The AD3531R/AD3531 is not yet released, so the only available datasheet
> for now is the AD3530R/AD3530. The only differences between the two is
> the number of channels, and register addresses of some registers.
> 
> Signed-off-by: Kim Seer Paller <[e-mail]>
> ---
> Changes in v3:
> - Drop ABI docs.
> 
> Bindings:
> - Drop reviewer's tag.

Why? Explain why you are dropping.

Best regards,
Krzysztof

Paller, Kim Seer April 3, 2025, 6:58 a.m. UTC | #2

> -----Original Message-----
> From: Krzysztof Kozlowski <[e-mail]>
> Sent: Thursday, April 3, 2025 2:44 PM
> To: Paller, Kim Seer <[e-mail]>
> Cc: Jonathan Cameron <[e-mail]>; Lars-Peter Clausen
> <[e-mail]>; Hennerich, Michael <[e-mail]>;
> Rob Herring <[e-mail]>; Krzysztof Kozlowski <[e-mail]>;
> Conor Dooley <[e-mail]>; [e-mail]; linux-
> [e-mail]; [e-mail]
> Subject: Re: [PATCH v3 0/3] Add driver for AD3530R and AD3531R DACs
> 
> [External]
> 
> On Thu, Apr 03, 2025 at 01:33:54PM +0800, Kim Seer Paller wrote:
> > The AD3530/AD3530R (8-channel) and AD3531/AD3531R (4-channel) are
> > low-power, 16-bit, buffered voltage output DACs with software-
> > programmable gain controls, providing full-scale output spans of 2.5V
> > or 5V for reference voltages of 2.5V. These devices operate from a
> > single 2.7V to 5.5V supply and are guaranteed monotonic by design. The "R"
> > variants include a 2.5V, 5ppm/°C internal reference, which is disabled
> > by default.
> >
> > The AD3531R/AD3531 is not yet released, so the only available
> > datasheet for now is the AD3530R/AD3530. The only differences between
> > the two is the number of channels, and register addresses of some registers.
> >
> > Signed-off-by: Kim Seer Paller <[e-mail]>
> > ---
> > Changes in v3:
> > - Drop ABI docs.
> >
> > Bindings:
> > - Drop reviewer's tag.
> 
> Why? Explain why you are dropping.

I introduce modifications that might require re-review of the updated implementation
(e.g, adding io-channels property, switching to unevaluatedProperties: false, and adding
non-r variants to the compatible list). Is the tag still applicable?

> 
> Best regards,
> Krzysztof