| Message ID | cover.1667151588.git.ang.iglesiasg@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | i2c: core: Introduce i2c_client_get_device_id helper | expand |
On Sun, Oct 30, 2022 at 06:51:06PM +0100, Angel Iglesias wrote: > Hello, > > I don't want to step anyone's work here, so I'm sending this RFC to the > devs involved in the original discussion. I read on Uwe Kleine-König's > patchset submission thread the necessity for an i2c helper to aid with the > migration to the new i2c_driver .probe_new callback. Following the > suggestions made there, I wrote this small patchset implementing the > suggested helper function and ported the bmp280 IIO i2c probe to the new > probe using that helper. For the entire series (please drop RFC in the next version) Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Thanks for your time! > Angel > > Original discussion thread for additional context: > https://lore.kernel.org/all/20221023132302.911644-11-u.kleine-koenig@pengutronix.de/ > > Angel Iglesias (2): > i2c: core: Introduce i2c_client_get_device_id helper function > iio: pressure: bmp280: convert to i2c's .probe_new() > > drivers/i2c/i2c-core-base.c | 15 +++++++++++++++ > drivers/iio/pressure/bmp280-i2c.c | 8 ++++---- > include/linux/i2c.h | 1 + > 3 files changed, 20 insertions(+), 4 deletions(-) > > > base-commit: c32793afc6976e170f6ab11ca3750fe94fb3454d > -- > 2.38.1 >
On Tue, 1 Nov 2022 16:58:13 +0200 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > On Sun, Oct 30, 2022 at 06:51:06PM +0100, Angel Iglesias wrote: > > Hello, > > > > I don't want to step anyone's work here, so I'm sending this RFC to the > > devs involved in the original discussion. I read on Uwe Kleine-König's > > patchset submission thread the necessity for an i2c helper to aid with the > > migration to the new i2c_driver .probe_new callback. Following the > > suggestions made there, I wrote this small patchset implementing the > > suggested helper function and ported the bmp280 IIO i2c probe to the new > > probe using that helper. > > For the entire series (please drop RFC in the next version) > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> I'm happy to pick up the next version but a question on 'route' in to the kernel. I can do an immutable branch with just the new function call in it if that is useful given I assume this is applicable across a bunch of subsystems? Jonathan > > > Thanks for your time! > > Angel > > > > Original discussion thread for additional context: > > https://lore.kernel.org/all/20221023132302.911644-11-u.kleine-koenig@pengutronix.de/ > > > > Angel Iglesias (2): > > i2c: core: Introduce i2c_client_get_device_id helper function > > iio: pressure: bmp280: convert to i2c's .probe_new() > > > > drivers/i2c/i2c-core-base.c | 15 +++++++++++++++ > > drivers/iio/pressure/bmp280-i2c.c | 8 ++++---- > > include/linux/i2c.h | 1 + > > 3 files changed, 20 insertions(+), 4 deletions(-) > > > > > > base-commit: c32793afc6976e170f6ab11ca3750fe94fb3454d > > -- > > 2.38.1 > > >
> I can do an immutable branch with just the new function call in it if > that is useful given I assume this is applicable across a bunch of subsystems? I'd think I should provide the immutable branch with the new I2C API call. Feels a bit more logical. Will that work for you as well?
On Sat, 5 Nov 2022 22:29:29 +0100 Wolfram Sang <wsa@kernel.org> wrote: > > I can do an immutable branch with just the new function call in it if > > that is useful given I assume this is applicable across a bunch of subsystems? > > I'd think I should provide the immutable branch with the new I2C API > call. Feels a bit more logical. Will that work for you as well? > Absolutely. That's even better - I didn't want to assign you work to do :) Jonathan