From patchwork Tue Apr 4 14:11:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Breathitt Gray X-Patchwork-Id: 13200263 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2114CC761AF for ; Tue, 4 Apr 2023 14:12:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235283AbjDDOMK (ORCPT ); Tue, 4 Apr 2023 10:12:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235419AbjDDOMJ (ORCPT ); Tue, 4 Apr 2023 10:12:09 -0400 Received: from mail-yw1-x1134.google.com (mail-yw1-x1134.google.com [IPv6:2607:f8b0:4864:20::1134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69A403AB1 for ; Tue, 4 Apr 2023 07:12:06 -0700 (PDT) Received: by mail-yw1-x1134.google.com with SMTP id 00721157ae682-5463fa0c2bfso285261167b3.1 for ; Tue, 04 Apr 2023 07:12:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680617525; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ap5QnifDiiqkIiZVcjMyWrvUdPzu45RE6/ZRmZRra9g=; b=O2mAEIUmXml0vUnyKxQZcqMVeXraxjL9J/FvnL/8wVrcLZB/PcUxN+3CvUqy4y9t/c MeHoIQpqRdKSEjxsWKkPeHh1T6vCe6EX57Dbkn56pUPW9Uz9BhNNvlRvJuOgEu1Z6w32 f/LJzGt1IvuLeP0oOGWj4bwRuvvwnN+SptlGmkypGvmMVeH+ti4XL1p8ULJJRZQq8Oyu 6ojlqrd/6jATJbrmpAYutRc8JqkLp6dN1DSiyCFMeJs/Htc1WkSw42v0glcwBCGp9iTt 81a0H/pZpP9/DBpOMq9hXBG5s6XOKoMLDkmW4fY+TpLTPZm4ZTRt7Cd32U3dZCuXBGvf hhvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680617525; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ap5QnifDiiqkIiZVcjMyWrvUdPzu45RE6/ZRmZRra9g=; b=E6Mr31m/VsGWSf2TgQ3MNOv/x59Jd9qd0YpWp+gL2jdjPRaJXpjcSuu6xpYigpwA9j iZsoLx8W/0DeFXBb0Yy+I29ismdmQe3pQptpacTYadqBZdP7hm9k1DeLT8C9fD8xsdlj Sdv/E9XmLTDbgMS0dPDvXkGft5/RX5ADw7WQoIH+rKFQGJNhU78lJ4HW4i14tUXsfzPD 4O71eAAHaD+O/g74bEnZqm/BbIdUJRII352DaXg1iqjcsI6J/Q2TM5MQ7dcHUrB6M21b cHZMpuGX7NPi9TpzmUQO67P0RDXiCcjOrwqqcOEUOYRHXoJyLJvwMHNg5J0tKJ+4GMO7 oaXA== X-Gm-Message-State: AAQBX9dniA2K5WOUOnIrUzpRLpMJtIAFWjmM2I0BcSH4m/PDIjAaQdQ0 sAFf3AmsxVViI4+GCo3oBXugPg== X-Google-Smtp-Source: AKy350anYZpdKncvP6NK23mmlxjyduZnB/P8VsZkA6z2XC+Z9XjaZ/6HSLg1AzG11K2nLzZt+hcLnQ== X-Received: by 2002:a0d:d583:0:b0:541:7193:e136 with SMTP id x125-20020a0dd583000000b005417193e136mr2353099ywd.23.1680617525609; Tue, 04 Apr 2023 07:12:05 -0700 (PDT) Received: from fedora.attlocal.net (69-109-179-158.lightspeed.dybhfl.sbcglobal.net. [69.109.179.158]) by smtp.gmail.com with ESMTPSA id d195-20020a811dcc000000b00545a08184d8sm3202750ywd.104.2023.04.04.07.12.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Apr 2023 07:12:05 -0700 (PDT) From: William Breathitt Gray To: Jonathan Cameron , Lars-Peter Clausen Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , William Breathitt Gray Subject: [PATCH v4 0/5] Migrate STX104 to the regmap API Date: Tue, 4 Apr 2023 10:11:57 -0400 Message-Id: X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Changes in v4: - Fix race conditions in stx104_read_raw() and stx104_write_raw() by utilizing a mutex - Improve indentation in stx104_write_raw() by bailing out early if chan->output is false in for the IIO_CHAN_INFO_RAW case - Remove regmap_config max_register lines as superfluous - Utilize BIT() for gain calculation in stx104_read_raw() Changes in v3: - Add STX104_ prefixes to defines to avoid potential name classes - Rename SAME_CHANNEL() to STX104_SINGLE_CHANNEL() to convey intention better - Utilize u8_encode_bits() to define STX104_SOFTWARE_TRIGGER - Adjust to utilize reg_base members in regmap_config structures - Fix off-by-one errors in aio_data_wr_ranges[], aio_data_rd_ranges[], and aio_data_regmap_config max_register - Inline gpio_config initialization to avoid zeroing it at declaration - Add blank lines between register map init blocks for clarity - Utilize regmap_read_poll_timeout() for ADC conversion status poll Changes in v2: - Relocate struct stx104_iio for the sake of a clearer patch diff - Replace FIELD_PREP() and FIELD_GET() with u8_encode_bits() and u8_get_bits() The regmap API supports IO port accessors so we can take advantage of regmap abstractions rather than handling access to the device registers directly in the driver. To make the git history cleaner, a precursor patch to improve indentation in stx104_write_raw() and a follow-up patch to utilize regmap_read_poll_timeout() for polling the ADC conversion status are included. William Breathitt Gray (5): iio: addac: stx104: Fix race condition for stx104_write_raw() iio: addac: stx104: Fix race condition when converting analog-to-digital iio: addac: stx104: Improve indentation in stx104_write_raw() iio: addac: stx104: Migrate to the regmap API iio: addac: stx104: Use regmap_read_poll_timeout() for conversion poll drivers/iio/addac/Kconfig | 2 + drivers/iio/addac/stx104.c | 455 +++++++++++++++++++++---------------- 2 files changed, 261 insertions(+), 196 deletions(-) base-commit: f73df43e957a6fc705a9bd6d143585bdf1b13365