| Message ID | cover.1684579603.git.anupnewsmail@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add dt-binding support for ti tmp006 | expand |
On Sat, 20 May 2023 16:21:50 +0530 Anup Sharma <anupnewsmail@gmail.com> wrote: > These patches introduce device tree binding support and > add an of_device_id table entry to the driver. > > Changes in v2: > - Keep the exsisting MODULE_DEVICE_TABLE entry. > - Removed the inner comma in of_device_id. > - Order the included header to improve code organization. > - Adding missing semicolon to fix syntax error detected > using dt_binding_check. > LGTM - I'll leave them a little while though for others to comment before picking them up. Thanks, Jonathan > Anup Sharma (2): > dt-bindings: iio: temperature: Add support for tmp006 > iio: temperature: tmp006: Add OF device matching support > > .../bindings/iio/temperature/ti,tmp006.yaml | 42 +++++++++++++++++++ > drivers/iio/temperature/tmp006.c | 8 ++++ > 2 files changed, 50 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/temperature/ti,tmp006.yaml >
On Sat, May 20, 2023 at 04:20:02PM +0100, Jonathan Cameron wrote: > On Sat, 20 May 2023 16:21:50 +0530 > Anup Sharma <anupnewsmail@gmail.com> wrote: > > > These patches introduce device tree binding support and > > add an of_device_id table entry to the driver. > > > > Changes in v2: > > - Keep the exsisting MODULE_DEVICE_TABLE entry. > > - Removed the inner comma in of_device_id. > > - Order the included header to improve code organization. > > - Adding missing semicolon to fix syntax error detected > > using dt_binding_check. > > > LGTM - I'll leave them a little while though for others to comment before > picking them up. It may be a wee bit before you here from Krzysztof, but the binding check issues have been fixed, as have the things he pointed out in the original submission AFAICT. Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor.
On Sat, 20 May 2023 23:32:03 +0100 Conor Dooley <conor@kernel.org> wrote: > On Sat, May 20, 2023 at 04:20:02PM +0100, Jonathan Cameron wrote: > > On Sat, 20 May 2023 16:21:50 +0530 > > Anup Sharma <anupnewsmail@gmail.com> wrote: > > > > > These patches introduce device tree binding support and > > > add an of_device_id table entry to the driver. > > > > > > Changes in v2: > > > - Keep the exsisting MODULE_DEVICE_TABLE entry. > > > - Removed the inner comma in of_device_id. > > > - Order the included header to improve code organization. > > > - Adding missing semicolon to fix syntax error detected > > > using dt_binding_check. > > > > > LGTM - I'll leave them a little while though for others to comment before > > picking them up. > > It may be a wee bit before you here from Krzysztof, but the binding > check issues have been fixed, as have the things he pointed out in the > original submission AFAICT. > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > Thanks! Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to have their fun. Thanks, Jonathan > Thanks, > Conor.