From patchwork Wed Jan 31 21:26:14 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 10194839 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A6439603EE for ; Wed, 31 Jan 2018 21:26:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 972FD2885B for ; Wed, 31 Jan 2018 21:26:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8A2B328885; Wed, 31 Jan 2018 21:26:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 296CF2885B for ; Wed, 31 Jan 2018 21:26:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751766AbeAaV0g (ORCPT ); Wed, 31 Jan 2018 16:26:36 -0500 Received: from mout.web.de ([212.227.15.4]:50414 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751674AbeAaV0f (ORCPT ); Wed, 31 Jan 2018 16:26:35 -0500 Received: from [192.168.1.2] ([77.182.166.142]) by smtp.web.de (mrweb003 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MKIti-1ehXrS1WVC-001lpJ; Wed, 31 Jan 2018 22:26:16 +0100 To: linux-iio@vger.kernel.org, linux-input@vger.kernel.org, Hartmut Knaack , Jiri Kosina , Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Srinivas Pandruvada Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] hid-sensor-accel-3d: Delete an error message for a failed memory allocation in hid_accel_3d_probe() Message-ID: <0406765c-bdd1-1a82-cf66-1c248063ae4f@users.sourceforge.net> Date: Wed, 31 Jan 2018 22:26:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 Content-Language: en-US X-Provags-ID: V03:K0:GyNLTsejwyzRjMjVIBAhV7ueMdmMsQOPSQMWiJdnxoqcv7LcUR1 8Vv6g9zLm6UBHZj9AsNMI1SG9n4vsND11HYWn+cxrzLVBtsg+8YSR7mBa+xanOqyiUsJ++T iuLb326J3NRWdHN1X9QnGJD7LPHEsuYeUXk5zmMq2rslSRi1EmOKtljoyk0C8LaIqrio2MM shAZysaCjy6Z216llp/Aw== X-UI-Out-Filterresults: notjunk:1; V01:K0:a0W/ES+goc8=:+gVpupWmIAQGsnc2ggft1F kI2xrWJ0eYA1m/adRiis3Y4k3XP3SfotFhGn2n17vZfi8i8ZIn2F9GvmroGlXPnk7/K/tMtsk LwykjQ2z+q3zio0DARz1SuG7jteJZtZIS2MozqfeU/NN+52dNibrZQhT32PipvS1CHNw4uZn9 dj53qPYrIIgeLNdrhUpfYwSGdUAgnBdcyUzGbX+DiMvuebv2gFn+AodSiAqlc0o8izbunfQ6S QDMVzS87GGyErEvE0WdrccjuGZlYGVbCQCLQXwOZ07JcROmrlfLUxr+yUT/f3EuaKjIc9UHIt HPQa26rsFs0bTGUAaVNOOcFymkGrZoHlD/ifttYpbZoWeO/4xiGs2oHo7fTMzCvPDVr4mq7YE V+BQLTPgheUzh5QpfXnV/6Ib0kwx4uHBmE2l0oQQJmUYGHsEzfPfQViiQ6sIsG/auIvs6auX4 Fw0a9n/cZmTCONHPfGx46YMWDfAb6YqpRMEURcHKlASvK/TzXVucURzui+7qBNSj2tVQxqgda zmK0/hQZBgp7TFeZpKzQrEC7ZWBi3hncaZD0tNhJ5OX1rYZmCMRXPVteOUzSRgZTW10fUq7h2 791cNMKh98hlzWCHpzRlwmxdHbJ9/a0fRNbl2OZJ7Y0etCSMtZJdjLinwBa8/Jx8/8kNJhDys IhYA4rcZEEhY/KpKdCep3I8+5ubOhLu+ykJkJmnLtSN02/GJrnrgyduc6QiirebGbOmmmHKNU fTvc/uaHihKEy3Z+BWZHlm60UvF0C2v42MNv4TxacMWCuCNbH1qSYiWzQPxBvFgAKoQmFaNPd NPfKnsxXER3ugi4tZwBcWlL7x2eK4QjQd9QTE6lY/Up9h7Fe6Q= Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Wed, 31 Jan 2018 22:20:56 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/iio/accel/hid-sensor-accel-3d.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/iio/accel/hid-sensor-accel-3d.c b/drivers/iio/accel/hid-sensor-accel-3d.c index c066a3bdbff7..3d0acde40285 100644 --- a/drivers/iio/accel/hid-sensor-accel-3d.c +++ b/drivers/iio/accel/hid-sensor-accel-3d.c @@ -383,11 +383,9 @@ static int hid_accel_3d_probe(struct platform_device *pdev) return ret; } indio_dev->channels = kmemdup(channel_spec, channel_size, GFP_KERNEL); - - if (!indio_dev->channels) { - dev_err(&pdev->dev, "failed to duplicate channels\n"); + if (!indio_dev->channels) return -ENOMEM; - } + ret = accel_3d_parse_report(pdev, hsdev, (struct iio_chan_spec *)indio_dev->channels, hsdev->usage, accel_state);