| Message ID | 05D5E061-47A3-4446-BC4C-558B2DA054D3@norphonic.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3,1/2] Driver for TI HDC20x0 humidity and temperature sensors | expand |
On Fri, 13 Dec 2019 15:57:30 +0000 Eugene Zalkonnikov <ez@norphonic.com> wrote: Hi Eugene, There is a bit of a movement to asking for power supplies being described in dt bindings from the start. I'm not insisting on it as it is easy to add later and always backwards compatible. (if you don't need to describe a regulator from the start, then it must always be on so a stub regulator will be fine). Otherwise looks good to me, but dt bindings should always be cc'd to the devicetree mailing list and maintainers. See the MAINTAINERS file for the email addresses. For a simple binding there is a bit of latitude for maintainers to take them without an explicit review (to keep the DT maintainers sane!) but we always like to give them the opportunity to comment. As Rob and Mark will confirm I'm far from always right in my reviews of these! Thanks, Jonathan > Signed-off-by: Eugene Zaikonnikov <eugene.zaikonnikov@norphonic.com> > > diff -uprN linux-5.3.8/Documentation/ABI/testing/sysfs-bus-iio-humidity-hdc2010 linux-5.3.8_docs/Documentation/ABI/testing/sysfs-bus-iio-humidity-hdc2010 > --- linux-5.3.8/Documentation/ABI/testing/sysfs-bus-iio-humidity-hdc2010 1970-01-01 01:00:00.000000000 +0100 > +++ linux-5.3.8_docs/Documentation/ABI/testing/sysfs-bus-iio-humidity-hdc2010 2019-12-02 11:09:25.803326999 +0100 > @@ -0,0 +1,9 @@ > +What: /sys/bus/iio/devices/iio:deviceX/out_current_heater_raw > +What: /sys/bus/iio/devices/iio:deviceX/out_current_heater_raw_available > +KernelVersion: 5.3.8 > +Contact: linux-iio@vger.kernel.org > +Description: > + Controls the heater device within the humidity sensor to get > + rid of excess condensation. > + > + Valid control values are 0 = OFF, and 1 = ON. > diff -uprN linux-5.3.8/Documentation/devicetree/bindings/iio/humidity/hdc2010.yaml linux-5.3.8_docs/Documentation/devicetree/bindings/iio/humidity/hdc2010.yaml > --- linux-5.3.8/Documentation/devicetree/bindings/iio/humidity/hdc2010.yaml 1970-01-01 01:00:00.000000000 +0100 > +++ linux-5.3.8_docs/Documentation/devicetree/bindings/iio/humidity/hdc2010.yaml 2019-12-02 08:43:32.508277082 +0100 > @@ -0,0 +1,43 @@ > +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/humidity/hdc2010.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: HDC2010/HDC2080 humidity and temperature iio sensors > + > +maintainers: > + - Eugene Zaikonnikov <eugene.zaikonnikov@norophonic.com> > + > +description: | > + Relative humidity and tempereature sensors on I2C bus > + > + Datasheets are available at: > + http://www.ti.com/product/HDC2010/datasheet > + http://www.ti.com/product/HDC2080/datasheet > + > +properties: > + compatible: > + enum: > + - ti,hdc2010 > + - ti,hdc2080 > + > + interrupts: > + description: > + interrupt mapping for IRQ > + maxItems: 1 > + > +required: > + - compatible > + > +examples: > + - | > + i2c0 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + hdc200x@40 { > + compatible = "ti,hdc2010"; > + reg = <0x40>; > + }; > + }; >
diff -uprN linux-5.3.8/Documentation/ABI/testing/sysfs-bus-iio-humidity-hdc2010 linux-5.3.8_docs/Documentation/ABI/testing/sysfs-bus-iio-humidity-hdc2010 --- linux-5.3.8/Documentation/ABI/testing/sysfs-bus-iio-humidity-hdc2010 1970-01-01 01:00:00.000000000 +0100 +++ linux-5.3.8_docs/Documentation/ABI/testing/sysfs-bus-iio-humidity-hdc2010 2019-12-02 11:09:25.803326999 +0100 @@ -0,0 +1,9 @@ +What: /sys/bus/iio/devices/iio:deviceX/out_current_heater_raw +What: /sys/bus/iio/devices/iio:deviceX/out_current_heater_raw_available +KernelVersion: 5.3.8 +Contact: linux-iio@vger.kernel.org +Description: + Controls the heater device within the humidity sensor to get + rid of excess condensation. + + Valid control values are 0 = OFF, and 1 = ON. diff -uprN linux-5.3.8/Documentation/devicetree/bindings/iio/humidity/hdc2010.yaml linux-5.3.8_docs/Documentation/devicetree/bindings/iio/humidity/hdc2010.yaml --- linux-5.3.8/Documentation/devicetree/bindings/iio/humidity/hdc2010.yaml 1970-01-01 01:00:00.000000000 +0100 +++ linux-5.3.8_docs/Documentation/devicetree/bindings/iio/humidity/hdc2010.yaml 2019-12-02 08:43:32.508277082 +0100 @@ -0,0 +1,43 @@ +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/humidity/hdc2010.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: HDC2010/HDC2080 humidity and temperature iio sensors + +maintainers: + - Eugene Zaikonnikov <eugene.zaikonnikov@norophonic.com> + +description: | + Relative humidity and tempereature sensors on I2C bus + + Datasheets are available at: + http://www.ti.com/product/HDC2010/datasheet + http://www.ti.com/product/HDC2080/datasheet + +properties: + compatible: + enum: + - ti,hdc2010 + - ti,hdc2080 + + interrupts: + description: + interrupt mapping for IRQ + maxItems: 1 + +required: + - compatible + +examples: + - | + i2c0 { + #address-cells = <1>; + #size-cells = <0>; + + hdc200x@40 { + compatible = "ti,hdc2010"; + reg = <0x40>; + }; + };
Signed-off-by: Eugene Zaikonnikov <eugene.zaikonnikov@norphonic.com>