diff mbox series

[RFC,v2,5/5] MAINTAINERS: Add KX022A maintainer entry

Message ID 08ccdc318b448eb69c82efc82adcd044536df4af.1665066397.git.mazziesaccount@gmail.com (mailing list archive)
State Changes Requested
Headers show
Series iio: Support ROHM/Kionix kx022a | expand

Commit Message

Matti Vaittinen Oct. 6, 2022, 2:38 p.m. UTC
Add maintainer entry for ROHM/Kionix KX022A accelerometer senor driver.

Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>

---
I can also add myself as a maintainer instead of a reviewer if it better
suits iio maintainer. I however don't plan setting up my own public
repository and hope the further patches will be merged via IIO tree.

So, as Geert once explained to me - In that case the difference between
me as a maintainer vs. a reviewer would be only really relevant to the
subsystem (in this case IIO) maintainer. The subsystem maintainer who
merges patches is allowed to take in changes acked by downstream
maintainer w/o obligation to do thorough review. (Downstream maintainer is
to be blamed if things explode :]). If ack is given by a reviewer, then
the subsystem maintainer has the full responsibility and should always
do the review. Or - this is how I remember our discussion went - feel
free to correct me if I am wrong :] In any case - please let me know if
you'd rather see M: not R: in front of my name for the kx022a.
---
 MAINTAINERS | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Jonathan Cameron Oct. 9, 2022, 12:38 p.m. UTC | #1
On Thu, 6 Oct 2022 17:38:34 +0300
Matti Vaittinen <mazziesaccount@gmail.com> wrote:

> Add maintainer entry for ROHM/Kionix KX022A accelerometer senor driver.
> 
> Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
> 
> ---
> I can also add myself as a maintainer instead of a reviewer if it better
> suits iio maintainer. I however don't plan setting up my own public
> repository and hope the further patches will be merged via IIO tree.
> 
> So, as Geert once explained to me - In that case the difference between
> me as a maintainer vs. a reviewer would be only really relevant to the
> subsystem (in this case IIO) maintainer. The subsystem maintainer who
> merges patches is allowed to take in changes acked by downstream
> maintainer w/o obligation to do thorough review. (Downstream maintainer is
> to be blamed if things explode :]). If ack is given by a reviewer, then
> the subsystem maintainer has the full responsibility and should always
> do the review. Or - this is how I remember our discussion went - feel
> free to correct me if I am wrong :] In any case - please let me know if
> you'd rather see M: not R: in front of my name for the kx022a.


Entirely up to you.  I tend to take a look at all IIO patches but will
take a less detailed look if there is a tag from someone I've built
up trust with - doesn't matter if they are a maintainer of a particular
driver or not. I only ever look at MAINTAINERS when sending out patches,
never when reviewing except to perhaps moan that someone wasn't cc'd
who should have been!

Jonathan


> ---
>  MAINTAINERS | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f5ca4aefd184..641b4fc2e5e2 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11356,6 +11356,11 @@ F:	drivers/mfd/khadas-mcu.c
>  F:	include/linux/mfd/khadas-mcu.h
>  F:	drivers/thermal/khadas_mcu_fan.c
>  
> +KIONIX/ROHM KX022A ACCELEROMETER
> +R:	Matti Vaittinen <mazziesaccount@gmail.com>
> +S:	Supported
> +F:	drivers/iio/accel/kionix-kx022a*
> +
>  KMEMLEAK
>  M:	Catalin Marinas <catalin.marinas@arm.com>
>  S:	Maintained
Matti Vaittinen Oct. 10, 2022, 9:31 a.m. UTC | #2
On 10/9/22 15:38, Jonathan Cameron wrote:
> On Thu, 6 Oct 2022 17:38:34 +0300
> Matti Vaittinen <mazziesaccount@gmail.com> wrote:
> 
>> Add maintainer entry for ROHM/Kionix KX022A accelerometer senor driver.
>>
>> Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
>>
>> ---
>> I can also add myself as a maintainer instead of a reviewer if it better
>> suits iio maintainer. I however don't plan setting up my own public
>> repository and hope the further patches will be merged via IIO tree.
>>
>> So, as Geert once explained to me - In that case the difference between
>> me as a maintainer vs. a reviewer would be only really relevant to the
>> subsystem (in this case IIO) maintainer. The subsystem maintainer who
>> merges patches is allowed to take in changes acked by downstream
>> maintainer w/o obligation to do thorough review. (Downstream maintainer is
>> to be blamed if things explode :]). If ack is given by a reviewer, then
>> the subsystem maintainer has the full responsibility and should always
>> do the review. Or - this is how I remember our discussion went - feel
>> free to correct me if I am wrong :] In any case - please let me know if
>> you'd rather see M: not R: in front of my name for the kx022a.
> 
> 
> Entirely up to you.  I tend to take a look at all IIO patches but will
> take a less detailed look if there is a tag from someone I've built
> up trust with - doesn't matter if they are a maintainer of a particular
> driver or not. I only ever look at MAINTAINERS when sending out patches,
> never when reviewing except to perhaps moan that someone wasn't cc'd
> who should have been!

In that case I'll keep the R as I have done with the other corners I've 
touched.

Yours
	-- Matti
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index f5ca4aefd184..641b4fc2e5e2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11356,6 +11356,11 @@  F:	drivers/mfd/khadas-mcu.c
 F:	include/linux/mfd/khadas-mcu.h
 F:	drivers/thermal/khadas_mcu_fan.c
 
+KIONIX/ROHM KX022A ACCELEROMETER
+R:	Matti Vaittinen <mazziesaccount@gmail.com>
+S:	Supported
+F:	drivers/iio/accel/kionix-kx022a*
+
 KMEMLEAK
 M:	Catalin Marinas <catalin.marinas@arm.com>
 S:	Maintained