| Message ID | 1526397557-31389-1-git-send-email-fabrice.gasnier@st.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, 15 May 2018 17:19:17 +0200 Fabrice Gasnier <fabrice.gasnier@st.com> wrote: > Fix the following sparse warnings: > CHECK drivers/iio/adc/stm32-dfsdm-adc.c > symbol 'stm32_dfsdm_get_buff_cb' was not declared. Should it be static? > symbol 'stm32_dfsdm_release_buff_cb' was not declared. Should it be static? > > BTW, move interrupt.h to sort headers alphabetically. > > Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com> Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/iio/adc/stm32-dfsdm-adc.c | 4 ++-- > include/linux/iio/adc/stm32-dfsdm-adc.h | 2 ++ > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c > index 1b78bec..31462ae 100644 > --- a/drivers/iio/adc/stm32-dfsdm-adc.c > +++ b/drivers/iio/adc/stm32-dfsdm-adc.c > @@ -8,11 +8,11 @@ > > #include <linux/dmaengine.h> > #include <linux/dma-mapping.h> > -#include <linux/interrupt.h> > +#include <linux/iio/adc/stm32-dfsdm-adc.h> > #include <linux/iio/buffer.h> > #include <linux/iio/hw-consumer.h> > -#include <linux/iio/iio.h> > #include <linux/iio/sysfs.h> > +#include <linux/interrupt.h> > #include <linux/module.h> > #include <linux/of_device.h> > #include <linux/platform_device.h> > diff --git a/include/linux/iio/adc/stm32-dfsdm-adc.h b/include/linux/iio/adc/stm32-dfsdm-adc.h > index e7dc7a5..0da298b 100644 > --- a/include/linux/iio/adc/stm32-dfsdm-adc.h > +++ b/include/linux/iio/adc/stm32-dfsdm-adc.h > @@ -9,6 +9,8 @@ > #ifndef STM32_DFSDM_ADC_H > #define STM32_DFSDM_ADC_H > > +#include <linux/iio/iio.h> > + > int stm32_dfsdm_get_buff_cb(struct iio_dev *iio_dev, > int (*cb)(const void *data, size_t size, > void *private), -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c index 1b78bec..31462ae 100644 --- a/drivers/iio/adc/stm32-dfsdm-adc.c +++ b/drivers/iio/adc/stm32-dfsdm-adc.c @@ -8,11 +8,11 @@ #include <linux/dmaengine.h> #include <linux/dma-mapping.h> -#include <linux/interrupt.h> +#include <linux/iio/adc/stm32-dfsdm-adc.h> #include <linux/iio/buffer.h> #include <linux/iio/hw-consumer.h> -#include <linux/iio/iio.h> #include <linux/iio/sysfs.h> +#include <linux/interrupt.h> #include <linux/module.h> #include <linux/of_device.h> #include <linux/platform_device.h> diff --git a/include/linux/iio/adc/stm32-dfsdm-adc.h b/include/linux/iio/adc/stm32-dfsdm-adc.h index e7dc7a5..0da298b 100644 --- a/include/linux/iio/adc/stm32-dfsdm-adc.h +++ b/include/linux/iio/adc/stm32-dfsdm-adc.h @@ -9,6 +9,8 @@ #ifndef STM32_DFSDM_ADC_H #define STM32_DFSDM_ADC_H +#include <linux/iio/iio.h> + int stm32_dfsdm_get_buff_cb(struct iio_dev *iio_dev, int (*cb)(const void *data, size_t size, void *private),
Fix the following sparse warnings: CHECK drivers/iio/adc/stm32-dfsdm-adc.c symbol 'stm32_dfsdm_get_buff_cb' was not declared. Should it be static? symbol 'stm32_dfsdm_release_buff_cb' was not declared. Should it be static? BTW, move interrupt.h to sort headers alphabetically. Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com> --- drivers/iio/adc/stm32-dfsdm-adc.c | 4 ++-- include/linux/iio/adc/stm32-dfsdm-adc.h | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-)