From patchwork Thu Dec 6 03:15:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anson Huang X-Patchwork-Id: 10715209 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1627A13BB for ; Thu, 6 Dec 2018 03:15:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 042E32D73B for ; Thu, 6 Dec 2018 03:15:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EB4102D779; Thu, 6 Dec 2018 03:15:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CB6D82D73B for ; Thu, 6 Dec 2018 03:15:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728238AbeLFDPy (ORCPT ); Wed, 5 Dec 2018 22:15:54 -0500 Received: from mail-eopbgr50072.outbound.protection.outlook.com ([40.107.5.72]:6400 "EHLO EUR03-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727514AbeLFDPx (ORCPT ); Wed, 5 Dec 2018 22:15:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WzW3x7nOr37PKTIA8/6JnMeJ9W02uKApG0A+azLa08k=; b=qmi6vsLaUBuC2KNujqFfpQSYzHzndR6PuhliXrQMV+4YQDpXdrh2vvRwMmkYWjd2jmkHh7N2PRXRfKPQFmZa4bywn6JpxqlPFBWjJAZEYuJYLHRSTHaqNjNPWDcE3I3znhTB6G/m3MB3HuW5ccK6C2aQZhwdo/rjUDxq7qEyPSE= Received: from DB3PR0402MB3916.eurprd04.prod.outlook.com (52.134.72.18) by DB3PR0402MB3802.eurprd04.prod.outlook.com (52.134.71.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1382.22; Thu, 6 Dec 2018 03:15:48 +0000 Received: from DB3PR0402MB3916.eurprd04.prod.outlook.com ([fe80::adf8:f49d:deb4:58fd]) by DB3PR0402MB3916.eurprd04.prod.outlook.com ([fe80::adf8:f49d:deb4:58fd%3]) with mapi id 15.20.1382.023; Thu, 6 Dec 2018 03:15:48 +0000 From: Anson Huang To: "jic23@kernel.org" , "knaack.h@gmx.de" , "lars@metafoo.de" , "pmeerw@pmeerw.net" , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: dl-linux-imx Subject: [PATCH] iio: light: isl29018: add optional vcc regulator operation support Thread-Topic: [PATCH] iio: light: isl29018: add optional vcc regulator operation support Thread-Index: AQHUjRH8CfSZy5OH8ESc4x40JN2bLA== Date: Thu, 6 Dec 2018 03:15:48 +0000 Message-ID: <1544065798-4465-1-git-send-email-Anson.Huang@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.7.4 x-clientproxiedby: HK0PR03CA0066.apcprd03.prod.outlook.com (2603:1096:203:52::30) To DB3PR0402MB3916.eurprd04.prod.outlook.com (2603:10a6:8:10::18) x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DB3PR0402MB3802;6:jTSiKxhVFLoHkbEYlhNmJL0v9oyhEF7zglN4zZq6jTUUhQluW/IVHJcOtcsOwLUevDHg2BTKDa8zTMJxFX676PjDplCpOmQtnvbTWIhrU04iF5QrD332S7FNwrbXvo6YkIDVYiESpUQCXPLYetdPw5nInWaA9845kR+uXSILb3vTronQOgQeJ85aylZo9qDAOXp0fxsnjiivxFUhQOChdNHjYlIOuhMcf2L+cnJrSfd+QySzi48AHezGTT83tGjgyXRMf+698WYPdai3MpWrAIl0gg/5Yi2betB9ZpdHBbCpeuIuZn5to8p2y1wjQ6c9+OZc44oLr/4QbVMYjWALXTasC0vcM9qVvWD0zr73htDAsHjUJwG8RpIQm0GA3A/w/ISt1N7ZcpV1mnXwCiMl58zKOWOv0PNyLFS7I46fXlt5MBQAuLrohZo1/UqReQHuR9H8UKzm62SVKPqfvGRKOA==;5:k/pngTcP5uUD25POHgm8QwUs0wcca2hO1VUI8EH2ykQPNbQmiWwysyMov0VmeI0C5CEHjkFwIpnwHQvatFFHrFuM+waxusGdrGFdQK5PW/eW3L7SMu6/7hIeei58ln9BT+34HECyVjXVL6etMLcMlVbfcyodnN8O6GIaqEIOMu0=;7:qXbnwVZwptFODwKTPVckhEIeJCQPwnOiS+vES0sX7lw7oyXFGilg6f041A4hGSPINl9/tpBDuWnr682w33FbeVegNEs3B+2fWkRRtNvTUx322aeBekhtwOPfJHForPj/j46Of4XmoWodfnSh0MQWZg== x-ms-office365-filtering-correlation-id: ec8c6f82-d50c-4b89-061c-08d65b291e71 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390098)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020);SRVR:DB3PR0402MB3802; x-ms-traffictypediagnostic: DB3PR0402MB3802: authentication-results: spf=none (sender IP is ) smtp.mailfrom=anson.huang@nxp.com; x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3231455)(999002)(944501520)(52105112)(93006095)(93001095)(3002001)(6055026)(148016)(149066)(150057)(6041310)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(201708071742011)(7699051)(76991095);SRVR:DB3PR0402MB3802;BCL:0;PCL:0;RULEID:;SRVR:DB3PR0402MB3802; x-forefront-prvs: 087894CD3C x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(366004)(396003)(39850400004)(376002)(136003)(346002)(189003)(199004)(99286004)(26005)(106356001)(6116002)(6486002)(52116002)(97736004)(386003)(6436002)(25786009)(6506007)(102836004)(5660300001)(68736007)(110136005)(105586002)(186003)(3846002)(71200400001)(53936002)(14454004)(256004)(6512007)(71190400001)(8936002)(86362001)(14444005)(4326008)(66066001)(2906002)(36756003)(316002)(8676002)(81156014)(81166006)(305945005)(476003)(7736002)(2616005)(50226002)(486006)(2501003)(478600001)(2201001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB3PR0402MB3802;H:DB3PR0402MB3916.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 1D/3SLyDLMe1KnQS5v0fQp4+6sXLH6IpIVBpv5XR+qJLegNGh+osVYNHXopCfVPMKEhdQKbqOwhzL0Xtrt1KuCAlEp9KL0EXT0nfBO3nrQchrCSaBTG7FP2135ELcvk1Gt3bGtmnHgElezWTM4Aq8HR/lLtqqx6DoCBvcTa+CWzjOL72xADWBxmlvbZddCfLy9LttbDvVH1ZDsG5cAnuKbD9erppxQTwKD7qZskidGVFCXeqAxR7DUhzcm7CGc4QnnJQhLkKJ06AoZSF8WRhF3DuvryChQMGbl92CbnodGAX19Snof9qrx+zSpAKSzmDTchX+1GaSHangag3pHqq6bYkfpBLlAvaN30KScjnOfU= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: ec8c6f82-d50c-4b89-061c-08d65b291e71 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Dec 2018 03:15:48.5476 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0402MB3802 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The light sensor's power supply could be controlled by regulator on some platforms, such as i.MX6Q-SABRESD board, the light sensor isl29023's power supply is controlled by a GPIO fixed regulator, need to make sure the regulator is enabled before any operation of sensor, this patch adds optional vcc regulator operation support. Signed-off-by: Anson Huang --- drivers/iio/light/isl29018.c | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/drivers/iio/light/isl29018.c b/drivers/iio/light/isl29018.c index b45400f..47a55c8 100644 --- a/drivers/iio/light/isl29018.c +++ b/drivers/iio/light/isl29018.c @@ -23,6 +23,7 @@ #include #include #include +#include #include #include #include @@ -95,6 +96,7 @@ struct isl29018_chip { struct isl29018_scale scale; int prox_scheme; bool suspended; + struct regulator *vcc_reg; }; static int isl29018_set_integration_time(struct isl29018_chip *chip, @@ -735,6 +737,15 @@ static int isl29018_probe(struct i2c_client *client, mutex_init(&chip->lock); + chip->vcc_reg = devm_regulator_get_optional(&client->dev, "vcc"); + if (!IS_ERR(chip->vcc_reg)) { + err = regulator_enable(chip->vcc_reg); + if (err) { + dev_err(&client->dev, "failed to enable VDD regulator\n"); + return err; + } + } + chip->type = dev_id; chip->calibscale = 1; chip->ucalibscale = 0; @@ -768,6 +779,7 @@ static int isl29018_probe(struct i2c_client *client, static int isl29018_suspend(struct device *dev) { struct isl29018_chip *chip = iio_priv(dev_get_drvdata(dev)); + int ret; mutex_lock(&chip->lock); @@ -777,6 +789,14 @@ static int isl29018_suspend(struct device *dev) * So we do not have much to do here. */ chip->suspended = true; + if (!IS_ERR(chip->vcc_reg)) { + ret = regulator_disable(chip->vcc_reg); + if (ret) { + dev_err(dev, "failed to disable VDD regulator\n"); + mutex_unlock(&chip->lock); + return ret; + } + } mutex_unlock(&chip->lock); @@ -790,6 +810,15 @@ static int isl29018_resume(struct device *dev) mutex_lock(&chip->lock); + if (!IS_ERR(chip->vcc_reg)) { + err = regulator_enable(chip->vcc_reg); + if (err) { + dev_err(dev, "failed to enable VDD regulator\n"); + mutex_unlock(&chip->lock); + return err; + } + } + err = isl29018_chip_init(chip); if (!err) chip->suspended = false;