| Message ID | 1649933135-14236-1-git-send-email-baihaowen@meizu.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | iio: gp2ap020a00f: Fix signedness bug | expand |
On Thu, Apr 14, 2022 at 2:19 PM Haowen Bai <baihaowen@meizu.com> wrote: > > function gp2ap020a00f_get_thresh_reg() is unsigned but returning -EINVAL > errcode, and thresh_reg_l is unsigned but receiving -EINVAL errcode. so > we have to change u8 -> s8. s8 is not enough to hold an (arbitrary) error code. To be on the safe side you need to use int.
在 4/14/22 9:47 PM, Andy Shevchenko 写道: > On Thu, Apr 14, 2022 at 2:19 PM Haowen Bai <baihaowen@meizu.com> wrote: >> function gp2ap020a00f_get_thresh_reg() is unsigned but returning -EINVAL >> errcode, and thresh_reg_l is unsigned but receiving -EINVAL errcode. so >> we have to change u8 -> s8. > s8 is not enough to hold an (arbitrary) error code. To be on the safe > side you need to use int. > Thank you for your suggestion.
diff --git a/drivers/iio/light/gp2ap020a00f.c b/drivers/iio/light/gp2ap020a00f.c index b820041159f7..b0e62d3c6fa0 100644 --- a/drivers/iio/light/gp2ap020a00f.c +++ b/drivers/iio/light/gp2ap020a00f.c @@ -994,7 +994,7 @@ static irqreturn_t gp2ap020a00f_trigger_handler(int irq, void *data) return IRQ_HANDLED; } -static u8 gp2ap020a00f_get_thresh_reg(const struct iio_chan_spec *chan, +static s8 gp2ap020a00f_get_thresh_reg(const struct iio_chan_spec *chan, enum iio_event_direction event_dir) { switch (chan->type) { @@ -1025,7 +1025,7 @@ static int gp2ap020a00f_write_event_val(struct iio_dev *indio_dev, struct gp2ap020a00f_data *data = iio_priv(indio_dev); bool event_en = false; u8 thresh_val_id; - u8 thresh_reg_l; + s8 thresh_reg_l; int err = 0; mutex_lock(&data->lock); @@ -1082,7 +1082,7 @@ static int gp2ap020a00f_read_event_val(struct iio_dev *indio_dev, int *val, int *val2) { struct gp2ap020a00f_data *data = iio_priv(indio_dev); - u8 thresh_reg_l; + s8 thresh_reg_l; int err = IIO_VAL_INT; mutex_lock(&data->lock);
function gp2ap020a00f_get_thresh_reg() is unsigned but returning -EINVAL errcode, and thresh_reg_l is unsigned but receiving -EINVAL errcode. so we have to change u8 -> s8. Signed-off-by: Haowen Bai <baihaowen@meizu.com> --- drivers/iio/light/gp2ap020a00f.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)