diff mbox

iio: adc/accel: Fix up module licenses

Message ID 20171113102955.5257-1-linus.walleij@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Linus Walleij Nov. 13, 2017, 10:29 a.m. UTC
The module license checker complains about these two so just fix
it up. They are both GPLv2, both written by me or using code
I extracted while refactoring from the GPLv2 drivers.

Cc: Randy Dunlap <rdunlap@infradead.org>
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/iio/accel/kxsd9-i2c.c      | 3 +++
 drivers/iio/adc/qcom-vadc-common.c | 3 +++
 2 files changed, 6 insertions(+)

Comments

Jonathan Cameron Nov. 18, 2017, 3:54 p.m. UTC | #1
On Mon, 13 Nov 2017 11:29:55 +0100
Linus Walleij <linus.walleij@linaro.org> wrote:

> The module license checker complains about these two so just fix
> it up. They are both GPLv2, both written by me or using code
> I extracted while refactoring from the GPLv2 drivers.
> 
> Cc: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Applied to the togreg branch of iio.git which will probably be be pushed
out as testing for the autobuilders to play with it.

Thanks,

Jonathan
> ---
>  drivers/iio/accel/kxsd9-i2c.c      | 3 +++
>  drivers/iio/adc/qcom-vadc-common.c | 3 +++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/drivers/iio/accel/kxsd9-i2c.c b/drivers/iio/accel/kxsd9-i2c.c
> index 98fbb628d5bd..38411e1c155b 100644
> --- a/drivers/iio/accel/kxsd9-i2c.c
> +++ b/drivers/iio/accel/kxsd9-i2c.c
> @@ -63,3 +63,6 @@ static struct i2c_driver kxsd9_i2c_driver = {
>  	.id_table	= kxsd9_i2c_id,
>  };
>  module_i2c_driver(kxsd9_i2c_driver);
> +
> +MODULE_LICENSE("GPL v2");
> +MODULE_DESCRIPTION("KXSD9 accelerometer I2C interface");
> diff --git a/drivers/iio/adc/qcom-vadc-common.c b/drivers/iio/adc/qcom-vadc-common.c
> index 47d24ae5462f..d249ce643e48 100644
> --- a/drivers/iio/adc/qcom-vadc-common.c
> +++ b/drivers/iio/adc/qcom-vadc-common.c
> @@ -229,3 +229,6 @@ int qcom_vadc_decimation_from_dt(u32 value)
>  	return __ffs64(value / VADC_DECIMATION_MIN);
>  }
>  EXPORT_SYMBOL(qcom_vadc_decimation_from_dt);
> +
> +MODULE_LICENSE("GPL v2");
> +MODULE_DESCRIPTION("Qualcomm ADC common functionality");

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jonathan Cameron Nov. 19, 2017, 10:31 a.m. UTC | #2
On Sat, 18 Nov 2017 15:54:48 +0000
Jonathan Cameron <jic23@kernel.org> wrote:

> On Mon, 13 Nov 2017 11:29:55 +0100
> Linus Walleij <linus.walleij@linaro.org> wrote:
> 
> > The module license checker complains about these two so just fix
> > it up. They are both GPLv2, both written by me or using code
> > I extracted while refactoring from the GPLv2 drivers.
> > 
> > Cc: Randy Dunlap <rdunlap@infradead.org>
> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>  
> Applied to the togreg branch of iio.git which will probably be be pushed
> out as testing for the autobuilders to play with it.
Actually - this doesn't pass basic x86_64 build testing...
Needs to include module.h in the qcom driver.

Done...

Jonathan
> 
> Thanks,
> 
> Jonathan
> > ---
> >  drivers/iio/accel/kxsd9-i2c.c      | 3 +++
> >  drivers/iio/adc/qcom-vadc-common.c | 3 +++
> >  2 files changed, 6 insertions(+)
> > 
> > diff --git a/drivers/iio/accel/kxsd9-i2c.c b/drivers/iio/accel/kxsd9-i2c.c
> > index 98fbb628d5bd..38411e1c155b 100644
> > --- a/drivers/iio/accel/kxsd9-i2c.c
> > +++ b/drivers/iio/accel/kxsd9-i2c.c
> > @@ -63,3 +63,6 @@ static struct i2c_driver kxsd9_i2c_driver = {
> >  	.id_table	= kxsd9_i2c_id,
> >  };
> >  module_i2c_driver(kxsd9_i2c_driver);
> > +
> > +MODULE_LICENSE("GPL v2");
> > +MODULE_DESCRIPTION("KXSD9 accelerometer I2C interface");
> > diff --git a/drivers/iio/adc/qcom-vadc-common.c b/drivers/iio/adc/qcom-vadc-common.c
> > index 47d24ae5462f..d249ce643e48 100644
> > --- a/drivers/iio/adc/qcom-vadc-common.c
> > +++ b/drivers/iio/adc/qcom-vadc-common.c
> > @@ -229,3 +229,6 @@ int qcom_vadc_decimation_from_dt(u32 value)
> >  	return __ffs64(value / VADC_DECIMATION_MIN);
> >  }
> >  EXPORT_SYMBOL(qcom_vadc_decimation_from_dt);
> > +
> > +MODULE_LICENSE("GPL v2");
> > +MODULE_DESCRIPTION("Qualcomm ADC common functionality");  
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Linus Walleij Nov. 19, 2017, 1:27 p.m. UTC | #3
On Sun, Nov 19, 2017 at 11:31 AM, Jonathan Cameron
<jic23@jic23.retrosnub.co.uk> wrote:
> On Sat, 18 Nov 2017 15:54:48 +0000
> Jonathan Cameron <jic23@kernel.org> wrote:
>
>> On Mon, 13 Nov 2017 11:29:55 +0100
>> Linus Walleij <linus.walleij@linaro.org> wrote:
>>
>> > The module license checker complains about these two so just fix
>> > it up. They are both GPLv2, both written by me or using code
>> > I extracted while refactoring from the GPLv2 drivers.
>> >
>> > Cc: Randy Dunlap <rdunlap@infradead.org>
>> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
>> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>> Applied to the togreg branch of iio.git which will probably be be pushed
>> out as testing for the autobuilders to play with it.
> Actually - this doesn't pass basic x86_64 build testing...
> Needs to include module.h in the qcom driver.
>
> Done...

Ah dammit there is so much stuff that seems obvious in
hindsight.

Thanks for fixing it up.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/iio/accel/kxsd9-i2c.c b/drivers/iio/accel/kxsd9-i2c.c
index 98fbb628d5bd..38411e1c155b 100644
--- a/drivers/iio/accel/kxsd9-i2c.c
+++ b/drivers/iio/accel/kxsd9-i2c.c
@@ -63,3 +63,6 @@  static struct i2c_driver kxsd9_i2c_driver = {
 	.id_table	= kxsd9_i2c_id,
 };
 module_i2c_driver(kxsd9_i2c_driver);
+
+MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("KXSD9 accelerometer I2C interface");
diff --git a/drivers/iio/adc/qcom-vadc-common.c b/drivers/iio/adc/qcom-vadc-common.c
index 47d24ae5462f..d249ce643e48 100644
--- a/drivers/iio/adc/qcom-vadc-common.c
+++ b/drivers/iio/adc/qcom-vadc-common.c
@@ -229,3 +229,6 @@  int qcom_vadc_decimation_from_dt(u32 value)
 	return __ffs64(value / VADC_DECIMATION_MIN);
 }
 EXPORT_SYMBOL(qcom_vadc_decimation_from_dt);
+
+MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("Qualcomm ADC common functionality");