From patchwork Mon Nov 27 10:54:49 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 10076529 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7AA82602BD for ; Mon, 27 Nov 2017 10:55:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5746B28C27 for ; Mon, 27 Nov 2017 10:55:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4AB3628C8B; Mon, 27 Nov 2017 10:55:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D333328C27 for ; Mon, 27 Nov 2017 10:55:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752142AbdK0Kyz (ORCPT ); Mon, 27 Nov 2017 05:54:55 -0500 Received: from mail-wr0-f193.google.com ([209.85.128.193]:40018 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751738AbdK0Kyx (ORCPT ); Mon, 27 Nov 2017 05:54:53 -0500 Received: by mail-wr0-f193.google.com with SMTP id s41so20518291wrc.7 for ; Mon, 27 Nov 2017 02:54:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=P7kCW0yy9WU61hxCWMvd1bqMQzC00m+wrYwCLo+1cD4=; b=yDZQykRuuDMHGGB3AMpvRpuM/GbYPbwX2ck2JtGsOGtebVsGhkJEfLfMolrUT3v1w7 M5TQx52fI9ryrBsm2CoLbBwMLSqy1i8hRcg9sXmY8RcV4++F7u3NMI/f3fGJjN3FZphi w2831U5Fr2YptiUFtxYYYKhA24RCqWsVDmLuM0NpUIKrwTKhqIAPEKCZ/v/9OoTLdfr8 dzAAk3PoiLf+4vcAuERbaudf8HeMp74tv7sDuCUydpKwVHNPRV491AKuqJbrIaRJhuVU Qm13DfHyWWcEBdApG4PHlHZIE1M6wrSq5eml7fwAdFwW80pQK6NicqaLp4wJHDG1RpME +Sig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=P7kCW0yy9WU61hxCWMvd1bqMQzC00m+wrYwCLo+1cD4=; b=HE0HVUdd6yeZYnmhYkuQRtXHJnfNN+pKVHoAOoV1y8SHJcYxirW9LU5sk5aoOn/XXR xGFtmeAdzNXQFXLzKxo9WPtGGScYv4vxUHG/gPdexX9wMwOdNoo5LXv/jrLZrZCsKV/O l4je1KeLEVDrGcxo94dQDsPjntP7j64pJ6eE5LKmLk0gt7U8tj/n/5Q5EkVWF/tnNPML g9HHF9oBtLZjHA0vNGhh1tNx022cSWj8UjCawkEYVfVW5TOTESA23LPyiUH4J0Wk5eXI nyi/3R38mnmEXdwQjJ9Fl1E3GTuOPJTzV3HTJghX1Wmijs/s9lCxXk2aqxMuQ6dNI5Cy CZnQ== X-Gm-Message-State: AJaThX5r71bsRP8KQDFl/OkR1n5Ziueoa1u+c28B0mArEuNgv/IQ0t2B CTQA4auMdzf8zw8rdHht3MVBAw== X-Google-Smtp-Source: AGs4zMYX16DVI5gNnQpO6D3a7qoqQlVIQDMhSDXJmkthEVqEarc/zS6aI/uXMWg8dG59Yak8w5hQhA== X-Received: by 10.223.138.182 with SMTP id y51mr24917966wry.273.1511780091889; Mon, 27 Nov 2017 02:54:51 -0800 (PST) Received: from bgdev-debian.local ([90.63.244.31]) by smtp.gmail.com with ESMTPSA id g99sm45754003wrd.72.2017.11.27.02.54.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Nov 2017 02:54:51 -0800 (PST) From: Bartosz Golaszewski To: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH] iio: dummy_evgen: modify the return value check for irq_sim_init() Date: Mon, 27 Nov 2017 11:54:49 +0100 Message-Id: <20171127105449.27535-1-brgl@bgdev.pl> X-Mailer: git-send-email 2.15.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP As discussed with Marc Zyngier: irq_sim_init() and its devres variant should return the base of the allocated interrupt range on success rather than 0. This will be modified later - first, change the way users handle the return value of these routines. Signed-off-by: Bartosz Golaszewski Acked-by: Jonathan Cameron --- drivers/iio/dummy/iio_dummy_evgen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/dummy/iio_dummy_evgen.c b/drivers/iio/dummy/iio_dummy_evgen.c index fe8884543da0..efd0005f59b4 100644 --- a/drivers/iio/dummy/iio_dummy_evgen.c +++ b/drivers/iio/dummy/iio_dummy_evgen.c @@ -56,7 +56,7 @@ static int iio_dummy_evgen_create(void) return -ENOMEM; ret = irq_sim_init(&iio_evgen->irq_sim, IIO_EVENTGEN_NO); - if (ret) { + if (ret < 0) { kfree(iio_evgen); return ret; }