diff mbox

iio: srf08: fix link error "devm_iio_triggered_buffer_setup" undefined

Message ID 20180201204924.GA26839@arbeit (mailing list archive)
State New, archived
Headers show

Commit Message

Andreas Klinger Feb. 1, 2018, 8:49 p.m. UTC
Functions for triggered buffer support are needed by this module.
If they are not defined accidentally by another driver, there's an error
thrown out while linking.

Add a select of IIO_BUFFER and IIO_TRIGGERED_BUFFER in the Kconfig file.

Signed-off-by: Andreas Klinger <ak@it-klinger.de>
---
 drivers/iio/proximity/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

Comments

Jonathan Cameron Feb. 4, 2018, 11:21 a.m. UTC | #1
On Thu, 1 Feb 2018 21:49:24 +0100
Andreas Klinger <ak@it-klinger.de> wrote:

> Functions for triggered buffer support are needed by this module.
> If they are not defined accidentally by another driver, there's an error
> thrown out while linking.
> 
> Add a select of IIO_BUFFER and IIO_TRIGGERED_BUFFER in the Kconfig file.
> 
> Signed-off-by: Andreas Klinger <ak@it-klinger.de>

Applied to the fixes-togreg-post-rc1 branch of iio.git with a fixes
tag added.  Please always track down the patch that introduced the
problem and add a fixes tag.  It makes it much easier for the stable
trees to know when to apply the patch or not.

I put the patch that introduced the triggered support in the first
place as that seemed likely to be the place that the issue was
introduced.

Thanks,

Jonathan
> ---
>  drivers/iio/proximity/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/iio/proximity/Kconfig b/drivers/iio/proximity/Kconfig
> index fcb1c4ba5e41..f726f9427602 100644
> --- a/drivers/iio/proximity/Kconfig
> +++ b/drivers/iio/proximity/Kconfig
> @@ -68,6 +68,8 @@ config SX9500
>  
>  config SRF08
>  	tristate "Devantech SRF02/SRF08/SRF10 ultrasonic ranger sensor"
> +	select IIO_BUFFER
> +	select IIO_TRIGGERED_BUFFER
>  	depends on I2C
>  	help
>  	  Say Y here to build a driver for Devantech SRF02/SRF08/SRF10

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/iio/proximity/Kconfig b/drivers/iio/proximity/Kconfig
index fcb1c4ba5e41..f726f9427602 100644
--- a/drivers/iio/proximity/Kconfig
+++ b/drivers/iio/proximity/Kconfig
@@ -68,6 +68,8 @@  config SX9500
 
 config SRF08
 	tristate "Devantech SRF02/SRF08/SRF10 ultrasonic ranger sensor"
+	select IIO_BUFFER
+	select IIO_TRIGGERED_BUFFER
 	depends on I2C
 	help
 	  Say Y here to build a driver for Devantech SRF02/SRF08/SRF10