| Message ID | 20180215175220.2691-5-ckeepax@opensource.cirrus.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Feb 15, 2018 at 05:52:20PM +0000, Charles Keepax wrote: > Since the handling for max_raw_read is now inside regmap_raw_read there > should be no need for client drivers to query as max_raw_read. No, they might need to know if things are going to be combined into a single transaction - some devices have weird sensitivities about bulk I/O and so the driver may need to know exactly what's going on when it interacts with the device.
On Fri, Feb 16, 2018 at 12:03:11PM +0000, Mark Brown wrote: > On Thu, Feb 15, 2018 at 05:52:20PM +0000, Charles Keepax wrote: > > Since the handling for max_raw_read is now inside regmap_raw_read there > > should be no need for client drivers to query as max_raw_read. > > No, they might need to know if things are going to be combined into a > single transaction - some devices have weird sensitivities about bulk > I/O and so the driver may need to know exactly what's going on when it > interacts with the device. True, no objections from me for dropping this one from the chain. Thanks, Charles -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c index 872be065e3fe..a7ee885fce89 100644 --- a/drivers/base/regmap/regmap.c +++ b/drivers/base/regmap/regmap.c @@ -1641,17 +1641,6 @@ bool regmap_can_raw_write(struct regmap *map) EXPORT_SYMBOL_GPL(regmap_can_raw_write); /** - * regmap_get_raw_read_max - Get the maximum size we can read - * - * @map: Map to check. - */ -size_t regmap_get_raw_read_max(struct regmap *map) -{ - return map->max_raw_read; -} -EXPORT_SYMBOL_GPL(regmap_get_raw_read_max); - -/** * regmap_get_raw_write_max - Get the maximum size we can read * * @map: Map to check. diff --git a/include/linux/regmap.h b/include/linux/regmap.h index 6a3aeba40e9e..0382fb787c10 100644 --- a/include/linux/regmap.h +++ b/include/linux/regmap.h @@ -936,7 +936,6 @@ int regmap_get_max_register(struct regmap *map); int regmap_get_reg_stride(struct regmap *map); int regmap_async_complete(struct regmap *map); bool regmap_can_raw_write(struct regmap *map); -size_t regmap_get_raw_read_max(struct regmap *map); size_t regmap_get_raw_write_max(struct regmap *map); int regcache_sync(struct regmap *map);
Since the handling for max_raw_read is now inside regmap_raw_read there should be no need for client drivers to query as max_raw_read. Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com> --- drivers/base/regmap/regmap.c | 11 ----------- include/linux/regmap.h | 1 - 2 files changed, 12 deletions(-)