| Message ID | 20180216133841.3yt4ip3tbck7ihdm@smtp.gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Rodrigo, Mostly looking good. Few comments. Please read: https://chris.beams.io/posts/git-commit/ 1) Capitalize the first letter of commit 2) Use prefix tags to indicate the driver that is changed. Here iio:pressure:ms5611. If not sure what prefix tags to use please use git log file.c and see the tags used by previous commits. If not clear from previous commits be creative! :) 3) A better verb describing the change would be Fix instead of Apply. So, the commit subject should be: iio:pressure:ms5611: Fix coding style in probe function 4) Please correct all the occurences of the same coding style error (not sure if here is the case). Other than that it looks good to me. Please send v2. Do not forget to add under the scissor line of the new patch a small changelog documenting what has changed since v1. On Vi, 2018-02-16 at 11:38 -0200, rodrigosiqueira wrote: > This patch fixes the checkpatch.pl warning and error: > > iio/pressure/ms5611.h:66: ERROR: code indent should use tabs where possible > iio/pressure/ms5611.h:66: WARNING: please, no spaces at the start of a line > iio/pressure/ms5611.h:66: ERROR: "foo* bar" should be "foo *bar" > > Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com> > --- > ^ this is the scissor line. thanks, Daniel.
diff --git a/drivers/iio/pressure/ms5611.h b/drivers/iio/pressure/ms5611.h index ccda63c5b3c3..ead9e9f85894 100644 --- a/drivers/iio/pressure/ms5611.h +++ b/drivers/iio/pressure/ms5611.h @@ -63,7 +63,7 @@ struct ms5611_state { }; int ms5611_probe(struct iio_dev *indio_dev, struct device *dev, - const char* name, int type); + const char *name, int type); int ms5611_remove(struct iio_dev *indio_dev); #endif /* _MS5611_H */
This patch fixes the checkpatch.pl warning and error: iio/pressure/ms5611.h:66: ERROR: code indent should use tabs where possible iio/pressure/ms5611.h:66: WARNING: please, no spaces at the start of a line iio/pressure/ms5611.h:66: ERROR: "foo* bar" should be "foo *bar" Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com> --- drivers/iio/pressure/ms5611.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)