| Message ID | 20180703193550.GA12565@embeddedor.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, 3 Jul 2018 14:35:50 -0500 "Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to hopefully ignore! Thanks, Jonathan > --- > drivers/iio/imu/adis.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/iio/imu/adis.c b/drivers/iio/imu/adis.c > index ad6f91d..c771ae6 100644 > --- a/drivers/iio/imu/adis.c > +++ b/drivers/iio/imu/adis.c > @@ -81,9 +81,11 @@ int adis_write_reg(struct adis *adis, unsigned int reg, > adis->tx[9] = (value >> 24) & 0xff; > adis->tx[6] = ADIS_WRITE_REG(reg + 2); > adis->tx[7] = (value >> 16) & 0xff; > + /* fall through */ > case 2: > adis->tx[4] = ADIS_WRITE_REG(reg + 1); > adis->tx[5] = (value >> 8) & 0xff; > + /* fall through */ > case 1: > adis->tx[2] = ADIS_WRITE_REG(reg); > adis->tx[3] = value & 0xff; > @@ -167,6 +169,7 @@ int adis_read_reg(struct adis *adis, unsigned int reg, > adis->tx[2] = ADIS_READ_REG(reg + 2); > adis->tx[3] = 0; > spi_message_add_tail(&xfers[1], &msg); > + /* fall through */ > case 2: > adis->tx[4] = ADIS_READ_REG(reg); > adis->tx[5] = 0; -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/iio/imu/adis.c b/drivers/iio/imu/adis.c index ad6f91d..c771ae6 100644 --- a/drivers/iio/imu/adis.c +++ b/drivers/iio/imu/adis.c @@ -81,9 +81,11 @@ int adis_write_reg(struct adis *adis, unsigned int reg, adis->tx[9] = (value >> 24) & 0xff; adis->tx[6] = ADIS_WRITE_REG(reg + 2); adis->tx[7] = (value >> 16) & 0xff; + /* fall through */ case 2: adis->tx[4] = ADIS_WRITE_REG(reg + 1); adis->tx[5] = (value >> 8) & 0xff; + /* fall through */ case 1: adis->tx[2] = ADIS_WRITE_REG(reg); adis->tx[3] = value & 0xff; @@ -167,6 +169,7 @@ int adis_read_reg(struct adis *adis, unsigned int reg, adis->tx[2] = ADIS_READ_REG(reg + 2); adis->tx[3] = 0; spi_message_add_tail(&xfers[1], &msg); + /* fall through */ case 2: adis->tx[4] = ADIS_READ_REG(reg); adis->tx[5] = 0;
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- drivers/iio/imu/adis.c | 3 +++ 1 file changed, 3 insertions(+)