From patchwork Sat Nov 24 00:23:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matheus Tavares X-Patchwork-Id: 10696403 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7728E18F0 for ; Sat, 24 Nov 2018 00:24:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 639D62B437 for ; Sat, 24 Nov 2018 00:24:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 577C82B533; Sat, 24 Nov 2018 00:24:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 001B32B61B for ; Sat, 24 Nov 2018 00:24:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728237AbeKXLJ4 (ORCPT ); Sat, 24 Nov 2018 06:09:56 -0500 Received: from mail-qt1-f194.google.com ([209.85.160.194]:34487 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728113AbeKXLJz (ORCPT ); Sat, 24 Nov 2018 06:09:55 -0500 Received: by mail-qt1-f194.google.com with SMTP id r14so12058311qtp.1 for ; Fri, 23 Nov 2018 16:23:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp-br.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=tOOlqhy2AphJebMrYDfu86cZkqn1w0YS2gGgHkzViLk=; b=g0U7GZclXUOqW7mvYgsZHsMNYEIQ1ZafkH0Q+ARZK73WrklH1ISHr88GzSrhtATQMC Rf0/utEqi9bvTokxwWe7l4OJMk2iCzNHjmzrqMfIVeaWyrKpdvJgHLPJFiFcsaUwCLsW 4m1eVcPtQGRfNvhxen3UpI9QjaQN2ucmIhd4plC9L/fBq5B6kjz9zmMpF3rapf+ClnsI aX+ywFxtaSfqPUb6f2Q9lyofP1QIG9TpE1DZhnlOHWMfvVa1VqSUUsDF606q3mrJ+aCP zcezmL0a/kCkIrH8PiXNFfH5sBT8EYgCj07P/198z6VKySH1RwdbTHx1W13D9f/ysQeK wu6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=tOOlqhy2AphJebMrYDfu86cZkqn1w0YS2gGgHkzViLk=; b=XG0IhhNocDuqGiGkrI9UsTlgJTKPiyG7UAgzzZEZ8NNeTLjkO+HhSGO0/PrqMo02lS vDRzdCkjRLDTLSFFsH4TP05P+JfkFUehkXvexTVtAS1rMnv2quP4wO4zW6H1kOsUpc/s l8lLOUbIBMuC73bEObtJoUNIwyaz7y+13aPTz4Dboxs18d9koqOhDtuUcF+oTGQ9YTcd LbAN2YN2colslcar/INRKdEmKICptJO8bvew4SWy7j2bTM6ezkn6uKSvgFktDYKQ/jAR wuk6wp5DWrfHsbKDP0MbxQEpKN7XprJ2EeAX3e2KddhUxXbOQvlnslZ5HnVyk02QFEs4 e8iQ== X-Gm-Message-State: AGRZ1gIHghawDq4wV5186aPaYUh1TU2uSc/6YYjP8A6qsv2llVHPWZdP meakTRpgy2FIwzvYDsPrDlSVBw== X-Google-Smtp-Source: AJdET5cNOEZaS6/L6rKjr4v4S3gvm4Ryak5tj2FrLj0sDjIf3jgOTm/VIrfXNbhPJXu1WmI87eQVog== X-Received: by 2002:aed:314b:: with SMTP id 69mr17063702qtg.247.1543019014627; Fri, 23 Nov 2018 16:23:34 -0800 (PST) Received: from mango.spo.virtua.com.br ([2804:14c:81:942d::3]) by smtp.gmail.com with ESMTPSA id o34sm26707515qte.4.2018.11.23.16.23.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Nov 2018 16:23:34 -0800 (PST) From: Matheus Tavares To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman , Rob Herring , Mark Rutland Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Alexandru Ardelean , kernel-usp@googlegroups.com, victorcolombo@gmail.com Subject: [PATCH v3 2/7] staging:iio:ad2s90: Remove spi setup that should be done via dt Date: Fri, 23 Nov 2018 22:23:07 -0200 Message-Id: <20181124002312.6923-3-matheus.bernardino@usp.br> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20181124002312.6923-1-matheus.bernardino@usp.br> References: <20181124002312.6923-1-matheus.bernardino@usp.br> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The ad2s90 driver currently sets some spi settings (max_speed_hz and mode) at ad2s90_probe. Since the maximum frequency is a required element in DT binding for spi slave devices and because the spi mode for the device can be either (0,0) or (1,1), these settings should be handled via device tree, not in the driver's code. This patch removes them from the probe function. Note: The way in which the mentioned spi settings need to be specified on the ad2s90's node of a device tree will be documented in the future patch "dt-bindings:iio:resolver: Add docs for ad2s90". Signed-off-by: Matheus Tavares --- Changes in v3: - none Changes in v2: - Rewritten patch message to better explain why the code snippet in question should be removed. drivers/staging/iio/resolver/ad2s90.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/iio/resolver/ad2s90.c index fdae067ed866..abb9b9147ee6 100644 --- a/drivers/staging/iio/resolver/ad2s90.c +++ b/drivers/staging/iio/resolver/ad2s90.c @@ -77,7 +77,6 @@ static int ad2s90_probe(struct spi_device *spi) { struct iio_dev *indio_dev; struct ad2s90_state *st; - int ret; indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st)); if (!indio_dev) @@ -94,16 +93,6 @@ static int ad2s90_probe(struct spi_device *spi) indio_dev->num_channels = 1; indio_dev->name = spi_get_device_id(spi)->name; - /* need 600ns between CS and the first falling edge of SCLK */ - spi->max_speed_hz = 830000; - spi->mode = SPI_MODE_3; - ret = spi_setup(spi); - - if (ret < 0) { - dev_err(&spi->dev, "spi_setup failed!\n"); - return ret; - } - return devm_iio_device_register(indio_dev->dev.parent, indio_dev); }