| Message ID | 20190410182351.18352-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [next] iio: temperature: max31856: fix uninitialized error return | expand |
On Wed, 10 Apr 2019 19:23:51 +0100 Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > Currently if mask is neither CHAN_INFO_RAW or CHAN_INFO_SCALE then > then an uninitialized error return 'ret' is returned. Fix this by > adding a default case that ensures -EINVAL is returned for this > specific case. > > Addresses-Coverity: ("Uninitialized scalar variable") > Signed-off-by: Colin Ian King <colin.king@canonical.com> Thanks Colin, Dan / smatch caught this one as well, but as you sent a patch yours gets applied. Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/iio/temperature/max31856.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/iio/temperature/max31856.c b/drivers/iio/temperature/max31856.c > index 6b67d6b95cf9..f184ba5601d9 100644 > --- a/drivers/iio/temperature/max31856.c > +++ b/drivers/iio/temperature/max31856.c > @@ -210,6 +210,9 @@ static int max31856_read_raw(struct iio_dev *indio_dev, > return IIO_VAL_INT_PLUS_MICRO; > } > break; > + default: > + ret = -EINVAL; > + break; > } > > return ret;
diff --git a/drivers/iio/temperature/max31856.c b/drivers/iio/temperature/max31856.c index 6b67d6b95cf9..f184ba5601d9 100644 --- a/drivers/iio/temperature/max31856.c +++ b/drivers/iio/temperature/max31856.c @@ -210,6 +210,9 @@ static int max31856_read_raw(struct iio_dev *indio_dev, return IIO_VAL_INT_PLUS_MICRO; } break; + default: + ret = -EINVAL; + break; } return ret;