| Message ID | 20190518222733.2ttcgvy7fct4awra@smtp.gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | staging: iio: ad7746: add device tree support | expand |
On Sat, 18 May 2019 19:27:33 -0300 João Seckler <joaoseckler@gmail.com> wrote: > Add a of_device_id struct variable and subsequent call to > MODULE_DEVICE_TABLE macro to support device tree. > > Signed-off-by: João Seckler <joaoseckler@gmail.com> > Signed-off-by: Lucas Oshiro <lucasseikioshiro@gmail.com> > Co-developed-by: Lucas Oshiro <lucasseikioshiro@gmail.com> Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. For a future improvement, try to explain the 'why' rather than 'what' of a patch in the description. This particular change is so common I don't mind that much, but it is a good habit to get into! Thanks, Jonathan > --- > drivers/staging/iio/cdc/ad7746.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c > index 47610d863908..21527d84f940 100644 > --- a/drivers/staging/iio/cdc/ad7746.c > +++ b/drivers/staging/iio/cdc/ad7746.c > @@ -748,9 +748,19 @@ static const struct i2c_device_id ad7746_id[] = { > > MODULE_DEVICE_TABLE(i2c, ad7746_id); > > +static const struct of_device_id ad7746_of_match[] = { > + { .compatible = "adi,ad7745" }, > + { .compatible = "adi,ad7746" }, > + { .compatible = "adi,ad7747" }, > + { }, > +}; > + > +MODULE_DEVICE_TABLE(of, ad7746_of_match); > + > static struct i2c_driver ad7746_driver = { > .driver = { > .name = KBUILD_MODNAME, > + .of_match_table = ad7746_of_match, > }, > .probe = ad7746_probe, > .id_table = ad7746_id,
On Sun, 19 May 2019 12:02:50 +0100 Jonathan Cameron <jic23@kernel.org> wrote: > On Sat, 18 May 2019 19:27:33 -0300 > João Seckler <joaoseckler@gmail.com> wrote: > > > Add a of_device_id struct variable and subsequent call to > > MODULE_DEVICE_TABLE macro to support device tree. > > > > Signed-off-by: João Seckler <joaoseckler@gmail.com> > > Signed-off-by: Lucas Oshiro <lucasseikioshiro@gmail.com> > > Co-developed-by: Lucas Oshiro <lucasseikioshiro@gmail.com> > Applied to the togreg branch of iio.git and pushed out as testing > for the autobuilders to play with it. > > For a future improvement, try to explain the 'why' rather than > 'what' of a patch in the description. This particular change > is so common I don't mind that much, but it is a good habit to > get into! Ah, you do say to support device tree at the end, but more detail on that would have been good! Thanks, J > > Thanks, > > Jonathan > > --- > > drivers/staging/iio/cdc/ad7746.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c > > index 47610d863908..21527d84f940 100644 > > --- a/drivers/staging/iio/cdc/ad7746.c > > +++ b/drivers/staging/iio/cdc/ad7746.c > > @@ -748,9 +748,19 @@ static const struct i2c_device_id ad7746_id[] = { > > > > MODULE_DEVICE_TABLE(i2c, ad7746_id); > > > > +static const struct of_device_id ad7746_of_match[] = { > > + { .compatible = "adi,ad7745" }, > > + { .compatible = "adi,ad7746" }, > > + { .compatible = "adi,ad7747" }, > > + { }, > > +}; > > + > > +MODULE_DEVICE_TABLE(of, ad7746_of_match); > > + > > static struct i2c_driver ad7746_driver = { > > .driver = { > > .name = KBUILD_MODNAME, > > + .of_match_table = ad7746_of_match, > > }, > > .probe = ad7746_probe, > > .id_table = ad7746_id, >
diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c index 47610d863908..21527d84f940 100644 --- a/drivers/staging/iio/cdc/ad7746.c +++ b/drivers/staging/iio/cdc/ad7746.c @@ -748,9 +748,19 @@ static const struct i2c_device_id ad7746_id[] = { MODULE_DEVICE_TABLE(i2c, ad7746_id); +static const struct of_device_id ad7746_of_match[] = { + { .compatible = "adi,ad7745" }, + { .compatible = "adi,ad7746" }, + { .compatible = "adi,ad7747" }, + { }, +}; + +MODULE_DEVICE_TABLE(of, ad7746_of_match); + static struct i2c_driver ad7746_driver = { .driver = { .name = KBUILD_MODNAME, + .of_match_table = ad7746_of_match, }, .probe = ad7746_probe, .id_table = ad7746_id,