| Message ID | 20190606014246.1850-1-festevam@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | staging: iio: adt7316: Fix build errors when GPIOLIB is not set | expand |
G'day Fabio, On 6/06/2019 09:42, Fabio Estevam wrote: > On x86_64 when GPIOLIB is not set the following build errors > are seen: > > drivers/staging/iio/addac/adt7316.c:947:3: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration] > drivers/staging/iio/addac/adt7316.c:1805:2: error: implicit declaration of function 'irqd_get_trigger_type' [-Werror=implicit-function-declaration] > > These functions are provided by the <linux/gpio/consumer.h> > and <linux/irq.h> headers, so include them to fix these > build errors. > > Reported-by: Randy Dunlap <rdunlap@infradead.org> > Signed-off-by: Fabio Estevam <festevam@gmail.com> > --- > drivers/staging/iio/addac/adt7316.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c > index 37ce563cb0e1..5470a9c3f872 100644 > --- a/drivers/staging/iio/addac/adt7316.c > +++ b/drivers/staging/iio/addac/adt7316.c > @@ -7,6 +7,8 @@ > > #include <linux/interrupt.h> > #include <linux/gpio.h> This should be removed as well. See comment at top of linux/gpio.h > +#include <linux/gpio/consumer.h> > +#include <linux/irq.h> > #include <linux/workqueue.h> > #include <linux/device.h> > #include <linux/kernel.h> >
Hi Phil, On Wed, Jun 5, 2019 at 10:59 PM Phil Reid <preid@electromag.com.au> wrote: > > #include <linux/gpio.h> > This should be removed as well. > See comment at top of linux/gpio.h Good catch! Just sent a v2. Thanks
diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c index 37ce563cb0e1..5470a9c3f872 100644 --- a/drivers/staging/iio/addac/adt7316.c +++ b/drivers/staging/iio/addac/adt7316.c @@ -7,6 +7,8 @@ #include <linux/interrupt.h> #include <linux/gpio.h> +#include <linux/gpio/consumer.h> +#include <linux/irq.h> #include <linux/workqueue.h> #include <linux/device.h> #include <linux/kernel.h>
On x86_64 when GPIOLIB is not set the following build errors are seen: drivers/staging/iio/addac/adt7316.c:947:3: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration] drivers/staging/iio/addac/adt7316.c:1805:2: error: implicit declaration of function 'irqd_get_trigger_type' [-Werror=implicit-function-declaration] These functions are provided by the <linux/gpio/consumer.h> and <linux/irq.h> headers, so include them to fix these build errors. Reported-by: Randy Dunlap <rdunlap@infradead.org> Signed-off-by: Fabio Estevam <festevam@gmail.com> --- drivers/staging/iio/addac/adt7316.c | 2 ++ 1 file changed, 2 insertions(+)