| Message ID | 20190617110951.2085648-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Staging: iio: adt7316: use correct headers for gpio | expand |
On Mon, 17 Jun 2019 13:09:20 +0200 Arnd Bergmann <arnd@arndb.de> wrote: > When building without CONFIG_GPIOLIB, we get a compile-time failure: > > drivers/staging/iio/addac/adt7316.c:947:3: error: implicit declaration of function 'gpiod_set_value' [-Werror,-Wimplicit-function-declaration] > gpiod_set_value(chip->ldac_pin, 0); > ^ > drivers/staging/iio/addac/adt7316.c:947:3: note: did you mean 'gpio_set_value'? > include/linux/gpio.h:169:20: note: 'gpio_set_value' declared here > static inline void gpio_set_value(unsigned gpio, int value) > ^ > drivers/staging/iio/addac/adt7316.c:947:3: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] > gpiod_set_value(chip->ldac_pin, 0); > ^ > drivers/staging/iio/addac/adt7316.c:1805:13: error: implicit declaration of function 'irqd_get_trigger_type' [-Werror,-Wimplicit-function-declaration] > irq_type = irqd_get_trigger_type(irq_get_irq_data(chip->bus.irq)); > > Include the correct headers that contain the declarations for these > functions. > > Fixes: c63460c4298f ("Staging: iio: adt7316: Use device tree data to set ldac_pin") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Sorry, this is me being exceedingly slow on getting the fix upstream. I've just sent a pull request for the fix I've had queued up for a few weeks. Jonathan > --- > drivers/staging/iio/addac/adt7316.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c > index 37ce563cb0e1..9cb3d0e42c38 100644 > --- a/drivers/staging/iio/addac/adt7316.c > +++ b/drivers/staging/iio/addac/adt7316.c > @@ -6,7 +6,8 @@ > */ > > #include <linux/interrupt.h> > -#include <linux/gpio.h> > +#include <linux/gpio/consumer.h> > +#include <linux/irq.h> > #include <linux/workqueue.h> > #include <linux/device.h> > #include <linux/kernel.h>
diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c index 37ce563cb0e1..9cb3d0e42c38 100644 --- a/drivers/staging/iio/addac/adt7316.c +++ b/drivers/staging/iio/addac/adt7316.c @@ -6,7 +6,8 @@ */ #include <linux/interrupt.h> -#include <linux/gpio.h> +#include <linux/gpio/consumer.h> +#include <linux/irq.h> #include <linux/workqueue.h> #include <linux/device.h> #include <linux/kernel.h>
When building without CONFIG_GPIOLIB, we get a compile-time failure: drivers/staging/iio/addac/adt7316.c:947:3: error: implicit declaration of function 'gpiod_set_value' [-Werror,-Wimplicit-function-declaration] gpiod_set_value(chip->ldac_pin, 0); ^ drivers/staging/iio/addac/adt7316.c:947:3: note: did you mean 'gpio_set_value'? include/linux/gpio.h:169:20: note: 'gpio_set_value' declared here static inline void gpio_set_value(unsigned gpio, int value) ^ drivers/staging/iio/addac/adt7316.c:947:3: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] gpiod_set_value(chip->ldac_pin, 0); ^ drivers/staging/iio/addac/adt7316.c:1805:13: error: implicit declaration of function 'irqd_get_trigger_type' [-Werror,-Wimplicit-function-declaration] irq_type = irqd_get_trigger_type(irq_get_irq_data(chip->bus.irq)); Include the correct headers that contain the declarations for these functions. Fixes: c63460c4298f ("Staging: iio: adt7316: Use device tree data to set ldac_pin") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/staging/iio/addac/adt7316.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)