From patchwork Wed Aug 21 15:50:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 11107439 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 158CC14DE for ; Wed, 21 Aug 2019 15:57:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E746A2339E for ; Wed, 21 Aug 2019 15:57:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727205AbfHUP5c (ORCPT ); Wed, 21 Aug 2019 11:57:32 -0400 Received: from ox4u.de ([212.118.221.216]:36225 "EHLO s1.ox4u.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726828AbfHUP5c (ORCPT ); Wed, 21 Aug 2019 11:57:32 -0400 X-Greylist: delayed 424 seconds by postgrey-1.27 at vger.kernel.org; Wed, 21 Aug 2019 11:57:32 EDT Received: by s1.ox4u.de (Postfix, from userid 65534) id A8754260130; Wed, 21 Aug 2019 17:50:27 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on s1.ox4u.de X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=disabled version=3.4.1 Received: from ws-140106.systec.local (unknown [212.185.67.146]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by s1.ox4u.de (Postfix) with ESMTPSA id 12026260114; Wed, 21 Aug 2019 17:50:27 +0200 (CEST) From: Alexander Stein To: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler Cc: Alexander Stein , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/1] iio: core: Fix fractional format generation Date: Wed, 21 Aug 2019 17:50:23 +0200 Message-Id: <20190821155023.6333-1-alexander.stein@systec-electronic.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org In case the result is -0.3252 tmp0 is 0 after the div_s64_rem, so tmp0 is non-negative which results in an output of 0.3252. Fix this by explicitly handling the negative sign ourselves. Signed-off-by: Alexander Stein --- drivers/iio/industrialio-core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c index 245b5844028d..18350c1959ae 100644 --- a/drivers/iio/industrialio-core.c +++ b/drivers/iio/industrialio-core.c @@ -568,6 +568,7 @@ static ssize_t __iio_format_value(char *buf, size_t len, unsigned int type, { unsigned long long tmp; int tmp0, tmp1; + const char *sign = vals[0] < 0 ? "-" : ""; bool scale_db = false; switch (type) { @@ -593,11 +594,11 @@ static ssize_t __iio_format_value(char *buf, size_t len, unsigned int type, tmp = div_s64((s64)vals[0] * 1000000000LL, vals[1]); tmp1 = vals[1]; tmp0 = (int)div_s64_rem(tmp, 1000000000, &tmp1); - return snprintf(buf, len, "%d.%09u", tmp0, abs(tmp1)); + return snprintf(buf, len, "%s%u.%09u", sign, abs(tmp0), abs(tmp1)); case IIO_VAL_FRACTIONAL_LOG2: tmp = shift_right((s64)vals[0] * 1000000000LL, vals[1]); tmp0 = (int)div_s64_rem(tmp, 1000000000LL, &tmp1); - return snprintf(buf, len, "%d.%09u", tmp0, abs(tmp1)); + return snprintf(buf, len, "%s%u.%09u", sign, abs(tmp0), abs(tmp1)); case IIO_VAL_INT_MULTIPLE: { int i;