From patchwork Thu Aug 22 14:52:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 11109531 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 24B79112C for ; Thu, 22 Aug 2019 14:52:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ED90623402 for ; Thu, 22 Aug 2019 14:52:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="or9rU5G/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732412AbfHVOwo (ORCPT ); Thu, 22 Aug 2019 10:52:44 -0400 Received: from mail-lf1-f65.google.com ([209.85.167.65]:43913 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731958AbfHVOwo (ORCPT ); Thu, 22 Aug 2019 10:52:44 -0400 Received: by mail-lf1-f65.google.com with SMTP id c19so4735512lfm.10 for ; Thu, 22 Aug 2019 07:52:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Uq/FBcnY++ZGKx98yifV3HfVEE2WnazvIb45Cz5nZfg=; b=or9rU5G/s7a/M+/RkT8z8updGN4eI4GbLR0eIPQHXDv13JyM/ilyXvH6OqgXnkLOz+ HmYSH8wy9Y4Z71gFMOjhu9gGStwH0OIlioRKbD1FBMVXHFaAlj75ydjlA7xOlhNEUbbz sHwK6mfmRvmfU8t7rUxyhBFs1AUBvF+dypXz6Gn9EvymKjdbLHwdkEd7pJaDUgsgjol4 0OEfo6PdJxqZwDKDoTEYZfdj+OYq/0Uq3s8uCT+xpvSgNN9TwJdYATinxrrLoK5pX6+y SDN5Ms0ORB6zOI8uTE5zkJ/azAHNBt1yvGNaJtIlM6VBwcjYQBhQIPZamuY+41SGpmlb un3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Uq/FBcnY++ZGKx98yifV3HfVEE2WnazvIb45Cz5nZfg=; b=sF7P1IvfHcjVs/Jgwc3AoYk/DecthZ9H3cF0hxpx2w1htgF5tWkQKO2oGZiPaH9dxM 9gJGA5jVyfYeVahvENBPfQRuQLODfGUkBLTRzVfEb8xTi8szXXgUBMg4eLdzPIEKSJlm zXiTIJp6JBSJYVMPaONfs/q0CSaolbSUhi+zO455OYi5rMA0FyuWYEhuwRpXESMonjWH QQVxHwlq7+OZGRHsqrPIiG3YQ14vohQaUNi9eGS+RoAYG16zBcEgrHfAA4epCmwbmpvO ItcGqr3wok0ACUmdZ+75PpoWFtbWDm4sKxfqiucIQxnwWJBu1WLlhXZIETCHojOuy4g3 m+ZQ== X-Gm-Message-State: APjAAAXUn0vI4I+RnDWv9djtK6fa9fkoDuZbQ8N1IfYpCZW6DgvKpHK9 21+UIMdR7aNgqHiIlIObt17pqg== X-Google-Smtp-Source: APXvYqyW39nIgrQfYlAYocj6Rne1ZFIDWujNdIaiVsrhvbtR92DwR9075/OFcn8Uj5EQhpHVSNt+zA== X-Received: by 2002:ac2:428d:: with SMTP id m13mr21576276lfh.52.1566485560052; Thu, 22 Aug 2019 07:52:40 -0700 (PDT) Received: from genomnajs.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id s3sm3959374ljj.85.2019.08.22.07.52.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Aug 2019 07:52:38 -0700 (PDT) From: Linus Walleij To: Lee Jones , Jonathan Cameron , linux-iio@vger.kernel.org, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler Cc: Mboumba Cedric Madianga , Linus Walleij , Sebastian Reichel Subject: [PATCH 1/8 v2] power: supply: ab8500_btemp: convert to IIO ADC Date: Thu, 22 Aug 2019 16:52:26 +0200 Message-Id: <20190822145233.18222-2-linus.walleij@linaro.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190822145233.18222-1-linus.walleij@linaro.org> References: <20190822145233.18222-1-linus.walleij@linaro.org> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org This switches the AB8500 battery temperature driver to using the standard IIO ADC channel lookup and conversion routines. Acked-by: Sebastian Reichel Acked-by: Jonathan Cameron Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Collected ACKs. - Add a Kconfig dependency on IIO - Fixed some whitespace issues - Rebased on v5.3-rc5 This will be applied along with the other changes in ARM SoC and should not be applied to the power tree right now. --- drivers/power/supply/Kconfig | 2 +- drivers/power/supply/ab8500_btemp.c | 41 ++++++++++++++++++++--------- 2 files changed, 30 insertions(+), 13 deletions(-) diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig index 5d91b5160b41..758fabff2b1d 100644 --- a/drivers/power/supply/Kconfig +++ b/drivers/power/supply/Kconfig @@ -640,7 +640,7 @@ config BATTERY_GAUGE_LTC2941 config AB8500_BM bool "AB8500 Battery Management Driver" - depends on AB8500_CORE && AB8500_GPADC + depends on AB8500_CORE && AB8500_GPADC && IIO help Say Y to include support for AB8500 battery management. diff --git a/drivers/power/supply/ab8500_btemp.c b/drivers/power/supply/ab8500_btemp.c index 8fe81259bfd9..ad8c51ef8b8b 100644 --- a/drivers/power/supply/ab8500_btemp.c +++ b/drivers/power/supply/ab8500_btemp.c @@ -26,7 +26,7 @@ #include #include #include -#include +#include #define VTVOUT_V 1800 @@ -79,7 +79,8 @@ struct ab8500_btemp_ranges { * @bat_temp: Dispatched battery temperature in degree Celsius * @prev_bat_temp Last measured battery temperature in degree Celsius * @parent: Pointer to the struct ab8500 - * @gpadc: Pointer to the struct gpadc + * @adc_btemp_ball: ADC channel for the battery ball temperature + * @adc_bat_ctrl: ADC channel for the battery control * @fg: Pointer to the struct fg * @bm: Platform specific battery management information * @btemp_psy: Structure for BTEMP specific battery properties @@ -96,7 +97,8 @@ struct ab8500_btemp { int bat_temp; int prev_bat_temp; struct ab8500 *parent; - struct ab8500_gpadc *gpadc; + struct iio_channel *btemp_ball; + struct iio_channel *bat_ctrl; struct ab8500_fg *fg; struct abx500_bm_data *bm; struct power_supply *btemp_psy; @@ -177,13 +179,13 @@ static int ab8500_btemp_batctrl_volt_to_res(struct ab8500_btemp *di, */ static int ab8500_btemp_read_batctrl_voltage(struct ab8500_btemp *di) { - int vbtemp; + int vbtemp, ret; static int prev; - vbtemp = ab8500_gpadc_convert(di->gpadc, BAT_CTRL); - if (vbtemp < 0) { + ret = iio_read_channel_processed(di->bat_ctrl, &vbtemp); + if (ret < 0) { dev_err(di->dev, - "%s gpadc conversion failed, using previous value", + "%s ADC conversion failed, using previous value", __func__); return prev; } @@ -455,7 +457,7 @@ static int ab8500_btemp_res_to_temp(struct ab8500_btemp *di, */ static int ab8500_btemp_measure_temp(struct ab8500_btemp *di) { - int temp; + int temp, ret; static int prev; int rbat, rntc, vntc; u8 id; @@ -480,10 +482,10 @@ static int ab8500_btemp_measure_temp(struct ab8500_btemp *di) di->bm->bat_type[id].r_to_t_tbl, di->bm->bat_type[id].n_temp_tbl_elements, rbat); } else { - vntc = ab8500_gpadc_convert(di->gpadc, BTEMP_BALL); - if (vntc < 0) { + ret = iio_read_channel_processed(di->btemp_ball, &vntc); + if (ret < 0) { dev_err(di->dev, - "%s gpadc conversion failed," + "%s ADC conversion failed," " using previous value\n", __func__); return prev; } @@ -1024,7 +1026,22 @@ static int ab8500_btemp_probe(struct platform_device *pdev) /* get parent data */ di->dev = &pdev->dev; di->parent = dev_get_drvdata(pdev->dev.parent); - di->gpadc = ab8500_gpadc_get("ab8500-gpadc.0"); + + /* Get ADC channels */ + di->btemp_ball = devm_iio_channel_get(&pdev->dev, "btemp_ball"); + if (IS_ERR(di->btemp_ball)) { + if (PTR_ERR(di->btemp_ball) == -ENODEV) + return -EPROBE_DEFER; + dev_err(&pdev->dev, "failed to get BTEMP BALL ADC channel\n"); + return PTR_ERR(di->btemp_ball); + } + di->bat_ctrl = devm_iio_channel_get(&pdev->dev, "bat_ctrl"); + if (IS_ERR(di->bat_ctrl)) { + if (PTR_ERR(di->bat_ctrl) == -ENODEV) + return -EPROBE_DEFER; + dev_err(&pdev->dev, "failed to get BAT CTRL ADC channel\n"); + return PTR_ERR(di->bat_ctrl); + } di->initialized = false;