| Message ID | 20190922175021.53449-6-gwendal@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | cros_ec: Add sensorhub driver and FIFO processing | expand |
Hi Gwendal and Enrico On 22/9/19 19:50, Gwendal Grignou wrote: > From: Enrico Granata <egranata@chromium.org> > > Add a layer of sanity checking to cros_ec_register against attempting to > register IRQ values that are not strictly greater than 0. > > Signed-off-by: Enrico Granata <egranata@google.com> I'll get rid of this signed-off as is the same as following > Signed-off-by: Enrico Granata <egranata@chromium.org> > Signed-off-by: Gwendal Grignou <gwendal@chromium.org> For my own reference: Reviewed-for-chrome-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > --- > drivers/platform/chrome/cros_ec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/chrome/cros_ec.c b/drivers/platform/chrome/cros_ec.c > index f49eb1d1e3cd..9c8dc7cdb2b7 100644 > --- a/drivers/platform/chrome/cros_ec.c > +++ b/drivers/platform/chrome/cros_ec.c > @@ -146,7 +146,7 @@ int cros_ec_register(struct cros_ec_device *ec_dev) > return err; > } > > - if (ec_dev->irq) { > + if (ec_dev->irq > 0) { > err = devm_request_threaded_irq( > dev, ec_dev->irq, ec_irq_handler, > ec_irq_thread, IRQF_TRIGGER_LOW | IRQF_ONESHOT, >
diff --git a/drivers/platform/chrome/cros_ec.c b/drivers/platform/chrome/cros_ec.c index f49eb1d1e3cd..9c8dc7cdb2b7 100644 --- a/drivers/platform/chrome/cros_ec.c +++ b/drivers/platform/chrome/cros_ec.c @@ -146,7 +146,7 @@ int cros_ec_register(struct cros_ec_device *ec_dev) return err; } - if (ec_dev->irq) { + if (ec_dev->irq > 0) { err = devm_request_threaded_irq( dev, ec_dev->irq, ec_irq_handler, ec_irq_thread, IRQF_TRIGGER_LOW | IRQF_ONESHOT,